From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version Date: Tue, 27 Feb 2018 15:07:34 +0100 Message-ID: References: <20180108094416.4789-1-hdegoede@redhat.com> <20180213022455.GA151190@rodete-desktop-imager.corp.google.com> <8cd918fd-bf6f-70ac-e561-e7deffa695f0@redhat.com> <20180216022721.GA69988@rodete-desktop-imager.corp.google.com> <345b0de8-1a23-d2f8-bc56-507eadf7faa7@redhat.com> <6B37F6AC-1103-4FCF-A5DC-4BA236A7B11B@holtmann.org> <1a08612e-2531-3711-ec0f-a867e86d0009@redhat.com> <20180216175955.GA80944@rodete-desktop-imager.corp.google.com> <20180223031216.GA230265@rodete-desktop-imager.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Brian Norris Cc: Marcel Holtmann , "Gustavo F. Padovan" , Johan Hedberg , Bluez mailing list , linux-serial@vger.kernel.org, ACPI Devel Maling List , stable , Leif Liddy , Matthias Kaehlcke , Daniel Drake , Kai-Heng Feng , Matadeen Mishra , Linux Kernel Mailing List , Greg Kroah-Hartman , Guenter Roeck List-Id: linux-acpi@vger.kernel.org Hi, On 27-02-18 03:29, Brian Norris wrote: > On Thu, Feb 22, 2018 at 11:14 PM, Hans de Goede wrote: >> On 23-02-18 04:12, Brian Norris wrote: >>> Hmm? I'm not sure I completely follow here when you say "he was not >>> hitting the firmware loading race". If things were functioning fine with >>> system suspend (but not with autosuspend), then he's not seeing the >>> controller (quoting commit fd865802c66b) "losing power during suspend". >> >> >> He was running a kernel with the original "fd865802c66b Bluetooth: btusb: >> fix QCA Rome suspend/resume" commit, which fixes regular suspend for >> devices which are "losing power during suspend", but does nothing for >> runtime-suspend. >> >> He ran tests both with and without runtime-pm enabled with that same kernel >> and he needed to disable runtime-pm to get working bluetooth. > > Did he ever test with commit fd865802c66b reverted? > > My symptoms were exactly the same as you described. BT was broken as > of v4.14 if I had runtime suspend enabled. Things were fine if I > either (a) reverted the patch or (b) disabled runtime suspend. I > obviously preferred (a), which is why I continued to complain :) > > Did your tester ever try (a)? If not, then I don't think you've really > ensured that he really needed a "fixed" version; he may not have > needed the patch at all. > > Or an alternative question: did that system work on an older Fedora > release (and presumably an older kernel)? If so, then he probably also > did not need that patch. > >>> So, that would suggest he could only be seeing the race (as I was), and >>> that his machine does not deserve a RESET_RESUME quirk? >> >> >> I hope my above answer helps to clarify why I believe the quirk is >> necessary on his machine. > > I'm sorry, but no it doesn't. If anything, it suggests to me even more > that it may not have been necessary. Ok, I've started another test-kernel build for the reporter this time without any quirks at all and I've asked him to test. Regards, Hans