From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bPCL6-0004Zk-S7
	for qemu-devel@nongnu.org; Mon, 18 Jul 2016 13:28:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bPCL3-0004ka-Ln
	for qemu-devel@nongnu.org; Mon, 18 Jul 2016 13:28:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bPCL3-0004kN-Fd
	for qemu-devel@nongnu.org; Mon, 18 Jul 2016 13:28:17 -0400
References: <1468851450-9863-1-git-send-email-pbonzini@redhat.com>
	<578D0938.2050004@gmail.com>
	<f54518bb-d349-aa24-3bfb-c4788abfa22d@redhat.com>
	<578D0A60.4020608@gmail.com>
	<8c52110d-c009-087c-be04-3920d97af323@redhat.com>
	<578D0CD6.3080005@gmail.com>
	<4c479cb3-a8ef-caab-4dbc-3bfd014c7a0a@redhat.com>
	<578D0F42.4040203@gmail.com>
	<84ba6ace-e0bd-515a-5194-2e6704d22805@redhat.com>
	<578D1126.4060803@gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <cdf4f687-be6d-f7a5-1942-8263539f7298@redhat.com>
Date: Mon, 18 Jul 2016 19:28:13 +0200
MIME-Version: 1.0
In-Reply-To: <578D1126.4060803@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] atomics: add volatile_read/volatile_set
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>, qemu-devel@nongnu.org
Cc: sergey.fedorov@linaro.org, alex.bennee@linaro.org



On 18/07/2016 19:25, Sergey Fedorov wrote:
>> > @@ -753,14 +753,14 @@ static inline void cpu_get_invalid_tb_cpu_state(target_ulong *pc,
>> >                                                  target_ulong *cs_base,
>> >                                                  uint32_t *flags)
>> >  {
>> > -    *cs_base = -1; /* npc must be a multible of 4 */
>> > +    *flags = TB_FLAG_MMU_MASK;
>> >  }
> Hmm, not sure if it is really simpler to follow. Maybe " |= 1;" anyway?

|= 1 has the problem that tb_mark_invalid doesn't pass TB's tuple into
cpu_get_invalid_tb_cpu_state, and I didn't want to change that.  I'll
add a comment,

    /* TB_FLAG_MMU_MASK is not a valid MMU index, which makes it is an
     * impossible flag combination for valid TBs.
     */

Paolo