From: Felix Fietkau <nbd@nbd.name>
To: Stanislaw Gruszka <sgruszka@redhat.com>, linux-wireless@vger.kernel.org
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Mathias Kresin <dev@kresin.me>
Subject: Re: [PATCH 2/9] rt2800: increase TX timeout
Date: Fri, 6 Jan 2017 16:15:40 +0100 [thread overview]
Message-ID: <ce1a213e-19fe-83fa-e037-a5fefa88284e@nbd.name> (raw)
In-Reply-To: <1483707918-31480-3-git-send-email-sgruszka@redhat.com>
On 2017-01-06 14:05, Stanislaw Gruszka wrote:
> When medium is busy or frames have to be resend, it takes time to send
> the frames and get TX status from hardware. For some really bad medium
> conditions it can take seconds. Patch change TX status timeout to give
> HW more time to provide it, however 500ms is not enough for bad
> conditions. In the future this timeout should be removed and replaced
> with proper watchdog mechanism.
>
> Increase flush timeout accordingly as well.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
By the way, to make tx status reporting more robust, I would suggest
mapping tx fifo status to skb only for frames where
IEEE80211_TX_CTL_REQ_TX_STATUS is set. For all other frames, set PID=0
and return the status using ieee80211_tx_status_noskb.
I did the same in mt76 and it works quite well.
- Felix
next prev parent reply other threads:[~2017-01-06 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 13:05 [PATCH 0/9] rt2800 patches 06.01.2017 Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 1/9] rt2800usb: remove watchdog Stanislaw Gruszka
2017-01-17 11:59 ` [1/9] " Kalle Valo
2017-01-06 13:05 ` [PATCH 2/9] rt2800: increase TX timeout Stanislaw Gruszka
2017-01-06 15:15 ` Felix Fietkau [this message]
2017-01-06 15:34 ` Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 3/9] rt2x00: save conf settings before reset tuner Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 4/9] rt2800: change default retry settings Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 5/9] rt2800: tune TX_RTS_CFG config Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 6/9] rt2800: fallback from mcs8 to mcs7 Stanislaw Gruszka
2017-01-12 11:10 ` Felix Fietkau
2017-01-13 9:09 ` Stanislaw Gruszka
2017-01-13 10:11 ` [6/9] " Kalle Valo
2017-01-06 13:05 ` [PATCH 7/9] rt2800usb: mark tx failure on timeout Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 8/9] rt2x00: do not flush empty queue Stanislaw Gruszka
2017-01-06 13:05 ` [PATCH 9/9] rt2800: set max_psdu to 3 on usb devices Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1a213e-19fe-83fa-e037-a5fefa88284e@nbd.name \
--to=nbd@nbd.name \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.