From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 2/4] netns: add support of NETNSA_TARGET_NSID Date: Wed, 21 Nov 2018 14:07:43 -0700 Message-ID: References: <20181121110124.5501-1-nicolas.dichtel@6wind.com> <20181121110124.5501-3-nicolas.dichtel@6wind.com> <8fa3ba08-e488-13c8-7a2b-8227c5fd77df@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: nicolas.dichtel@6wind.com, davem@davemloft.net Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:44888 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732609AbeKVHnp (ORCPT ); Thu, 22 Nov 2018 02:43:45 -0500 Received: by mail-pl1-f193.google.com with SMTP id s5-v6so7167985plq.11 for ; Wed, 21 Nov 2018 13:07:46 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/21/18 1:58 PM, Nicolas Dichtel wrote: > The target-nsid is not stored in net_cb (not needed). ref_net is set only if > tgt_net comes from TARGET_NSID. I can add a comment. ref_net is added by this patch and it is only used (unless I missed something) to know if the put_net is needed. ie/, drop ref_net in place of nsid