From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbdCBQGP (ORCPT ); Thu, 2 Mar 2017 11:06:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54402 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbdCBPe7 (ORCPT ); Thu, 2 Mar 2017 10:34:59 -0500 Subject: Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap To: Marc Zyngier , Mian Yousaf Kaukab , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, alex.williamson@redhat.com References: <20170302151147.25909-1-yousaf.kaukab@suse.com> <9715ebce-0510-d348-2ef4-c679ae950bc3@arm.com> Cc: will.deacon@arm.com From: Auger Eric Message-ID: Date: Thu, 2 Mar 2017 16:34:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9715ebce-0510-d348-2ef4-c679ae950bc3@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 02 Mar 2017 15:34:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/03/2017 16:19, Marc Zyngier wrote: > On 02/03/17 15:11, Mian Yousaf Kaukab wrote: >> Fix following build error for s390: >> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group': >> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap' >> >> Signed-off-by: Mian Yousaf Kaukab >> --- >> History: >> v1: >> -Return false instead of true as suggested by Marc and Eric. >> -Drop 2/2 >> >> include/linux/irqdomain.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h >> index 188eced6813e..9f3616085423 100644 >> --- a/include/linux/irqdomain.h >> +++ b/include/linux/irqdomain.h >> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode( >> { >> return NULL; >> } >> +static inline bool irq_domain_check_msi_remap(void) >> +{ >> + return false; >> +} >> #endif /* !CONFIG_IRQ_DOMAIN */ >> >> #endif /* _LINUX_IRQDOMAIN_H */ >> > > Acked-by: Marc Zyngier Reviewed-by: Eric Auger Thanks! Eric > > I'll queue that now. > > Thanks, > > M. >