From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3AF0C31E45 for ; Thu, 13 Jun 2019 15:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCBE321743 for ; Thu, 13 Jun 2019 15:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="N1nJ11V+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732099AbfFMPXJ (ORCPT ); Thu, 13 Jun 2019 11:23:09 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:37340 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731915AbfFMMcU (ORCPT ); Thu, 13 Jun 2019 08:32:20 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 45Pjmc3ZLpz9tyyr; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=N1nJ11V+; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 65clM26o8HPp; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 45Pjmc2WFmz9tyyq; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1560429136; bh=3dVkbT/RsDJuQ1SDxSTRwxXBGJ5VhupziMUNo4LBj4o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=N1nJ11V+L5AV4a0LyeJq0SVfHDSz2duv88WXKKNvEFZ8+3zusPO5JEpZxTlQFHzd4 RZoRnM30BJT/mqiTv0sSAnH4QBxWDZl6W5/kY1h/TCRzMMwLMh9RDfRjPpv1c12ul3 ZhBw8Raeib2Lvu57DnSGXZ41pni+NCCtZx23x+sQ= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A25CA8B8E3; Thu, 13 Jun 2019 14:32:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id UGdLyK93zdQH; Thu, 13 Jun 2019 14:32:17 +0200 (CEST) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DBE418B8B9; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Subject: Re: [PATCH v2 1/4] crypto: talitos - move struct talitos_edesc into talitos.h To: Horia Geanta , Herbert Xu , "David S. Miller" Cc: "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" References: <7fb54918-4524-1e6b-dd29-46be8843577b@c-s.fr> From: Christophe Leroy Message-ID: Date: Thu, 13 Jun 2019 14:32:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le 13/06/2019 à 14:24, Horia Geanta a écrit : > On 6/13/2019 3:16 PM, Christophe Leroy wrote: >> >> >> Le 13/06/2019 à 14:13, Horia Geanta a écrit : >>> On 6/11/2019 5:39 PM, Christophe Leroy wrote: >>>> Next patch will require struct talitos_edesc to be defined >>>> earlier in talitos.c >>>> >>>> This patch moves it into talitos.h so that it can be used >>>> from any place in talitos.c >>>> >>>> Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on SEC1") >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Christophe Leroy >>> Again, this patch does not qualify as a fix. >>> >> >> But as I said, the following one is a fix and require that one, you told >> me to add stable in Cc: to make it explicit it was to go into stable. > Yes, but you should remove the Fixes tag. > And probably replace "Next patch" with the commit headline. > >> If someone tries to merge following one into stable with taking that one >> first, build will fail. > This shouldn't happen, order from main tree should be preserved. > When they pick up fixes, AFAIK they don't take all the preceeding commits. But ok, I'll resend. Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693D3C31E45 for ; Thu, 13 Jun 2019 12:34:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E469621721 for ; Thu, 13 Jun 2019 12:34:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="N1nJ11V+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E469621721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45PjqV42vGzDrPw for ; Thu, 13 Jun 2019 22:34:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="N1nJ11V+"; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45Pjmk2Fs4zDr1K for ; Thu, 13 Jun 2019 22:32:22 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 45Pjmc3ZLpz9tyyr; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=N1nJ11V+; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 65clM26o8HPp; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 45Pjmc2WFmz9tyyq; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1560429136; bh=3dVkbT/RsDJuQ1SDxSTRwxXBGJ5VhupziMUNo4LBj4o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=N1nJ11V+L5AV4a0LyeJq0SVfHDSz2duv88WXKKNvEFZ8+3zusPO5JEpZxTlQFHzd4 RZoRnM30BJT/mqiTv0sSAnH4QBxWDZl6W5/kY1h/TCRzMMwLMh9RDfRjPpv1c12ul3 ZhBw8Raeib2Lvu57DnSGXZ41pni+NCCtZx23x+sQ= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A25CA8B8E3; Thu, 13 Jun 2019 14:32:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id UGdLyK93zdQH; Thu, 13 Jun 2019 14:32:17 +0200 (CEST) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DBE418B8B9; Thu, 13 Jun 2019 14:32:16 +0200 (CEST) Subject: Re: [PATCH v2 1/4] crypto: talitos - move struct talitos_edesc into talitos.h To: Horia Geanta , Herbert Xu , "David S. Miller" References: <7fb54918-4524-1e6b-dd29-46be8843577b@c-s.fr> From: Christophe Leroy Message-ID: Date: Thu, 13 Jun 2019 14:32:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 13/06/2019 à 14:24, Horia Geanta a écrit : > On 6/13/2019 3:16 PM, Christophe Leroy wrote: >> >> >> Le 13/06/2019 à 14:13, Horia Geanta a écrit : >>> On 6/11/2019 5:39 PM, Christophe Leroy wrote: >>>> Next patch will require struct talitos_edesc to be defined >>>> earlier in talitos.c >>>> >>>> This patch moves it into talitos.h so that it can be used >>>> from any place in talitos.c >>>> >>>> Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on SEC1") >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Christophe Leroy >>> Again, this patch does not qualify as a fix. >>> >> >> But as I said, the following one is a fix and require that one, you told >> me to add stable in Cc: to make it explicit it was to go into stable. > Yes, but you should remove the Fixes tag. > And probably replace "Next patch" with the commit headline. > >> If someone tries to merge following one into stable with taking that one >> first, build will fail. > This shouldn't happen, order from main tree should be preserved. > When they pick up fixes, AFAIK they don't take all the preceeding commits. But ok, I'll resend. Christophe