From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6167C43381 for ; Wed, 20 Mar 2019 09:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 765422184E for ; Wed, 20 Mar 2019 09:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FudfDBAH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbfCTJeg (ORCPT ); Wed, 20 Mar 2019 05:34:36 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:33668 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725905AbfCTJef (ORCPT ); Wed, 20 Mar 2019 05:34:35 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2K9XqbB097653; Wed, 20 Mar 2019 04:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553074432; bh=dRu4mEIkh/n5bBWff4XyaPuG/oRp0w42scvWFUpjYg8=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=FudfDBAHIaJta+z1kNcyOlIFFafQZtK8d/R8lMIYvEphaRxd+qWmi6yOE20AbHAVy DGF60ie0QAXdRE9Nn2rDns5/hrrviE3ZR++yvCi7Zd8tV/FbWjm1p4xIBHZyUta2Ka Yu3ZVwO3EGBHOciH/RDuEozlVObuMsCTAbMJhF1o= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2K9Xqjv099370 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 Mar 2019 04:33:52 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 20 Mar 2019 04:33:50 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Wed, 20 Mar 2019 04:33:50 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2K9Xk34014230; Wed, 20 Mar 2019 04:33:47 -0500 Subject: Re: [PATCH v7 0/4] drm: add support for Cadence MHDP DPI/DP bridge. From: Tomi Valkeinen To: Damian Kos CC: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Sean Paul , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , , , , , , , , , References: <1548846209-16406-1-git-send-email-dkos@cadence.com> <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Message-ID: Date: Wed, 20 Mar 2019 11:33:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Damian, ping. On 31/01/2019 14:08, Tomi Valkeinen wrote: > Hi, > > On 30/01/2019 13:03, Damian Kos wrote: >> Hello! >> >> This is the series of patches that will add support for the Cadence's DPI/DP >> bridge. Please note that this is a preliminary version of the driver and there >> will be more patches in the future with updates, fixes and improvements. >> Please keep that in mind when looking at FIXME/TODO/XXX comments. >> >> Initially, MHDP driver was developed as a DRM bridge driver and was planed to >> be placed in drivers/gpu/drm/bridge/mhdp.c. However, there was already >> a driver for Cadence's DP controller developed by RockChip, but that driver >> uses the different DRM framework and looks like a part of a bigger system. >> Both controllers (including firmware) are quite different internally >> (MST/FEC/DSC support, link training done by driver, additional commands, IRQ's >> etc.) but they have similar register map, except for Framer/Streamer (which is >> noticeably different), so they appear similar. >> >> The following patches contain: >> - Moving common code to drivers/gpu/drm/bridge/cdns-mhdp-common.* and >> modifying it a bit (mostly new prefixes for functions and data types) so it >> can be used by two, higher level, drivers. >> - Modifying existing RockChip's DP driver to use the common code after changes >> made to it (use the new cdns_mhdp_device structure and new function names). >> - Modifying DRM helpers a bit. Some are required for new driver, some are >> updates from DP 1.2 to 1.3 or 1.4. >> - Adding documentation for device tree bindings. >> - Adding preliminary Cadence DPI/DP bridge driver. >> >> Some of the things that will be added later on include (but are not limited >> to): >> - DSC support >> - FEC support >> - HDCP support > > A few random comments/questions after a quick look at the patches. > > The names of the source files and the kernel Kconfig are only about > "Cadence DP". But the DT bindings is for cdns,mhdp8546, and the > resulting module file is mhdp8546.ko. I think more consistency here > would be good. > > I presume the part number (or family? are there other similar parts with > similar part numbers?) is relevant, so it should be in the Kconfig > option and help text, and probably in the file names too. The module > name should have "cdns" prefix there, similar to the source files and > the cdns-dsi.ko. > > Or maybe the same driver will handle all Cadence DP parts, in which case > generic filenames are fine, but then the resulting kernel module should > also be just "cdns-mhdp.ko". > > I see some audio functions in the code, but it's not mentioned in the DT > bindings. I'm not an audio guy, but the display bridges with audio > support I have seen have had DT bindings for the audio source too. Is > audio supported in the current driver? > > Tomi > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v7 0/4] drm: add support for Cadence MHDP DPI/DP bridge. Date: Wed, 20 Mar 2019 11:33:46 +0200 Message-ID: References: <1548846209-16406-1-git-send-email-dkos@cadence.com> <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Damian Kos Cc: Mark Rutland , devicetree@vger.kernel.org, Maxime Ripard , linux-rockchip@lists.infradead.org, David Airlie , jbergsagel@ti.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rafalc@cadence.com, Rob Herring , Laurent Pinchart , piotrs@cadence.com, Sean Paul , linux-arm-kernel@lists.infradead.org, quentin.schulz@bootlin.com List-Id: devicetree@vger.kernel.org RGFtaWFuLCBwaW5nLgoKT24gMzEvMDEvMjAxOSAxNDowOCwgVG9taSBWYWxrZWluZW4gd3JvdGU6 Cj4gSGksCj4gCj4gT24gMzAvMDEvMjAxOSAxMzowMywgRGFtaWFuIEtvcyB3cm90ZToKPj4gSGVs bG8hCj4+Cj4+IFRoaXMgaXMgdGhlIHNlcmllcyBvZiBwYXRjaGVzIHRoYXQgd2lsbCBhZGQgc3Vw cG9ydCBmb3IgdGhlIENhZGVuY2UncyBEUEkvRFAKPj4gYnJpZGdlLiBQbGVhc2Ugbm90ZSB0aGF0 IHRoaXMgaXMgYSBwcmVsaW1pbmFyeSB2ZXJzaW9uIG9mIHRoZSBkcml2ZXIgYW5kIHRoZXJlCj4+ IHdpbGwgYmUgbW9yZSBwYXRjaGVzIGluIHRoZSBmdXR1cmUgd2l0aCB1cGRhdGVzLCBmaXhlcyBh bmQgaW1wcm92ZW1lbnRzLgo+PiBQbGVhc2Uga2VlcCB0aGF0IGluIG1pbmQgd2hlbiBsb29raW5n IGF0IEZJWE1FL1RPRE8vWFhYIGNvbW1lbnRzLgo+Pgo+PiBJbml0aWFsbHksIE1IRFAgZHJpdmVy IHdhcyBkZXZlbG9wZWQgYXMgYSBEUk0gYnJpZGdlIGRyaXZlciBhbmQgd2FzIHBsYW5lZCB0bwo+ PiBiZSBwbGFjZWQgaW4gZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9taGRwLmMuICBIb3dldmVyLCB0 aGVyZSB3YXMgYWxyZWFkeQo+PiBhIGRyaXZlciBmb3IgQ2FkZW5jZSdzIERQIGNvbnRyb2xsZXIg ZGV2ZWxvcGVkIGJ5IFJvY2tDaGlwLCBidXQgdGhhdCBkcml2ZXIKPj4gdXNlcyB0aGUgZGlmZmVy ZW50IERSTSBmcmFtZXdvcmsgYW5kIGxvb2tzIGxpa2UgYSBwYXJ0IG9mIGEgYmlnZ2VyIHN5c3Rl bS4KPj4gQm90aCBjb250cm9sbGVycyAoaW5jbHVkaW5nIGZpcm13YXJlKSBhcmUgcXVpdGUgZGlm ZmVyZW50IGludGVybmFsbHkKPj4gKE1TVC9GRUMvRFNDIHN1cHBvcnQsIGxpbmsgdHJhaW5pbmcg ZG9uZSBieSBkcml2ZXIsIGFkZGl0aW9uYWwgY29tbWFuZHMsIElSUSdzCj4+IGV0Yy4pIGJ1dCB0 aGV5IGhhdmUgc2ltaWxhciByZWdpc3RlciBtYXAsIGV4Y2VwdCBmb3IgRnJhbWVyL1N0cmVhbWVy ICh3aGljaCBpcwo+PiBub3RpY2VhYmx5IGRpZmZlcmVudCksIHNvIHRoZXkgYXBwZWFyIHNpbWls YXIuCj4+Cj4+IFRoZSBmb2xsb3dpbmcgcGF0Y2hlcyBjb250YWluOgo+PiAtIE1vdmluZyBjb21t b24gY29kZSB0byBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2NkbnMtbWhkcC1jb21tb24uKiBhbmQK Pj4gICBtb2RpZnlpbmcgaXQgYSBiaXQgKG1vc3RseSBuZXcgcHJlZml4ZXMgZm9yIGZ1bmN0aW9u cyBhbmQgZGF0YSB0eXBlcykgc28gaXQKPj4gICBjYW4gYmUgdXNlZCBieSB0d28sIGhpZ2hlciBs ZXZlbCwgZHJpdmVycy4KPj4gLSBNb2RpZnlpbmcgZXhpc3RpbmcgUm9ja0NoaXAncyBEUCBkcml2 ZXIgdG8gdXNlIHRoZSBjb21tb24gY29kZSBhZnRlciBjaGFuZ2VzCj4+ICAgbWFkZSB0byBpdCAo dXNlIHRoZSBuZXcgY2Ruc19taGRwX2RldmljZSBzdHJ1Y3R1cmUgYW5kIG5ldyBmdW5jdGlvbiBu YW1lcykuCj4+IC0gTW9kaWZ5aW5nIERSTSBoZWxwZXJzIGEgYml0LiBTb21lIGFyZSByZXF1aXJl ZCBmb3IgbmV3IGRyaXZlciwgc29tZSBhcmUKPj4gICB1cGRhdGVzIGZyb20gRFAgMS4yIHRvIDEu MyBvciAxLjQuCj4+IC0gQWRkaW5nIGRvY3VtZW50YXRpb24gZm9yIGRldmljZSB0cmVlIGJpbmRp bmdzLgo+PiAtIEFkZGluZyBwcmVsaW1pbmFyeSBDYWRlbmNlIERQSS9EUCBicmlkZ2UgZHJpdmVy Lgo+Pgo+PiBTb21lIG9mIHRoZSB0aGluZ3MgdGhhdCB3aWxsIGJlIGFkZGVkIGxhdGVyIG9uIGlu Y2x1ZGUgKGJ1dCBhcmUgbm90IGxpbWl0ZWQKPj4gdG8pOgo+PiAtIERTQyBzdXBwb3J0Cj4+IC0g RkVDIHN1cHBvcnQKPj4gLSBIRENQIHN1cHBvcnQKPiAKPiBBIGZldyByYW5kb20gY29tbWVudHMv cXVlc3Rpb25zIGFmdGVyIGEgcXVpY2sgbG9vayBhdCB0aGUgcGF0Y2hlcy4KPiAKPiBUaGUgbmFt ZXMgb2YgdGhlIHNvdXJjZSBmaWxlcyBhbmQgdGhlIGtlcm5lbCBLY29uZmlnIGFyZSBvbmx5IGFi b3V0Cj4gIkNhZGVuY2UgRFAiLiBCdXQgdGhlIERUIGJpbmRpbmdzIGlzIGZvciBjZG5zLG1oZHA4 NTQ2LCBhbmQgdGhlCj4gcmVzdWx0aW5nIG1vZHVsZSBmaWxlIGlzIG1oZHA4NTQ2LmtvLiBJIHRo aW5rIG1vcmUgY29uc2lzdGVuY3kgaGVyZQo+IHdvdWxkIGJlIGdvb2QuCj4gCj4gSSBwcmVzdW1l IHRoZSBwYXJ0IG51bWJlciAob3IgZmFtaWx5PyBhcmUgdGhlcmUgb3RoZXIgc2ltaWxhciBwYXJ0 cyB3aXRoCj4gc2ltaWxhciBwYXJ0IG51bWJlcnM/KSBpcyByZWxldmFudCwgc28gaXQgc2hvdWxk IGJlIGluIHRoZSBLY29uZmlnCj4gb3B0aW9uIGFuZCBoZWxwIHRleHQsIGFuZCBwcm9iYWJseSBp biB0aGUgZmlsZSBuYW1lcyB0b28uIFRoZSBtb2R1bGUKPiBuYW1lIHNob3VsZCBoYXZlICJjZG5z IiBwcmVmaXggdGhlcmUsIHNpbWlsYXIgdG8gdGhlIHNvdXJjZSBmaWxlcyBhbmQKPiB0aGUgY2Ru cy1kc2kua28uCj4gCj4gT3IgbWF5YmUgdGhlIHNhbWUgZHJpdmVyIHdpbGwgaGFuZGxlIGFsbCBD YWRlbmNlIERQIHBhcnRzLCBpbiB3aGljaCBjYXNlCj4gZ2VuZXJpYyBmaWxlbmFtZXMgYXJlIGZp bmUsIGJ1dCB0aGVuIHRoZSByZXN1bHRpbmcga2VybmVsIG1vZHVsZSBzaG91bGQKPiBhbHNvIGJl IGp1c3QgImNkbnMtbWhkcC5rbyIuCj4gCj4gSSBzZWUgc29tZSBhdWRpbyBmdW5jdGlvbnMgaW4g dGhlIGNvZGUsIGJ1dCBpdCdzIG5vdCBtZW50aW9uZWQgaW4gdGhlIERUCj4gYmluZGluZ3MuIEkn bSBub3QgYW4gYXVkaW8gZ3V5LCBidXQgdGhlIGRpc3BsYXkgYnJpZGdlcyB3aXRoIGF1ZGlvCj4g c3VwcG9ydCBJIGhhdmUgc2VlbiBoYXZlIGhhZCBEVCBiaW5kaW5ncyBmb3IgdGhlIGF1ZGlvIHNv dXJjZSB0b28uIElzCj4gYXVkaW8gc3VwcG9ydGVkIGluIHRoZSBjdXJyZW50IGRyaXZlcj8KPiAK PiAgVG9taQo+IAoKLS0gClRleGFzIEluc3RydW1lbnRzIEZpbmxhbmQgT3ksIFBvcmtrYWxhbmth dHUgMjIsIDAwMTgwIEhlbHNpbmtpLgpZLXR1bm51cy9CdXNpbmVzcyBJRDogMDYxNTUyMS00LiBL b3RpcGFpa2thL0RvbWljaWxlOiBIZWxzaW5raQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F24C43381 for ; Wed, 20 Mar 2019 09:34:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A912184E for ; Wed, 20 Mar 2019 09:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y/5bQSHe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FudfDBAH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42A912184E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oHAxNR9kAZITl8QsmnJBORKUwYMt5tKOJzV/sV+yWy4=; b=Y/5bQSHe+TA/Lq 7TFTJifvfdLrs4e/hhXoQyxMZr2Zoe1YgLyE4QlVdzm7ElQXSmMr6Gi9YWPODbUiT+p5vhk3qP10z 64gUnpjPZL0XRgcs8gaXoK46YS8Lj/jJxRBvOa6ZlOsWuQ+s7XzoXd9U4uh+TZ+gJGzt8Gc+Wll3m 5T1RBDc3etD67SUCYZJUUoL0eeIujN44+HaYc7dHSPTn1PiG8VuLB6OSi6S09/trAe9RVc7W335Lz keLQggMn7m/77wy2jSQ3sHP7nKUHy/3mBl8eLZanBPjATywDR+6v8NP7QdT2cUiKGOqb6pMIFbPGw xvk8vXiK5AllK5WyN/cQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Xc7-0006cJ-C5; Wed, 20 Mar 2019 09:34:23 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6Xbz-0006ar-Me; Wed, 20 Mar 2019 09:34:21 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2K9XqbB097653; Wed, 20 Mar 2019 04:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553074432; bh=dRu4mEIkh/n5bBWff4XyaPuG/oRp0w42scvWFUpjYg8=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=FudfDBAHIaJta+z1kNcyOlIFFafQZtK8d/R8lMIYvEphaRxd+qWmi6yOE20AbHAVy DGF60ie0QAXdRE9Nn2rDns5/hrrviE3ZR++yvCi7Zd8tV/FbWjm1p4xIBHZyUta2Ka Yu3ZVwO3EGBHOciH/RDuEozlVObuMsCTAbMJhF1o= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2K9Xqjv099370 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 Mar 2019 04:33:52 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 20 Mar 2019 04:33:50 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Wed, 20 Mar 2019 04:33:50 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2K9Xk34014230; Wed, 20 Mar 2019 04:33:47 -0500 Subject: Re: [PATCH v7 0/4] drm: add support for Cadence MHDP DPI/DP bridge. From: Tomi Valkeinen To: Damian Kos References: <1548846209-16406-1-git-send-email-dkos@cadence.com> <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Message-ID: Date: Wed, 20 Mar 2019 11:33:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <0f11a4d8-d576-5af8-b7f4-afe3ff26678f@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_023415_911728_89197CC7 X-CRM114-Status: GOOD ( 26.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Maxime Ripard , =?UTF-8?Q?Heiko_St=c3=bcbner?= , linux-rockchip@lists.infradead.org, David Airlie , jbergsagel@ti.com, Maarten Lankhorst , Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andrzej Hajda , rafalc@cadence.com, Rob Herring , Laurent Pinchart , Daniel Vetter , piotrs@cadence.com, Sean Paul , linux-arm-kernel@lists.infradead.org, quentin.schulz@bootlin.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Damian, ping. On 31/01/2019 14:08, Tomi Valkeinen wrote: > Hi, > > On 30/01/2019 13:03, Damian Kos wrote: >> Hello! >> >> This is the series of patches that will add support for the Cadence's DPI/DP >> bridge. Please note that this is a preliminary version of the driver and there >> will be more patches in the future with updates, fixes and improvements. >> Please keep that in mind when looking at FIXME/TODO/XXX comments. >> >> Initially, MHDP driver was developed as a DRM bridge driver and was planed to >> be placed in drivers/gpu/drm/bridge/mhdp.c. However, there was already >> a driver for Cadence's DP controller developed by RockChip, but that driver >> uses the different DRM framework and looks like a part of a bigger system. >> Both controllers (including firmware) are quite different internally >> (MST/FEC/DSC support, link training done by driver, additional commands, IRQ's >> etc.) but they have similar register map, except for Framer/Streamer (which is >> noticeably different), so they appear similar. >> >> The following patches contain: >> - Moving common code to drivers/gpu/drm/bridge/cdns-mhdp-common.* and >> modifying it a bit (mostly new prefixes for functions and data types) so it >> can be used by two, higher level, drivers. >> - Modifying existing RockChip's DP driver to use the common code after changes >> made to it (use the new cdns_mhdp_device structure and new function names). >> - Modifying DRM helpers a bit. Some are required for new driver, some are >> updates from DP 1.2 to 1.3 or 1.4. >> - Adding documentation for device tree bindings. >> - Adding preliminary Cadence DPI/DP bridge driver. >> >> Some of the things that will be added later on include (but are not limited >> to): >> - DSC support >> - FEC support >> - HDCP support > > A few random comments/questions after a quick look at the patches. > > The names of the source files and the kernel Kconfig are only about > "Cadence DP". But the DT bindings is for cdns,mhdp8546, and the > resulting module file is mhdp8546.ko. I think more consistency here > would be good. > > I presume the part number (or family? are there other similar parts with > similar part numbers?) is relevant, so it should be in the Kconfig > option and help text, and probably in the file names too. The module > name should have "cdns" prefix there, similar to the source files and > the cdns-dsi.ko. > > Or maybe the same driver will handle all Cadence DP parts, in which case > generic filenames are fine, but then the resulting kernel module should > also be just "cdns-mhdp.ko". > > I see some audio functions in the code, but it's not mentioned in the DT > bindings. I'm not an audio guy, but the display bridges with audio > support I have seen have had DT bindings for the audio source too. Is > audio supported in the current driver? > > Tomi > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel