All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Marvin Liu <yong.liu@intel.com>,
	tiwei.bie@intel.com, zhihong.wang@intel.com, amorenoz@redhat.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: fix dirty page logging missing
Date: Wed, 6 Nov 2019 21:29:36 +0100	[thread overview]
Message-ID: <ce6f4a7f-8060-1bab-19bb-90758b4e95a4@redhat.com> (raw)
In-Reply-To: <20191104111547.54885-1-yong.liu@intel.com>



On 11/4/19 12:15 PM, Marvin Liu wrote:
> Packets data are directly copied when doing batch enqueue, add missed
> dirty page logging after memory copy.
> 
> Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
>  lib/librte_vhost/virtio_net.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index eae7825f0..0c33af7b1 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -1107,6 +1107,10 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,
>  			   pkts[i]->pkt_len);
>  	}
>  
> +	vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
> +		vhost_log_cache_write_iova(dev, vq, descs[avail_idx + i].addr,
> +					   lens[i]);
> +
>  	vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
>  		ids[i] = descs[avail_idx + i].id;
>  
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2019-11-06 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 11:15 [dpdk-dev] [PATCH] vhost: fix dirty page logging missing Marvin Liu
2019-11-06 20:29 ` Maxime Coquelin [this message]
2019-11-06 21:00 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce6f4a7f-8060-1bab-19bb-90758b4e95a4@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=dev@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=yong.liu@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.