From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBCB2C3DA7D for ; Tue, 3 Jan 2023 12:50:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237698AbjACMuC (ORCPT ); Tue, 3 Jan 2023 07:50:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237679AbjACMtw (ORCPT ); Tue, 3 Jan 2023 07:49:52 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2206106; Tue, 3 Jan 2023 04:49:51 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 305F76602CFA; Tue, 3 Jan 2023 12:49:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1672750190; bh=kLb7ZxO/t10qRzNfWMcuhgJ9EXOlFXY8vbB18QInejQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dqiCSMgQvi/04qrMXM6nENACo5DfvsyNuLBxHdjm3iaDh+jiqP2f+pEGbpB5tKNMm CeNrXN8Miys+y2TnDxifNRqNSS5y91iRZxqE/syBbreZbXoH+PNCJ8rMkgUmIEF57y L2g5z5fVE3XQl6xV0WABHmbUM7H5HbXwnGQcRSe6y7klzW0CUmQxXbxC08ZJUR+Ozy hC8xuurNE4CWoffNSwqdp7SjhyDWmH4F4sgvrDdYbeWTvZ93GXvbuU5n9nFWnz4ice BbfrWupgmsJBDWGmNYV5bNxTXJ3pSbHGi/Y5/tXeW+CjoTCS5qbS7rrVLQUtT1WZlX G97ur71uMRGmg== Message-ID: Date: Tue, 3 Jan 2023 13:49:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail Content-Language: en-US To: Roger Lu , Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat Cc: Fan Chen , Jia-wei Chang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221226094248.4506-1-roger.lu@mediatek.com> <20221226094248.4506-11-roger.lu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221226094248.4506-11-roger.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/12/22 10:42, Roger Lu ha scritto: > If svs init02 fail, it means we cannot rely on svs bank voltages anymore. > We need to disable svs function and restore DVFS opp voltages back to the > default voltages for making sure we have enough DVFS voltages. > > Signed-off-by: Roger Lu This needs a Fixes tag... and it also needs to apply to older kernels, as MT8183 does use SVS in previous versions. Perhaps you can send a different patch, without the cleanups, only for the backport? Otherwise you'll have to duplicate svs_bank_disable_and_restore_default_volts() again before cleaning up... I'll leave the choice to you. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7316DC46467 for ; Tue, 3 Jan 2023 14:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LyRyEkzI8Ws2E2QEjGdEqCjdMxgE6BmaO3XNn47rYgA=; b=hmhSLZQwTRFdOK 1Yp5Uqjncnni4gErK7cBMcPNaTkVGnK4sPswv0ztS0dAkg+gyAHOZr96UikvTXLrU77Oqorcu7KkV 81A4lg3SO/Tx7ln0YzurqKP2sq0Uy1B/6IKdcmjpOESOmPMEtiFu3+hBjoLkqJWEl76ONbo8U2VKx bGD419ybLhu/ed123uWjT+yGuFrnpku2OBokavK8EDvJXwN4E0YvscrlWUQbEFwI2j/eGy5Mbj67u HxbquZXDOSqDXfg/W0pkVAkmppd69XzomOZB6QktZ36II1NsqSqgYUzV3KpXHo19CpnucDeWuROX+ o6xNhELSROJAHh6BMuRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCiPv-0022DH-PK; Tue, 03 Jan 2023 14:37:30 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCgjn-001LUy-Uw; Tue, 03 Jan 2023 12:49:53 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 305F76602CFA; Tue, 3 Jan 2023 12:49:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1672750190; bh=kLb7ZxO/t10qRzNfWMcuhgJ9EXOlFXY8vbB18QInejQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dqiCSMgQvi/04qrMXM6nENACo5DfvsyNuLBxHdjm3iaDh+jiqP2f+pEGbpB5tKNMm CeNrXN8Miys+y2TnDxifNRqNSS5y91iRZxqE/syBbreZbXoH+PNCJ8rMkgUmIEF57y L2g5z5fVE3XQl6xV0WABHmbUM7H5HbXwnGQcRSe6y7klzW0CUmQxXbxC08ZJUR+Ozy hC8xuurNE4CWoffNSwqdp7SjhyDWmH4F4sgvrDdYbeWTvZ93GXvbuU5n9nFWnz4ice BbfrWupgmsJBDWGmNYV5bNxTXJ3pSbHGi/Y5/tXeW+CjoTCS5qbS7rrVLQUtT1WZlX G97ur71uMRGmg== Message-ID: Date: Tue, 3 Jan 2023 13:49:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail Content-Language: en-US To: Roger Lu , Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat Cc: Fan Chen , Jia-wei Chang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221226094248.4506-1-roger.lu@mediatek.com> <20221226094248.4506-11-roger.lu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221226094248.4506-11-roger.lu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_044952_207898_2D30C5B8 X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 26/12/22 10:42, Roger Lu ha scritto: > If svs init02 fail, it means we cannot rely on svs bank voltages anymore. > We need to disable svs function and restore DVFS opp voltages back to the > default voltages for making sure we have enough DVFS voltages. > > Signed-off-by: Roger Lu This needs a Fixes tag... and it also needs to apply to older kernels, as MT8183 does use SVS in previous versions. Perhaps you can send a different patch, without the cleanups, only for the backport? Otherwise you'll have to duplicate svs_bank_disable_and_restore_default_volts() again before cleaning up... I'll leave the choice to you. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel