From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F72CC433F5 for ; Wed, 20 Apr 2022 12:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378589AbiDTMeb (ORCPT ); Wed, 20 Apr 2022 08:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378687AbiDTMcg (ORCPT ); Wed, 20 Apr 2022 08:32:36 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E9AE41; Wed, 20 Apr 2022 05:29:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 529E31F385; Wed, 20 Apr 2022 12:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1650457788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EzLfToD3p9OXJhz5oFO7rfMu9PCtRyf++jLmq/TIJY=; b=kgidIw2dv6D3V/YXt5wUFNyspBoJc4Dvj6XmB3McoHeYLui6/rkI3Q+9ohHhbZxOcrn+pP 1lWh8nIQGGxJHt7nCkQYx2fpHGlLHzTr+QhAQwdCwvvhugxqB7qLdWAa1QMkr4SOQ0COAB rXvj4BSXZ+tNDqEm5uGKbG4fv2cU/bA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1650457788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EzLfToD3p9OXJhz5oFO7rfMu9PCtRyf++jLmq/TIJY=; b=Ziq0bJ+mJvgptb9cpImhV1EbAkRJheEAIzxIQJ/4i3ZTCuEpT8dTxOkqJcokELKGK2/MaK bJAxa0SKhCx4YzCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0757A13A30; Wed, 20 Apr 2022 12:29:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8nzoALz8X2K2ZAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 12:29:48 +0000 Message-ID: Date: Wed, 20 Apr 2022 14:29:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 4/4] scsi: hisi_sas: Use libsas internal abort support Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com, damien.lemoal@opensource.wdc.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ajish.Koshy@microchip.com, linuxarm@huawei.com, Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com, chenxiang66@hisilicon.com References: <1646309930-138960-1-git-send-email-john.garry@huawei.com> <1646309930-138960-5-git-send-email-john.garry@huawei.com> From: Hannes Reinecke In-Reply-To: <1646309930-138960-5-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/3/22 13:18, John Garry wrote: > Use the common libsas internal abort functionality. > > In addition, this driver has special handling for internal abort timeouts - > specifically whether to reset the controller in that instance, so extend > the API for that. > Huh? Is there a reason _not_ to reset the controller once abort times out? And why isn't that delegated to SCSI EH? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer