From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Thu, 28 May 2020 09:54:42 +0200 Subject: [PATCH] tbs2910: migrate to DM_VIDEO In-Reply-To: <20200526221311.752bc883@crub> References: <20200522232417.4202-1-agust@denx.de> <20200526221311.752bc883@crub> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26.05.20 22:13, Anatolij Gustschin wrote: > On Sun, 24 May 2020 17:46:22 +0200 > Soeren Moch smoch at web.de wrote: > >> On 23.05.20 01:24, Anatolij Gustschin wrote: >>> Migration to DM_VIDEO driver is long overdue, configure it in >>> board config files. To enable the display set stdout like: >>> >>> setenv stdout serial,vidconsole >>> >>> Signed-off-by: Anatolij Gustschin >>> --- >>> This is only build tested. >> I tested this on top of v2020.07-rc2 and your patch >> "video: extend stdout video console work-around for 'vga'" >> >> Works great. However, some comments below. > Thanks for testing! > > ... >>> +CONFIG_SYS_MALLOC_F_LEN=0x4000 >> This is not necessary. The default 0x2000 also works fine. > Dropped in v2. > > ... >> Since DM_VIDEO requires vidconsole as output device, please also add >> >> ---8<--- >> diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h >> index 8ab3fcfe3e..82165a9ffe 100644 >> --- a/include/configs/tbs2910.h >> +++ b/include/configs/tbs2910.h >> @@ -92,11 +92,11 @@ >> ??????? "fan=gpio set 92\0" \ >> ??????? "set_con_serial=setenv stdout serial; " \ >> ??????????????????????? "setenv stderr serial\0" \ >> -?????? "set_con_hdmi=setenv stdout serial,vga; " \ >> -?????????????????????? "setenv stderr serial,vga\0" \ >> -?????? "stderr=serial,vga\0" \ >> +?????? "set_con_hdmi=setenv stdout serial,vidconsole; " \ >> +?????????????????????? "setenv stderr serial,vidconsole\0" \ >> +?????? "stderr=serial,vidconsole\0" \ >> ??????? "stdin=serial,usbkbd\0" \ >> -?????? "stdout=serial,vga\0" >> +?????? "stdout=serial,vidconsole\0" >> ? >> ?#define CONFIG_BOOTCOMMAND \ >> ??????? "mmc rescan; " \ >> ---8<--- >> >> to avoid warnings for users with default environment.(not sure if >> whitespace is still correct in this snippet) > Done in v2. > >> With this DM_VIDEO conversion the board comes very close to the size >> limit. While it works with my toolchain, there might be problems with >> others. So maybe not a good idea to merge this as fix immediately. > Yes, with GCC 9.2 it didn't work any more. I've submitted some DM_VIDEO > patches to disable more unused code to fix this. > >> Since this depends on your above mentioned patch, do you plan to merge >> this via u-boot-video, or should this go as usual through the imx tree? > I'll merge this via u-boot-video tree. v2 patch depends on a few more > video patches which are under review/built-test currently. OK, I will try to test this new version again on top of your other patches. Do you plan to merge this for v2020.07, or for -next? Soeren