From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24BE4C433F5 for ; Sat, 16 Apr 2022 02:53:31 +0000 (UTC) Received: from localhost ([::1]:54140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfYZ0-0006ww-8j for qemu-devel@archiver.kernel.org; Fri, 15 Apr 2022 22:53:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfYWk-0004NH-1Z for qemu-devel@nongnu.org; Fri, 15 Apr 2022 22:51:10 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:40610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfYWi-0003V7-Bd for qemu-devel@nongnu.org; Fri, 15 Apr 2022 22:51:09 -0400 Received: by mail-pl1-x62c.google.com with SMTP id t12so8365592pll.7 for ; Fri, 15 Apr 2022 19:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OcSW40ivplWynaPtysiaX5v+rRRaY+4JHspclU179IQ=; b=cCiEbW+JTk1XC3JypG/Y7YCa7QAJYkqlwfJZsdtRywdC2lZh39rBu0zD43yJSPgZwn PIgw+C0ZACYJ1GVRGr9R261D63dsDm3+fTU8LMb7aoxnxYtnrD9oEKNicMG27snPu+5t mNEzzR8c7CYDjkG4SmUSZq9sJdkKSvXuwl5t8KqYaplA3bw09MTMVAlD1KLwMwLyo/jY giKHogS1t+lJJdhUyx3ezp7QsTgwyC/44qjsqyzCtzpOZD/dR7JKjzmAX27qirLkcuPx /NhVI/QKOgzqdJHIksGHJc4uTDP7PpTLQNZBtdmhnXMPQBItRfly9cB/vc4grk4gPAX6 gvRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OcSW40ivplWynaPtysiaX5v+rRRaY+4JHspclU179IQ=; b=PaeIubDA5usVov7aUR/IlNPPmS3dlW/u9W5MJGhCZJPd+dbO0BpOCRcMLRwo9XVmab LvSTFLljwhrsmw8kvrhDxVwIHJfgbugAij/3VTrHSXzEhyh2jrO2RuGDE8IuzABjQPjZ iYXGoMuyHmGv+xVMBb3VfeCxIF9u7TRQcADBT/pQ0NT42ek3D7I7fJ1O36+NeLM6Kk8P N8c30wsiPiCL8cwLvgnVgaqGQXz7KtTNo4juGpv5VI6+qyz+iHEyHTo+STBWbJ/mTd/K xHUYHagYmHF/OCgVjFNpcbDhQFuKzkgcZxmGy2R7vrf9NQXW+igi54lPJy/4q7+v7HcH KaGQ== X-Gm-Message-State: AOAM532S4Qsotl46zBSwwGISAVGhQxhEk/oeDxXuk1JgTPK4GYkRJ/QU KNJMZ99Vy733KcCyUMpva1ieNA== X-Google-Smtp-Source: ABdhPJxiUZzRBHLi8iruQNkyFJgnV8lRTCM0IcGnrr/B+nEfrjeHtsNjuQWDO4DRGpfVs+okeIJyaQ== X-Received: by 2002:a17:902:edd1:b0:158:8318:b51e with SMTP id q17-20020a170902edd100b001588318b51emr1852573plk.89.1650077467019; Fri, 15 Apr 2022 19:51:07 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id c25-20020a62e819000000b0050a442a510bsm2928546pfi.31.2022.04.15.19.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 19:51:06 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 19:51:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v10 07/14] target/riscv: rvk: add support for zkne/zknd extension in RV64 Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20220416023549.28463-1-liweiwei@iscas.ac.cn> <20220416023549.28463-8-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20220416023549.28463-8-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, luruibo2000@163.com, lustrew@foxmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/15/22 19:35, Weiwei Li wrote: > +target_ulong HELPER(aes64esm)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, true, true); > +} > + > +target_ulong HELPER(aes64es)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, true, false); > +} > + > +target_ulong HELPER(aes64ds)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, false, false); > +} > + > +target_ulong HELPER(aes64dsm)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, false, true); > +} Missing REQUIRE_64BIT tests. r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nfYWl-0004O9-4g for mharc-qemu-riscv@gnu.org; Fri, 15 Apr 2022 22:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfYWj-0004NC-Rb for qemu-riscv@nongnu.org; Fri, 15 Apr 2022 22:51:09 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:51165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfYWi-0003V6-AJ for qemu-riscv@nongnu.org; Fri, 15 Apr 2022 22:51:09 -0400 Received: by mail-pj1-x102e.google.com with SMTP id o5so8895115pjr.0 for ; Fri, 15 Apr 2022 19:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OcSW40ivplWynaPtysiaX5v+rRRaY+4JHspclU179IQ=; b=cCiEbW+JTk1XC3JypG/Y7YCa7QAJYkqlwfJZsdtRywdC2lZh39rBu0zD43yJSPgZwn PIgw+C0ZACYJ1GVRGr9R261D63dsDm3+fTU8LMb7aoxnxYtnrD9oEKNicMG27snPu+5t mNEzzR8c7CYDjkG4SmUSZq9sJdkKSvXuwl5t8KqYaplA3bw09MTMVAlD1KLwMwLyo/jY giKHogS1t+lJJdhUyx3ezp7QsTgwyC/44qjsqyzCtzpOZD/dR7JKjzmAX27qirLkcuPx /NhVI/QKOgzqdJHIksGHJc4uTDP7PpTLQNZBtdmhnXMPQBItRfly9cB/vc4grk4gPAX6 gvRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OcSW40ivplWynaPtysiaX5v+rRRaY+4JHspclU179IQ=; b=T2gzO3M95lETGDRtB8zU2OGgKAED2SpBrLH4VP+j+v9RVhAPwXzKzFNnS6dk0CkJz3 1PoDoNmDziDODGMm0XnZBUS/cq7SnMQQaxr0ev6bDdQuHb5X6uyIjTdq6S6bN86KoxAk Gn90wHmp7h7Qqx5xm+frOzZYYyQB1lBCPTb3pZ0rtPQv/sh+gVhCuwHc411shSvfoRQD j/Ve9/P/e4JrehN+IAy/cMeFdq750zbSoOJMuaG///R34xRvvy3I7maGdl3Ak75kgm0l 8rRHdtbgA6tNiXUKqkDqbR1TB5ufxtgFBCxR091bhm+QcMRuK2cyK9toXRh0KiANWeC4 TwAQ== X-Gm-Message-State: AOAM530EX77cg0O8gYN0LYk7HtZtPlx6H5/wM54DQFLdE7uEthTBF5Ud UuKQn2jTr85GdVeZ5HA8lgHPnQ== X-Google-Smtp-Source: ABdhPJxiUZzRBHLi8iruQNkyFJgnV8lRTCM0IcGnrr/B+nEfrjeHtsNjuQWDO4DRGpfVs+okeIJyaQ== X-Received: by 2002:a17:902:edd1:b0:158:8318:b51e with SMTP id q17-20020a170902edd100b001588318b51emr1852573plk.89.1650077467019; Fri, 15 Apr 2022 19:51:07 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id c25-20020a62e819000000b0050a442a510bsm2928546pfi.31.2022.04.15.19.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 19:51:06 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 19:51:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v10 07/14] target/riscv: rvk: add support for zkne/zknd extension in RV64 Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, lustrew@foxmail.com, luruibo2000@163.com References: <20220416023549.28463-1-liweiwei@iscas.ac.cn> <20220416023549.28463-8-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20220416023549.28463-8-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Apr 2022 02:51:10 -0000 On 4/15/22 19:35, Weiwei Li wrote: > +target_ulong HELPER(aes64esm)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, true, true); > +} > + > +target_ulong HELPER(aes64es)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, true, false); > +} > + > +target_ulong HELPER(aes64ds)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, false, false); > +} > + > +target_ulong HELPER(aes64dsm)(target_ulong rs1, target_ulong rs2) > +{ > + return aes64_operation(rs1, rs2, false, true); > +} Missing REQUIRE_64BIT tests. r~