From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A153BC2D0DB for ; Fri, 24 Jan 2020 18:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75BE42081E for ; Fri, 24 Jan 2020 18:03:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="dUsFWZYM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391173AbgAXSD4 (ORCPT ); Fri, 24 Jan 2020 13:03:56 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:31338 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390696AbgAXSD4 (ORCPT ); Fri, 24 Jan 2020 13:03:56 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579889035; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=/wvlJaRdxr+I0mnJPd3iMiQ1F3dK2CPJjaJ02DPirBo=; b=dUsFWZYM7cvoAuE+4xejBcXaNDY+nAx/2uaqr05Bk+Dr6sp7Yh6AsCVyWusz7nqHgLv0M5Af yLZQq/T5GaLSp2DX3sz8o4RWNCXGH6gr4jymER9o1Pce4dx9yaoNn908hTzmmjewnlR6qLMF i9XG88X0xe4SI9xxUr8QqqV3RjA= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2b317b.7f0189c55bc8-smtp-out-n02; Fri, 24 Jan 2020 18:03:39 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 344B6C447B2; Fri, 24 Jan 2020 18:03:37 +0000 (UTC) Received: from [10.46.161.159] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id EC3A1C447A2; Fri, 24 Jan 2020 18:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EC3A1C447A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v4 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4 To: Can Guo , nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Venkat Gopalakrishnan , Tomas Winkler , Bean Huo , Greg Kroah-Hartman , Thomas Gleixner , Allison Randal , open list References: <1579764349-15578-1-git-send-email-cang@codeaurora.org> <1579764349-15578-9-git-send-email-cang@codeaurora.org> From: "Asutosh Das (asd)" Message-ID: Date: Fri, 24 Jan 2020 10:03:35 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1579764349-15578-9-git-send-email-cang@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/2020 11:25 PM, Can Guo wrote: > ADAPT is added specifically for HS Gear4 mode only, select INITIAL adapt > before do power mode change to G4 and select no adapt before switch to > non-G4 modes. > > Signed-off-by: Can Guo > --- LGTM. Reviewed-by: Asutosh Das > drivers/scsi/ufs/ufshcd.c | 14 +++++++++++++- > drivers/scsi/ufs/ufshci.h | 1 + > drivers/scsi/ufs/unipro.h | 7 +++++++ > 3 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 1ee2187..f6d4828 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4134,6 +4134,17 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, > ufshcd_dme_set(hba, UIC_ARG_MIB(PA_HSSERIES), > pwr_mode->hs_rate); > > + if (hba->ufs_version >= UFSHCI_VERSION_30) { > + if (pwr_mode->gear_tx == UFS_HS_G4) > + /* INITIAL ADAPT */ > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXHSADAPTTYPE), > + PA_INITIAL_ADAPT); > + else > + /* NO ADAPT */ > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXHSADAPTTYPE), > + PA_NO_ADAPT); > + } > + > ret = ufshcd_uic_change_pwr_mode(hba, pwr_mode->pwr_rx << 4 > | pwr_mode->pwr_tx); > > @@ -8422,7 +8433,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) > if ((hba->ufs_version != UFSHCI_VERSION_10) && > (hba->ufs_version != UFSHCI_VERSION_11) && > (hba->ufs_version != UFSHCI_VERSION_20) && > - (hba->ufs_version != UFSHCI_VERSION_21)) > + (hba->ufs_version != UFSHCI_VERSION_21) && > + (hba->ufs_version != UFSHCI_VERSION_30)) > dev_err(hba->dev, "invalid UFS version 0x%x\n", > hba->ufs_version); > > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h > index dbb75cd..95b4b03 100644 > --- a/drivers/scsi/ufs/ufshci.h > +++ b/drivers/scsi/ufs/ufshci.h > @@ -104,6 +104,7 @@ enum { > UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */ > UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */ > UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */ > + UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */ > }; > > /* > diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h > index f539f87..960d175 100644 > --- a/drivers/scsi/ufs/unipro.h > +++ b/drivers/scsi/ufs/unipro.h > @@ -146,6 +146,12 @@ > #define PA_SLEEPNOCONFIGTIME 0x15A2 > #define PA_STALLNOCONFIGTIME 0x15A3 > #define PA_SAVECONFIGTIME 0x15A4 > +#define PA_TXHSADAPTTYPE 0x15D4 > + > +/* Adpat type for PA_TXHSADAPTTYPE attribute */ > +#define PA_REFRESH_ADAPT 0x00 > +#define PA_INITIAL_ADAPT 0x01 > +#define PA_NO_ADAPT 0x03 > > #define PA_TACTIVATE_TIME_UNIT_US 10 > #define PA_HIBERN8_TIME_UNIT_US 100 > @@ -192,6 +198,7 @@ enum ufs_hs_gear_tag { > UFS_HS_G1, /* HS Gear 1 (default for reset) */ > UFS_HS_G2, /* HS Gear 2 */ > UFS_HS_G3, /* HS Gear 3 */ > + UFS_HS_G4, /* HS Gear 4 */ > }; > > enum ufs_unipro_ver { > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project