All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: Remove unused xfs_evict_inode tracepoint
@ 2016-10-06 21:18 Andreas Gruenbacher
  2016-10-07 21:02 ` [PATCH 2/1] xfs: Remove more unused tracepoints Eric Sandeen
  2016-10-07 21:03 ` [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Eric Sandeen
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Gruenbacher @ 2016-10-06 21:18 UTC (permalink / raw)
  To: linux-xfs; +Cc: Andreas Gruenbacher

Commit 8179c036 removed the ->evict_inode super operation but left the
xfs_evict_inode tracepoint in place, with the effect that that
tracepoint is now unused.  Remove the tracepoint as well now.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/xfs/xfs_trace.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index d303a66..fdd9d53 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -677,7 +677,6 @@ DEFINE_INODE_EVENT(xfs_ioctl_setattr);
 DEFINE_INODE_EVENT(xfs_dir_fsync);
 DEFINE_INODE_EVENT(xfs_file_fsync);
 DEFINE_INODE_EVENT(xfs_destroy_inode);
-DEFINE_INODE_EVENT(xfs_evict_inode);
 DEFINE_INODE_EVENT(xfs_update_time);
 
 DEFINE_INODE_EVENT(xfs_dquot_dqalloc);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/1] xfs: Remove more unused tracepoints
  2016-10-06 21:18 [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Andreas Gruenbacher
@ 2016-10-07 21:02 ` Eric Sandeen
  2016-10-07 21:03 ` [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-10-07 21:02 UTC (permalink / raw)
  To: Andreas Gruenbacher, linux-xfs

There are several old, stale, unused tracepoints.  Remove them.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

trace_xfs_inode_item_push is also unused, but probably should be used?

diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index 2586c9c..a3e9e71 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -355,7 +355,6 @@ DEFINE_BUF_EVENT(xfs_buf_rele);
 DEFINE_BUF_EVENT(xfs_buf_iodone);
 DEFINE_BUF_EVENT(xfs_buf_submit);
 DEFINE_BUF_EVENT(xfs_buf_submit_wait);
-DEFINE_BUF_EVENT(xfs_buf_bawrite);
 DEFINE_BUF_EVENT(xfs_buf_lock);
 DEFINE_BUF_EVENT(xfs_buf_lock_done);
 DEFINE_BUF_EVENT(xfs_buf_trylock_fail);
@@ -367,17 +366,14 @@ DEFINE_BUF_EVENT(xfs_buf_delwri_queue);
 DEFINE_BUF_EVENT(xfs_buf_delwri_queued);
 DEFINE_BUF_EVENT(xfs_buf_delwri_split);
 DEFINE_BUF_EVENT(xfs_buf_get_uncached);
-DEFINE_BUF_EVENT(xfs_bdstrat_shut);
 DEFINE_BUF_EVENT(xfs_buf_item_relse);
 DEFINE_BUF_EVENT(xfs_buf_item_iodone_async);
 DEFINE_BUF_EVENT(xfs_buf_error_relse);
 DEFINE_BUF_EVENT(xfs_buf_wait_buftarg);
-DEFINE_BUF_EVENT(xfs_trans_read_buf_io);
 DEFINE_BUF_EVENT(xfs_trans_read_buf_shut);
 
 /* not really buffer traces, but the buf provides useful information */
 DEFINE_BUF_EVENT(xfs_btree_corrupt);
-DEFINE_BUF_EVENT(xfs_da_btree_corrupt);
 DEFINE_BUF_EVENT(xfs_reset_dqcounts);
 DEFINE_BUF_EVENT(xfs_inode_item_push);
 
@@ -541,7 +537,6 @@ DEFINE_BUF_ITEM_EVENT(xfs_trans_bjoin);
 DEFINE_BUF_ITEM_EVENT(xfs_trans_bhold);
 DEFINE_BUF_ITEM_EVENT(xfs_trans_bhold_release);
 DEFINE_BUF_ITEM_EVENT(xfs_trans_binval);
-DEFINE_BUF_ITEM_EVENT(xfs_trans_buf_ordered);
 
 DECLARE_EVENT_CLASS(xfs_filestream_class,
 	TP_PROTO(struct xfs_inode *ip, xfs_agnumber_t agno),
@@ -939,7 +934,6 @@ DEFINE_DQUOT_EVENT(xfs_dqget_miss);
 DEFINE_DQUOT_EVENT(xfs_dqget_freeing);
 DEFINE_DQUOT_EVENT(xfs_dqget_dup);
 DEFINE_DQUOT_EVENT(xfs_dqput);
-DEFINE_DQUOT_EVENT(xfs_dqput_wait);
 DEFINE_DQUOT_EVENT(xfs_dqput_free);
 DEFINE_DQUOT_EVENT(xfs_dqrele);
 DEFINE_DQUOT_EVENT(xfs_dqflush);
@@ -1816,7 +1810,6 @@ DEFINE_ATTR_EVENT(xfs_attr_sf_addname);
 DEFINE_ATTR_EVENT(xfs_attr_sf_create);
 DEFINE_ATTR_EVENT(xfs_attr_sf_lookup);
 DEFINE_ATTR_EVENT(xfs_attr_sf_remove);
-DEFINE_ATTR_EVENT(xfs_attr_sf_removename);
 DEFINE_ATTR_EVENT(xfs_attr_sf_to_leaf);
 
 DEFINE_ATTR_EVENT(xfs_attr_leaf_add);
@@ -1845,7 +1838,6 @@ DEFINE_ATTR_EVENT(xfs_attr_leaf_toosmall);
 
 DEFINE_ATTR_EVENT(xfs_attr_node_addname);
 DEFINE_ATTR_EVENT(xfs_attr_node_get);
-DEFINE_ATTR_EVENT(xfs_attr_node_lookup);
 DEFINE_ATTR_EVENT(xfs_attr_node_replace);
 DEFINE_ATTR_EVENT(xfs_attr_node_removename);
 
@@ -2441,11 +2433,9 @@ DEFINE_DEFER_EVENT(xfs_defer_finish_done);
 
 DEFINE_DEFER_ERROR_EVENT(xfs_defer_trans_roll_error);
 DEFINE_DEFER_ERROR_EVENT(xfs_defer_finish_error);
-DEFINE_DEFER_ERROR_EVENT(xfs_defer_op_finish_error);
 
 DEFINE_DEFER_PENDING_EVENT(xfs_defer_intake_work);
 DEFINE_DEFER_PENDING_EVENT(xfs_defer_intake_cancel);
-DEFINE_DEFER_PENDING_EVENT(xfs_defer_pending_commit);
 DEFINE_DEFER_PENDING_EVENT(xfs_defer_pending_cancel);
 DEFINE_DEFER_PENDING_EVENT(xfs_defer_pending_finish);
 DEFINE_DEFER_PENDING_EVENT(xfs_defer_pending_abort);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: Remove unused xfs_evict_inode tracepoint
  2016-10-06 21:18 [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Andreas Gruenbacher
  2016-10-07 21:02 ` [PATCH 2/1] xfs: Remove more unused tracepoints Eric Sandeen
@ 2016-10-07 21:03 ` Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-10-07 21:03 UTC (permalink / raw)
  To: Andreas Gruenbacher, linux-xfs

On 10/6/16 4:18 PM, Andreas Gruenbacher wrote:
> Commit 8179c036 removed the ->evict_inode super operation but left the
> xfs_evict_inode tracepoint in place, with the effect that that
> tracepoint is now unused.  Remove the tracepoint as well now.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

I can review this one ;)

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/xfs/xfs_trace.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index d303a66..fdd9d53 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -677,7 +677,6 @@ DEFINE_INODE_EVENT(xfs_ioctl_setattr);
>  DEFINE_INODE_EVENT(xfs_dir_fsync);
>  DEFINE_INODE_EVENT(xfs_file_fsync);
>  DEFINE_INODE_EVENT(xfs_destroy_inode);
> -DEFINE_INODE_EVENT(xfs_evict_inode);
>  DEFINE_INODE_EVENT(xfs_update_time);
>  
>  DEFINE_INODE_EVENT(xfs_dquot_dqalloc);
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-07 21:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-06 21:18 [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Andreas Gruenbacher
2016-10-07 21:02 ` [PATCH 2/1] xfs: Remove more unused tracepoints Eric Sandeen
2016-10-07 21:03 ` [PATCH] xfs: Remove unused xfs_evict_inode tracepoint Eric Sandeen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.