From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB757C433F5 for ; Thu, 17 Mar 2022 08:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbiCQIbL (ORCPT ); Thu, 17 Mar 2022 04:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbiCQIbJ (ORCPT ); Thu, 17 Mar 2022 04:31:09 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B2AB18F225; Thu, 17 Mar 2022 01:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647505793; x=1679041793; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=YWwbBtyM55w2NVBtFgTtLmpvZGh5He1rqDimrPbgRxM=; b=O8/bivU0g3u5M9l4cZGsZSSlZW7CIlt72MmGU7xq4/IJAEkne59HBSFW aTe57A+kvR/IxypEaZYnFnMLUwm0tOF7GwvHD4WVDLAempY0pECbLF3PU 75kfEZ7QKy6wsaCUyA4OFrFE/4JzvDkShMlAPfAJ/TQCSTohv+i9uAl0q QDubxHecmcnqzmdTZzJ29L+DRalh0BFfuRkM6yhaUxDiorod9tSO2z2zT Qs+XUlp1UOF4P2S1mU5wtWmnvfCqAEiUbFTrHXJmRskxZBjEUJYLlKFbM JUpJZjvHuU7ISUmXAB9wdaWJu/ITzhV9U9cjULXgYXNJwnpiXsKoGlp6V Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10288"; a="281604689" X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="281604689" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 01:29:53 -0700 X-IronPort-AV: E=Sophos;i="5.90,188,1643702400"; d="scan'208";a="557835326" Received: from msivosuo-mobl1.ger.corp.intel.com ([10.252.54.208]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 01:29:46 -0700 Date: Thu, 17 Mar 2022 10:29:40 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Wander Lairson Costa cc: Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , "Maciej W. Rozycki" , Serge Semin , Lukas Wunner , =?ISO-8859-15?Q?Pali_Roh=E1r?= , "open list:SERIAL DRIVERS" , open list , rostedt@goodmis.org, senozhatsky@chromium.org, andre.goddard@gmail.com, sudipm.mukherjee@gmail.com, andy.shevchenko@gmail.com, David.Laight@aculab.com, jonathanh@nvidia.com, phil@raspberrypi.com Subject: Re: [PATCH v4 2/5] serial/8250: Use the cache value of the FCR register In-Reply-To: <20220316143646.13301-3-wander@redhat.com> Message-ID: References: <20220316143646.13301-1-wander@redhat.com> <20220316143646.13301-3-wander@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Mar 2022, Wander Lairson Costa wrote: > commit 5021d709b31b ("tty: serial: Use fifo in 8250 console driver") > erroneous tries to read the FCR register content, but this register is > write-only. > > This patch fixes that by reading the content from the port struct fcr > field. > > Thanks to Jon Hunter and Jiri Slaby. > > Suggested-by: Jiri Slaby > Reported-by: Jon Hunter > Signed-off-by: Wander Lairson Costa > --- > drivers/tty/serial/8250/8250_port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index 2abb3de11a48..9f3fa9fe2a4e 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -3410,7 +3410,7 @@ void serial8250_console_write(struct uart_8250_port *up, const char *s, > > use_fifo = (up->capabilities & UART_CAP_FIFO) && > port->fifosize > 1 && > - (serial_port_in(port, UART_FCR) & UART_FCR_ENABLE_FIFO) && > + (up->fcr & UART_FCR_ENABLE_FIFO) && Didn't you just add this line in 1/5? Please merge this kind of fixes that are due to development history of a change to the main patch itself. -- i.