All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org
Subject: [PATCH v2 5/6] ipipe: Activate IRQ in ipipe_enable_irq
Date: Thu, 11 Jul 2019 21:56:16 +0200	[thread overview]
Message-ID: <ceb083b98c32b9829f230eb7194a988ef4a7577d.1562874977.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1562874977.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1562874977.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Likely needed since c942cee46bba which split enabling and startup.

This fixes unpopulated vectors in the IOAPIC on x86 at least, possibly
more.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 kernel/irq/chip.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 65d345b727be..22386e509f68 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1087,6 +1087,7 @@ int ipipe_enable_irq(unsigned int irq)
 	struct irq_desc *desc;
 	struct irq_chip *chip;
 	unsigned long flags;
+	int err;
 
 	desc = irq_to_desc(irq);
 	if (desc == NULL)
@@ -1098,6 +1099,10 @@ int ipipe_enable_irq(unsigned int irq)
 
 		ipipe_root_only();
 
+		err = irq_activate(desc);
+		if (err)
+			return err;
+
 		raw_spin_lock_irqsave(&desc->lock, flags);
 		if (desc->istate & IPIPE_IRQS_NEEDS_STARTUP) {
 			desc->istate &= ~IPIPE_IRQS_NEEDS_STARTUP;
-- 
2.16.4



  parent reply	other threads:[~2019-07-11 19:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 19:56 [PATCH v2 0/6] ipipe-noarch: IRQ tracing, enabling, and lockdep fixes/cleanups Jan Kiszka
2019-07-11 19:56 ` [PATCH v2 1/6] ipipe: Restore trace_hardirqs_on_virt_caller Jan Kiszka
2019-07-11 19:56 ` [PATCH v2 2/6] ipipe: lockdep: Remove duplicate context checks Jan Kiszka
2019-07-11 19:56 ` [PATCH v2 3/6] ipipe: Add missing include for ipipe_root_only Jan Kiszka
2019-07-11 19:56 ` [PATCH v2 4/6] ipipe: Let ipipe_enable_irq return an error code Jan Kiszka
2019-07-11 19:56 ` Jan Kiszka [this message]
2019-07-11 19:56 ` [PATCH v2 6/6] ipipe: Let ipipe_set_irq_affinity return an error Jan Kiszka
2019-07-23 16:39 ` [PATCH v2 0/6] ipipe-noarch: IRQ tracing, enabling, and lockdep fixes/cleanups Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ceb083b98c32b9829f230eb7194a988ef4a7577d.1562874977.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.