From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4369C433F5 for ; Thu, 10 Mar 2022 21:01:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 334B683AFF; Thu, 10 Mar 2022 22:01:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="MSnNvu1r"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A10783AE0; Thu, 10 Mar 2022 22:01:38 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C76E883ADB for ; Thu, 10 Mar 2022 22:01:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JVv+sGNpmtC9Jq+2pDb132x6V6gFI6K4p5I8u+vfGnEgD0q7BKkqvK+Vzazaq2dyOgCTBxBM8f0ir0rlJPbuPWgMansL+vqNTYFbr5DLaeBrEc1066gLu/z31RKEdpCQsDT/GrYoq6gxXRV/6UdgLXJOPoqW0jyziAPIsGhxP1TOHO7PRbt2yJALw1Xmk0wZV1MCk6K6T6X17MXDkvPh1BjslXURyAj+BoGOsNvyQWhxI+PFi0XX2u5x+GiE5hukFw/lIfkM7J8Sc/Qy1yiShJtsYxBq97489zgcOytL1wiz4LVMh5hTwdL/qJa/+wlBl5dcQl2PWV4KdmDpoiVZ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2QzZkfqnx//ihYTZeZsJ7O9pGXah/8Zvl7TtQTXQNzg=; b=Lfe6jqL42t2OrtujA4l6/x8FtSXwqy2ZIKucxmDyUwBjM1aca8RsK+dw4kP7Y6h4S5PdmM07oqqM3QZcrLCWiaQt1OE5RjtYhIzYIM9x8aUB/Lsm0mRqmPzseqW0Mtbz5vhIoz9MgYwzqtftQsS8W3Bxy18xNOmprnt8oSptfOmyZG57yz21l84ya73CAb0RWNVmWbDea2tCpe4LGzGlky471rxrW1WoOMtHSQCzZimRaORv+c1wxwNhbqjdx7s8ZDx4OdUVXz5FrACPRXJeXMj4s6b4k/kIAuyqoWuy9zSuD6oSNd3+MsiOU+M1PvdPdMEFFDDNFcFrGV5ugyYM/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QzZkfqnx//ihYTZeZsJ7O9pGXah/8Zvl7TtQTXQNzg=; b=MSnNvu1rig9QbcB2aWzupM6m6sg7WkuWN/HdByTRn+h3VP7PXVLgJ8jUd5KO/viJ0fopPhiflmRq5f2wxIjbOxrnEibrrYzra0/f3Pn+wEmNo1tc2yP2VXEqIiIFlL35mHqtBOGlE+MWDrD01mOauuMjkY7scl3S6qacAjoOrKf/yjpS2HtsI305FHrUhmP4iZ7RJjq8KfVyE7VyBwkBxC6d1t95DLy2SAESwmazcZRCRbNDtrMhcpxQMWFBqzP+b22gF4NP2Hr58iG9NOKZd/oxAhq3+VBjqEIntlOanhwBOuzclxVSqhckui9zCh4ICgyZftgE1rtOVNpRca6Luw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by PAXPR03MB7546.eurprd03.prod.outlook.com (2603:10a6:102:1d9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Thu, 10 Mar 2022 21:01:33 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9860:b15b:f166:5896]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9860:b15b:f166:5896%3]) with mapi id 15.20.5061.022; Thu, 10 Mar 2022 21:01:33 +0000 Subject: Re: [PATCH v2 20/28] arm64: Save spsr in pt_regs To: Tom Rini Cc: Liviu Dudau , u-boot@lists.denx.de, Simon Glass , Linus Walleij , Andre Przywara References: <20220310205059.499269-1-sean.anderson@seco.com> <20220310205059.499269-21-sean.anderson@seco.com> From: Sean Anderson Message-ID: Date: Thu, 10 Mar 2022 16:01:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20220310205059.499269-21-sean.anderson@seco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0427.namprd13.prod.outlook.com (2603:10b6:208:2c3::12) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40e8fbc7-75e0-4858-bb27-08da02d927fd X-MS-TrafficTypeDiagnostic: PAXPR03MB7546:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TfX64UZ+tk8A+JcQd/FJx97n7bLG3y1Sf/d9YcvZ1COJldDUMDHSy39oajzSwo41Gg3pxgoiOJ2O3KYs7Cr4I7+7ZcNbSQ4mFE27JBN++W9zZFZPh5mz0UZgDCUzgfDB1fUlN99+yeEd3za/PXbTGMDb3yR+7dHoTNs2v/GlGgyIwt7xENlQo0EKcvsQAy4F6i9rijaTJ+X9dU648wHxIo5iU8hTWr8VsXsGobb1cGMSaIH49uRrwzNWzkWGZp52tS0CupjwAUk+NJBygd5gH9wjUKR+zsT9MBvzmoR0myWZAntDE95Jrw2zGU2mZVZ1rK9aN0RZmWB1HkKooq8TcT+Jn62x1sdAWU8ii/65Dkgq1khr7rN43BRwrskVLyLEySZbdEIMNcW+hYdtmZaOAtK6K5iH46GswrNP5hn3tR0kHsn/emafk96gEqjdPLLoswJqKM/XrBiK1rrDgPh8zzBB17KS0K3hHlkR5SHHMQUkiVPdv3O50eNYCrONEoWtCAO+s9Dd7RWG+7vt4nO69JxfNhtp+jzvNyrwq+XeVVzYSYqyrDYz4FJcubTGAM5ylKaxjPprFSFBOIjH436DaV0vvdlNGE4Ok8aw7QmiZwIwts/lnn1trR6HbzJfBgRTJd/Nrqd3ar3jry9FXEnAWfltH7kP2ACp1YWCafjzOSjMUvEa11S1Yzartw/yrg1z/oYJUivOdeS3/cU6GVcMVCtb0wSBXvoQvQGBYczRoxcrjVwIUmTbxbDXsAbBr9T+liBlqucS3zC5tRT0kpzWYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31686004)(2616005)(2906002)(36756003)(8936002)(83380400001)(44832011)(86362001)(186003)(38100700002)(26005)(5660300002)(38350700002)(4326008)(31696002)(6486002)(8676002)(66556008)(54906003)(66476007)(6916009)(66946007)(52116002)(53546011)(508600001)(6512007)(6666004)(6506007)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3h4SHd5cENCNXZvd3hibDZPVHhyNjFRSGIrNWFTbHl2bUZtS3B6anVnRURR?= =?utf-8?B?WGdjcjd2eEN1NmU0NkxMRzNSc3UyREdISVZpZGQxLy96OCtaSDF6eXh2clla?= =?utf-8?B?bVl4YVB3dGdaOURTejFMMnAvdzZKOHgrTm52UTF6VzczOXU3ckQ5cDB0K2Vk?= =?utf-8?B?RE82VFFjYWZ4aUxoSHNwQ0RNVUtRTFdlbW1YYWVVaW5BQWpkeDhUWU53T2Rk?= =?utf-8?B?TitNdUN1dm5ubVZIelpZRnVpRHR5eTg0NjlQOHBLRXJOQlNPNkVGcXAzUW9D?= =?utf-8?B?ZGlhUHlHbnR3SlJBSUprdzNZTzlBYUtvMzFKSitab2liQlFvMjBWOUpEZGR3?= =?utf-8?B?T1l6Vzhqb0ZLd2hOSHJrTURJT09tOVhwQTBESTZRZldhYkF6eHZRMzQvcWdp?= =?utf-8?B?dTQvTFRHcVFFT1BwOXl1Wnd5R3RqQmltZm00UmRUTjA2eVBFVDJ0LzlBL21Z?= =?utf-8?B?Qk5RaUZYSnlvcEZEWDlXaCszWmNtc0cyNkdsVkNTeHl1SUxTMHlWNlBaSCtz?= =?utf-8?B?WWJxQ0RCbUVFOG0vcEk1ZWsxMzFRb2NUdzBjeHFSS3R3N0JnTVhocXFaQXhT?= =?utf-8?B?WTJrWm9DVnhzRE5pb3R6elF1MzZwYWVCbEFlb0hFYm4rWExUNnYzZnpwYlpn?= =?utf-8?B?OXRUZjdyWlVPamFFcmx3eW9US2tnOWtvWS9UK3QySnFLSDErU1FjVjJwaFYw?= =?utf-8?B?SWpsKzV5OXdCYnNVdDgzUDdncUlOWlYwRDVuWk9qYXEwQklHUVVRZU0zazJv?= =?utf-8?B?cktFWGNvbmlDT3VCeldHVHgvd1NVQXZJRzdUY05NVVMzWXIzWnRMbU1tMkxF?= =?utf-8?B?UTdPb1F5QjBXbUl2elRrdHg1TCtSajZiNnJsVE44cm5SWmpBdDZ2Q0owRjZj?= =?utf-8?B?Vkg3L29GUTZLZ0NSVk5QTFdEZjFiQU1lbVNRYitGUmlUM0lPMEhXdVJzWUJQ?= =?utf-8?B?N1lwTVlMR2RseXFEWlFPQ2Z3REZUUWlCMlYwN3NFeFFhVlVkd29memhHTzNQ?= =?utf-8?B?ZnJMYzhvWjVJVi9YWnA4U3l0NEVTTitQY0VyMlJ6eHprMjJsZ3lUajJxcHBJ?= =?utf-8?B?S0IyR3VlK0F1b3phTjhSYW9MN01TNUxidHN4bURsZVMrbm9RLzNFbTgrV0p1?= =?utf-8?B?QVdJK2lFNVRXa0xVWWNoSnZ2NEc2SUprQW5GLzIvSWFVSC9NaFphcFVoTGd0?= =?utf-8?B?bmhYQ2RzT3luc2lpVloraW9FQlk1ZHRkZGZWOFloUGE3NWFKQTJQdTNKcjBS?= =?utf-8?B?eENtOGJoVXl6bFJQd2g0b0hLYUFoY2pmSjdMQ0ZLNC9oMGNKSGVSeGtMOUwy?= =?utf-8?B?TnE1ZHZ6dEFyR05jUDBZajAvaFpMRW16cklIRmxERkxLaXdmZ2hSa1VvQ2Jl?= =?utf-8?B?a0lvandyMnNMWk5EQmFGMTRNUUFHZ3gzcDBkNGZ5VUhZaldQT0V6aEdzVVV2?= =?utf-8?B?ajFNZlN0V1hLODlmU2FlYXR5WlFvaHp2by9IajVFRVlubjJzM3JWZlp5SnpG?= =?utf-8?B?cnhIcUdacXZycGNhYzVJVjY0dGhlYkRyZ2grZkFuMmVoYnBvRDBNZkV4QTlD?= =?utf-8?B?c1lSMG54YjZOWjBIbXdxRTQ0eWl5aTI0MVFzNEszSnBxTXluT3dOTnpXWjJ4?= =?utf-8?B?TlBvUFBjWFE5NGxXcm5QWFltYzNrdGdQRm5xZlVQU2p4RFBDWHBPYWw3ZEtu?= =?utf-8?B?UW93SGRJZHdWcHVwUzhLNVVsclUxRmJOV21WOUhla3FhU2x4am5icjJ3ZGkr?= =?utf-8?B?eTIrcW0xZlNXNUpYRGQwWmVFOWM3WmVtK2h5dXY3ZS9BTEpqbWJGdmZ5OXV3?= =?utf-8?B?K0NqOVowVGQwM0wxYkdnNDZBUjVaRDhBQjI5NnNJYTFPMkhlKzUzQTc1Rjc0?= =?utf-8?B?SlQ0a3ZLaUMyWTljOHJGWHF4dWZGQ3ZUWTNtY3ROVUQwWXR3cTFRalBxVmIx?= =?utf-8?B?YVBOaUpsVXJDamw1WXMwT1FwZ2pQTk9oOGFwd3RmUDVaMzY3NGRzbWIyeHFk?= =?utf-8?B?NjlVSDZLbTBrS0ZlaFNSQmQ0cXN6Z2xXZi8xcy8xamVxZXJiVm1ZeDRMSy9X?= =?utf-8?B?T1QyRzd1NDZZSTNvQzgxOVl2cDJqclBFcDJDWGZuQzN2YXJybXpmUXF2Q1k2?= =?utf-8?B?N2wzejk4SWZubjh6eDdyekI4UlFTSjNsSTdaWnY2SzNtZFd5UnQyako5L09E?= =?utf-8?Q?BbKk7x/WO9kTNrcX4LLciq4=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40e8fbc7-75e0-4858-bb27-08da02d927fd X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 21:01:33.0632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wQb0xlh3fFAf4qWHe+/JmI98cCKircPOHBcPmox2QydW52CbQBHBNXXaYmZ+29/QTVW1yUFw8Ro1ZqTpQDJWfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7546 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/10/22 3:50 PM, Sean Anderson wrote: > This register holds "pstate" which includes (among other things) the > instruction mode the CPU was in when the exception was taken. This is > necessary to correctly interpret instructions at elr. > > Signed-off-by: Sean Anderson > --- > > Changes in v2: > - New > > arch/arm/cpu/armv8/exceptions.S | 5 ++++- > arch/arm/include/asm/proc-armv/ptrace.h | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv8/exceptions.S b/arch/arm/cpu/armv8/exceptions.S > index 001913f429..270d9df518 100644 > --- a/arch/arm/cpu/armv8/exceptions.S > +++ b/arch/arm/cpu/armv8/exceptions.S > @@ -77,15 +77,18 @@ _save_el_regs: > switch_el x11, 3f, 2f, 1f > 3: mrs x1, esr_el3 > mrs x2, elr_el3 > + mrs x3, spsr_el3 > b 0f > 2: mrs x1, esr_el2 > mrs x2, elr_el2 > + mrs x3, spsr_el3 > b 0f > 1: mrs x1, esr_el1 > mrs x2, elr_el1 > + mrs x3, spsr_el3 s/el3/el1/ (and the same thing for el2) Will be fixed in v3 --Sean > 0: > stp x1, x0, [sp, #-16]! > - stp xzr, x2, [sp, #-16]! > + stp x3, x2, [sp, #-16]! > mov x0, sp > ret > > diff --git a/arch/arm/include/asm/proc-armv/ptrace.h b/arch/arm/include/asm/proc-armv/ptrace.h > index bebcaf6e33..3b8fe7aac0 100644 > --- a/arch/arm/include/asm/proc-armv/ptrace.h > +++ b/arch/arm/include/asm/proc-armv/ptrace.h > @@ -21,7 +21,7 @@ > * on the stack during an exception. > */ > struct pt_regs { > - unsigned long unused; > + unsigned long spsr; > unsigned long elr; > unsigned long esr; > unsigned long regs[31]; >