From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E82C4332F for ; Mon, 19 Dec 2022 10:55:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Dnc-0007w3-MW; Mon, 19 Dec 2022 05:55:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Dna-0007v0-Hd; Mon, 19 Dec 2022 05:55:10 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7DnY-0004n4-GD; Mon, 19 Dec 2022 05:55:10 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 060B5352DB; Mon, 19 Dec 2022 10:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1671447306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WX1qfxHuBtVN5ICiqZGgGEWWWmT1q9Xj/Pe2oZDVZ4=; b=XZfrtLkTQgrqjgZNFiHsTRZvFGQgxCQHJLJR7ISx6AwEf8qFkCZrhmHZKh4905nYbzoSTQ XfhyQM4pbgXJGBcx47aUJTnlWofgdenLEixo/y86EEhIcoGLZOhD7/OHLpCR/tt4ELq4IE s5/t+fjchShTgH4cBs2TNRc8BPqQaZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1671447306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WX1qfxHuBtVN5ICiqZGgGEWWWmT1q9Xj/Pe2oZDVZ4=; b=acmKAfQZ8s5hS50l425mWNOe5+vaiAyqKnarimao8CA6a7MWZxvOp4LZezP1aqVH/XNFkv igDdthbcLx838zCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB20A13498; Mon, 19 Dec 2022 10:55:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DOlWLAlDoGN5RgAAMHmgww (envelope-from ); Mon, 19 Dec 2022 10:55:05 +0000 Message-ID: Date: Mon, 19 Dec 2022 11:55:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 1/5] target/arm: only build psci for TCG Content-Language: en-US To: Alexander Graf , Fabiano Rosas , Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Eduardo Habkost References: <20221216212944.28229-2-farosas@suse.de> <459E39B4-44F5-41B2-A595-1B0DB5AD80F3@csgraf.de> <3355a215-dd7a-e80a-ca53-b0d65eb435b5@suse.de> <76c8912f-4fb7-118a-2105-efe08f343f77@csgraf.de> From: Claudio Fontana In-Reply-To: <76c8912f-4fb7-118a-2105-efe08f343f77@csgraf.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=cfontana@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Ciao Alex, On 12/19/22 11:47, Alexander Graf wrote: > Hey Claudio, > > On 19.12.22 09:37, Claudio Fontana wrote: >> >> On 12/16/22 22:59, Alexander Graf wrote: >>> Hi Claudio, >>> >>> If the PSCI implementation becomes TCG only, can we also move to a tcg accel directory? It slowly gets super confusing to keep track of which files are supposed to be generic target code and which ones TCG specific> >>> Alex >> Hi Alex, Fabiano, Peter and all, >> >> that was the plan but at the time of: >> >> https://lore.kernel.org/all/20210416162824.25131-1-cfontana@suse.de/ >> >> Peter mentioned that HVF AArch64 might use that code too: >> >> https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00509.html >> >> so from v2 to v3 the series changed to not move the code under tcg/ , expecting HVF to be reusing that code "soon". >> >> I see that your hvf code in hvf/ implements psci, is there some plan to reuse pieces from the tcg implementation now? > > I originally reused the PSCI code in earlier versions of my hvf patch > set, but then we realized that some functions like remote CPU reset are > wired in a TCG specific view of the world with full target CPU register > ownership. So if we want to actually share it, we'll need to abstract it > up a level. > > Hence I'd suggest to move it to a TCG directory for now and then later > move it back into a generic helper if we want / need to. The code just > simply isn't generic yet. > > Or alternatively, you create a patch (set) to actually merge the 2 > implementations into a generic one again which then can live at a > generic place :) > > > Alex Thanks for the clarification, I'll leave the choice up to Fabiano now, since he is working on the series currently :-) Ciao, Claudio