From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41BFC89EB1 for ; Fri, 5 Apr 2019 12:53:44 +0000 (UTC) References: <20190402191247.26247-1-maarten.lankhorst@linux.intel.com> <20190403095005.676-1-maarten.lankhorst@linux.intel.com> From: Juha-Pekka Heikkila Message-ID: Date: Fri, 5 Apr 2019 15:53:40 +0300 MIME-Version: 1.0 In-Reply-To: <20190403095005.676-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add cairo conversion to igt_fb_convert_with_stride, v2. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: VG9vayBhIHdoaWxlIHRvIHNlZSB3aGF0IGlzIGhhcHBlbmluZywgZ2l0IG1hZGUgdGhpcyBwYXRj aCBsb29rIHJlYWxseSAKd2VpcmQuIEFueXdheSwgbG9vayBvayB0byBtZS4KClJldmlld2VkLWJ5 OiBKdWhhLVBla2thIEhlaWtraWxhIDxqdWhhcGVra2EuaGVpa2tpbGFAZ21haWwuY29tPgoKT24g My40LjIwMTkgMTIuNTAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IGZiX2NvbnZlcnQoKSBj YW5ub3QgY29udmVydCB0byB0aGUgSERSIGZvcm1hdHMsIHNvIHdlIG5lZWQgYSBmYWxsYmFjay4K PiBXaGVuIGNhaXJvIGlzIGF2YWlsYWJsZSBvbiBzb3VyY2UgYW5kIHRhcmdldCBmb3JtYXQsIGNy ZWF0ZSBhIHN1cmZhY2UKPiBmb3Igc291cmNlIGFuZCB0YXJnZXQuIFRoaXMgd2F5IHdlIGNhbiBj b252ZXJ0IGZyYW1lYnVmZmVycyBkaXJlY3RseQo+IHdoZW4gbm8gZGlyZWN0IGNvbnZlcnNpb24g dXNpbmcgZmJfY29udmVydCgpIGlzIGF2YWlsYWJsZS4KPiAKPiBUaGlzIGlzIHJlcXVpcmVkIHRv IG1ha2UgdGhlIGttc19jaGFtZWxpdW0uKi1jbXAtcGxhbmVzLXJhbmRvbSB0ZXN0cwo+IHBhc3Mu Cj4gCj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAtIFJldHVybiBmYl9pZCBpbiB0aGUgY2Fpcm8gY2Fz ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgbGliL2lndF9mYi5jIHwgOTAgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDU2IGluc2VydGlvbnMoKyksIDM0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiBpbmRleCA2YWRmNDIyMjI4ZTguLmE3OWIz ZjgzMmM1MSAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMK PiBAQCAtMjk3Niw1MyArMjk3Niw3NSBAQCB1bnNpZ25lZCBpbnQgaWd0X2ZiX2NvbnZlcnRfd2l0 aF9zdHJpZGUoc3RydWN0IGlndF9mYiAqZHN0LCBzdHJ1Y3QgaWd0X2ZiICpzcmMsCj4gICAJdm9p ZCAqZHN0X3B0ciwgKnNyY19wdHI7Cj4gICAJdWludDY0X3QgYmFzZV9tb2RpZmllcjsKPiAgIAlp bnQgZmJfaWQ7Cj4gKwljb25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpzcmNfZm9ybWF0 ID0gbG9va3VwX2RybV9mb3JtYXQoc3JjLT5kcm1fZm9ybWF0KTsKPiArCWNvbnN0IHN0cnVjdCBm b3JtYXRfZGVzY19zdHJ1Y3QgKmRzdF9mb3JtYXQgPSBsb29rdXBfZHJtX2Zvcm1hdChkc3RfZm91 cmNjKTsKPiAgIAo+ICAgCWlmIChpc192YzRfZGV2aWNlKHNyYy0+ZmQpKQo+ICAgCQliYXNlX21v ZGlmaWVyID0gZm91cmNjX21vZF9icm9hZGNvbV9tb2QoZHN0X21vZGlmaWVyKTsKPiAgIAllbHNl Cj4gICAJCWJhc2VfbW9kaWZpZXIgPSBkc3RfbW9kaWZpZXI7Cj4gICAKPiAtCWZiX2lkID0gaWd0 X2NyZWF0ZV9mYl93aXRoX2JvX3NpemUoc3JjLT5mZCwgc3JjLT53aWR0aCwgc3JjLT5oZWlnaHQs Cj4gLQkJCQkJICAgZHN0X2ZvdXJjYywKPiAtCQkJCQkgICBMT0NBTF9EUk1fRk9STUFUX01PRF9O T05FLCAmbGluZWFyLAo+IC0JCQkJCSAgIDAsIGRzdF9zdHJpZGUpOwo+IC0JaWd0X2Fzc2VydChm Yl9pZCA+IDApOwo+ICsJaWYgKHNyY19mb3JtYXQtPmNhaXJvX2lkID09IENBSVJPX0ZPUk1BVF9J TlZBTElEIHx8Cj4gKwkgICAgZHN0X2Zvcm1hdC0+Y2Fpcm9faWQgPT0gQ0FJUk9fRk9STUFUX0lO VkFMSUQpIHsKPiArCQlmYl9pZCA9IGlndF9jcmVhdGVfZmJfd2l0aF9ib19zaXplKHNyYy0+ZmQs IHNyYy0+d2lkdGgsIHNyYy0+aGVpZ2h0LAo+ICsJCQkJCQlkc3RfZm91cmNjLAo+ICsJCQkJCQlM T0NBTF9EUk1fRk9STUFUX01PRF9OT05FLCAmbGluZWFyLAo+ICsJCQkJCQkwLCBkc3Rfc3RyaWRl KTsKPiArCQlpZ3RfYXNzZXJ0KGZiX2lkID4gMCk7Cj4gICAKPiAtCXNyY19wdHIgPSBpZ3RfZmJf bWFwX2J1ZmZlcihzcmMtPmZkLCBzcmMpOwo+IC0JaWd0X2Fzc2VydChzcmNfcHRyKTsKPiArCQlz cmNfcHRyID0gaWd0X2ZiX21hcF9idWZmZXIoc3JjLT5mZCwgc3JjKTsKPiArCQlpZ3RfYXNzZXJ0 KHNyY19wdHIpOwo+ICAgCj4gLQlkc3RfcHRyID0gaWd0X2ZiX21hcF9idWZmZXIobGluZWFyLmZk LCAmbGluZWFyKTsKPiAtCWlndF9hc3NlcnQoZHN0X3B0cik7Cj4gKwkJZHN0X3B0ciA9IGlndF9m Yl9tYXBfYnVmZmVyKGxpbmVhci5mZCwgJmxpbmVhcik7Cj4gKwkJaWd0X2Fzc2VydChkc3RfcHRy KTsKPiAgIAo+IC0JY3Z0LmRzdC5wdHIgPSBkc3RfcHRyOwo+IC0JY3Z0LmRzdC5mYiA9ICZsaW5l YXI7Cj4gLQljdnQuc3JjLnB0ciA9IHNyY19wdHI7Cj4gLQljdnQuc3JjLmZiID0gc3JjOwo+IC0J ZmJfY29udmVydCgmY3Z0KTsKPiArCQljdnQuZHN0LnB0ciA9IGRzdF9wdHI7Cj4gKwkJY3Z0LmRz dC5mYiA9ICZsaW5lYXI7Cj4gKwkJY3Z0LnNyYy5wdHIgPSBzcmNfcHRyOwo+ICsJCWN2dC5zcmMu ZmIgPSBzcmM7Cj4gKwkJZmJfY29udmVydCgmY3Z0KTsKPiAgIAo+IC0JaWd0X2ZiX3VubWFwX2J1 ZmZlcihkc3QsIGRzdF9wdHIpOwo+IC0JaWd0X2ZiX3VubWFwX2J1ZmZlcihzcmMsIHNyY19wdHIp Owo+ICsJCWlndF9mYl91bm1hcF9idWZmZXIoZHN0LCBkc3RfcHRyKTsKPiArCQlpZ3RfZmJfdW5t YXBfYnVmZmVyKHNyYywgc3JjX3B0cik7Cj4gICAKPiAtCXN3aXRjaCAoYmFzZV9tb2RpZmllcikg ewo+IC0JY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENPTV9WQzRfVF9USUxFRDoKPiAtCQlmYl9p ZCA9IGlndF92YzRfZmJfdF90aWxlZF9jb252ZXJ0KGRzdCwgJmxpbmVhcik7Cj4gLQkJYnJlYWs7 Cj4gLQljYXNlIERSTV9GT1JNQVRfTU9EX0JST0FEQ09NX1NBTkQzMjoKPiAtCWNhc2UgRFJNX0ZP Uk1BVF9NT0RfQlJPQURDT01fU0FORDY0Ogo+IC0JY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENP TV9TQU5EMTI4Ogo+IC0JY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENPTV9TQU5EMjU2Ogo+IC0J CWZiX2lkID0gdmM0X2ZiX3NhbmRfdGlsZWRfY29udmVydChkc3QsICZsaW5lYXIsIGRzdF9tb2Rp Zmllcik7Cj4gLQkJYnJlYWs7Cj4gLQlkZWZhdWx0Ogo+IC0JCWlndF9hc3NlcnQoZHN0X21vZGlm aWVyID09IExPQ0FMX0RSTV9GT1JNQVRfTU9EX05PTkUpOwo+IC0JfQo+ICsJCXN3aXRjaCAoYmFz ZV9tb2RpZmllcikgewo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9NT0RfQlJPQURDT01fVkM0X1RfVElM RUQ6Cj4gKwkJCWZiX2lkID0gaWd0X3ZjNF9mYl90X3RpbGVkX2NvbnZlcnQoZHN0LCAmbGluZWFy KTsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENPTV9TQU5EMzI6 Cj4gKwkJY2FzZSBEUk1fRk9STUFUX01PRF9CUk9BRENPTV9TQU5ENjQ6Cj4gKwkJY2FzZSBEUk1f Rk9STUFUX01PRF9CUk9BRENPTV9TQU5EMTI4Ogo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9NT0RfQlJP QURDT01fU0FORDI1NjoKPiArCQkJZmJfaWQgPSB2YzRfZmJfc2FuZF90aWxlZF9jb252ZXJ0KGRz dCwgJmxpbmVhciwgZHN0X21vZGlmaWVyKTsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoKPiAr CQkJaWd0X2Fzc2VydChkc3RfbW9kaWZpZXIgPT0gTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSk7 Cj4gKwkJfQo+ICAgCj4gLQlpZ3RfYXNzZXJ0KGZiX2lkID4gMCk7Cj4gKwkJaWd0X2Fzc2VydChm Yl9pZCA+IDApOwo+ICAgCj4gLQlpZiAoZHN0X21vZGlmaWVyID09IExPQ0FMX0RSTV9GT1JNQVRf TU9EX05PTkUpCj4gLQkJKmRzdCA9IGxpbmVhcjsKPiAtCWVsc2UKPiAtCQlpZ3RfcmVtb3ZlX2Zi KGxpbmVhci5mZCwgJmxpbmVhcik7Cj4gKwkJaWYgKGRzdF9tb2RpZmllciA9PSBMT0NBTF9EUk1f Rk9STUFUX01PRF9OT05FKQo+ICsJCQkqZHN0ID0gbGluZWFyOwo+ICsJCWVsc2UKPiArCQkJaWd0 X3JlbW92ZV9mYihsaW5lYXIuZmQsICZsaW5lYXIpOwo+ICsJfSBlbHNlIHsKPiArCQkvKiBVc2Ug dGhlIGNhaXJvIGFwaSB0byBjb252ZXJ0ICovCj4gKwkJY2Fpcm9fc3VyZmFjZV90ICpzdXJmID0g aWd0X2dldF9jYWlyb19zdXJmYWNlKHNyYy0+ZmQsIHNyYyk7Cj4gKwkJY2Fpcm9fdCAqY3I7Cj4g Kwo+ICsJCWZiX2lkID0gaWd0X2NyZWF0ZV9mYl93aXRoX2JvX3NpemUoc3JjLT5mZCwgc3JjLT53 aWR0aCwKPiArCQkJCQkJICAgc3JjLT5oZWlnaHQsIGRzdF9mb3VyY2MsCj4gKwkJCQkJCSAgIGRz dF9tb2RpZmllciwgZHN0LCAwLAo+ICsJCQkJCQkgICBkc3Rfc3RyaWRlKTsKPiArCQlpZ3RfYXNz ZXJ0KGZiX2lkID4gMCk7Cj4gKwo+ICsJCWNyID0gaWd0X2dldF9jYWlyb19jdHgoZHN0LT5mZCwg ZHN0KTsKPiArCQljYWlyb19zZXRfc291cmNlX3N1cmZhY2UoY3IsIHN1cmYsIDAsIDApOwo+ICsJ CWNhaXJvX3BhaW50KGNyKTsKPiArCQlpZ3RfcHV0X2NhaXJvX2N0eChkc3QtPmZkLCBkc3QsIGNy KTsKPiArCj4gKwkJY2Fpcm9fc3VyZmFjZV9kZXN0cm95KHN1cmYpOwo+ICsJfQo+ICAgCj4gICAJ cmV0dXJuIGZiX2lkOwo+ICAgfQo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2