From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CAB7C433DB for ; Sat, 13 Feb 2021 16:21:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCAF464E2A for ; Sat, 13 Feb 2021 16:21:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCAF464E2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAxfR-0004xX-03 for qemu-devel@archiver.kernel.org; Sat, 13 Feb 2021 11:21:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAxdB-0003Wk-4a for qemu-devel@nongnu.org; Sat, 13 Feb 2021 11:18:49 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:43539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAxd8-0003Sf-VD for qemu-devel@nongnu.org; Sat, 13 Feb 2021 11:18:48 -0500 Received: from [192.168.100.1] ([82.252.149.54]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MxDgs-1m87kZ29yy-00xcqD; Sat, 13 Feb 2021 17:18:35 +0100 Subject: Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha To: Helge Deller , qemu-devel@nongnu.org References: <20210201155922.GA18291@ls3530.fritz.box> From: Laurent Vivier Message-ID: Date: Sat, 13 Feb 2021 17:18:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210201155922.GA18291@ls3530.fritz.box> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:i28CfIH1daU89Vpjj7oNVw1u60PdlNkBWzJmKynCyYJFMvOhDYx BgWCqRJmc/ZRjOrjQWH++UD/07pDF7EZwzjRvFJWRGd4dEvvjmEKrVQ2qMTk4erEe6Qti3u ozkDUuOHAi5Rg6cmvoBwCtsFUwslwCijY4DSLn8Nzev2xrmVO57jdheGQvurl06yWD/wr5t 4FKsThuJx6PEd+9RELJgg== X-UI-Out-Filterresults: notjunk:1;V03:K0:AEKLL7CnLJ8=:jodm4d7+Aruo8SO7TnD6CM vs20SKdo3IbK8GehkUScJF+aggvCDBaGihgbQToJw0rp+sJd+LZ5JbcA8lZWfdPiufv21HFFA jydYudjk1S+Rd2FyfKsHiW9uO//d1NiY44THTYcKAQSgrorlYvMZUCPiIwT3DkTtubY460tAP +zI/GfYslGt82AQw+WoIHjprIINpOU9Jb2RWA9l2nQUSdMC/MkjKoupu1XDtp3LuxW97VPVr2 CZYpF+hzzwOHKYwh5b9WpCqZcz/ng+yEsXo0sXBrYN+mB6uSOpLxufW9yqj6cWqKpwL3+Tarr JZK2EgHjfmCHl2ARz9czqYL4cjxQG0BCG5S+Pqus+oTrYAo+zA+6BTm+LhjQpnGqFLDNaJLgj RewXsJe7MKPIISSjVb3C4Jau6LChHbHp/RTgEzMXOS6Vv8g4pj+MhTXrt3+nPznuClPHu0YTz hYpyXIvp2Q== Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 01/02/2021 à 16:59, Helge Deller a écrit : > The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE > and as such fail to run a trivial symlink command like > > ln -s /bin/bash /tmp > > which results in an -EINVAL return code. > > Adding the define fixes the problem. > > Signed-off-by: Helge Deller > > --- > > diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h > index 2617e73472..0a74807a8b 100644 > --- a/linux-user/alpha/target_fcntl.h > +++ b/linux-user/alpha/target_fcntl.h > @@ -23,6 +23,7 @@ > #define TARGET_O_CLOEXEC 010000000 > #define TARGET___O_SYNC 020000000 > #define TARGET_O_PATH 040000000 > +#define TARGET___O_TMPFILE 0100000000 > > #define TARGET_F_GETLK 7 > #define TARGET_F_SETLK 8 > diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h > index bd966a59b8..08e3a4fcb0 100644 > --- a/linux-user/hppa/target_fcntl.h > +++ b/linux-user/hppa/target_fcntl.h > @@ -21,6 +21,7 @@ > #define TARGET_O_CLOEXEC 010000000 > #define TARGET___O_SYNC 000100000 > #define TARGET_O_PATH 020000000 > +#define TARGET___O_TMPFILE 040000000 > > #define TARGET_F_RDLCK 1 > #define TARGET_F_WRLCK 2 > Applied to my linux-user-for-6.0 branch. Thanks, Laurent