All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Willian Rampazzo" <willianr@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
Date: Wed, 15 Sep 2021 06:25:43 -0700	[thread overview]
Message-ID: <ceec60eb-9f46-59dc-7cb6-4428e8f8c4b4@linaro.org> (raw)
In-Reply-To: <20210915125452.1704899-3-berrange@redhat.com>

On 9/15/21 5:54 AM, Daniel P. Berrangé wrote:
> A typo meant the substitution would not work, and the placeholder in the
> target file didn't even exist.
> 
> The result was that tests were never run on the FreeBSD and macOS jobs,
> only a basic build.
> 
> Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
> ---
>   .gitlab-ci.d/cirrus.yml       | 2 +-
>   .gitlab-ci.d/cirrus/build.yml | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-09-15 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 13:25   ` Richard Henderson
2021-09-15 14:11   ` Thomas Huth
2021-09-15 14:59   ` Philippe Mathieu-Daudé
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-15 13:25   ` Richard Henderson [this message]
2021-09-15 14:10   ` Thomas Huth
2021-09-15 14:35   ` Willian Rampazzo
2021-09-17 11:23 ` [PATCH 0/2] gitlab: some minor CI tweaks Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ceec60eb-9f46-59dc-7cb6-4428e8f8c4b4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.