All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v2] Input: goodix - Fix compilation when ACPI support is disabled
Date: Wed, 01 Apr 2020 11:48:56 +0200	[thread overview]
Message-ID: <cef52c56239ee32136d3fa56dcb5ecab6ca0e2a2.camel@hadess.net> (raw)
In-Reply-To: <939fa592-599c-35cf-908e-d0b29639c992@redhat.com>

On Wed, 2020-04-01 at 11:14 +0200, Hans de Goede wrote:
> Hi,
> 
> On 4/1/20 3:45 AM, Dmitry Torokhov wrote:
> > Hi Hans,
> > 
> > On Wed, Mar 25, 2020 at 04:02:46PM +0100, Hans de Goede wrote:
> > > acpi_evaluate_object() and acpi_execute_simple_method() are not
> > > part of
> > > the group of ACPI related functions which get stubbed by
> > > include/linux/acpi.h when ACPI support is disabled, so the
> > > IRQ_PIN_ACCESS_ACPI_METHOD handling code must be disabled through
> > > an #ifdef when ACPI support is not enabled.
> > > 
> > > For consistency also #ifdef out the IRQ_PIN_ACCESS_ACPI_GPIO code
> > > and use the same #if condition as which is used to replace
> > > goodix_add_acpi_gpio_mappings with a stub.
> > 
> > I am not big fun of multiple #ifdefs sprinkled through the code,
> > can we
> > do more straightforward stubs, like below?
> 
> The solution you suggested is fine with me.

The patch itself is slightly confusing (it looks like it's renaming
functions), but looks pretty much like I requested, so:

Reviewed-by: Bastien Nocera <hadess@hadess.net>


      reply	other threads:[~2020-04-01  9:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 15:02 [PATCH v2] Input: goodix - Fix compilation when ACPI support is disabled Hans de Goede
2020-04-01  1:45 ` Dmitry Torokhov
2020-04-01  9:14   ` Hans de Goede
2020-04-01  9:48     ` Bastien Nocera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cef52c56239ee32136d3fa56dcb5ecab6ca0e2a2.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.