All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] efi_loader: Select EVENT as well
Date: Thu, 28 Apr 2022 12:03:43 +0200	[thread overview]
Message-ID: <cf0e2cd9-87a6-9c2f-4351-9b9e1adb1140@siemens.com> (raw)
In-Reply-To: <20220427055531.GC34649@laputa>

On 27.04.22 07:55, AKASHI Takahiro wrote:
> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Fixes
>>
>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>>   Depends on [n]: EVENT [=n]
>>   Selected by [y]:
>>   - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>
>> and the succeeding build breakage.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  lib/efi_loader/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index 6b245f50a72..1bfb9ddbda9 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -15,6 +15,7 @@ config EFI_LOADER
>>  	depends on !EFI_APP
>>  	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>  	select DM_EVENT
>> +	select EVENT
> 
> I wonder why DM_EVENT does not *select*, but implies EVENT.
> Should any subsystem relying on DM_EVENT work without EVENT?
>         -> Simon?
> 

Looks like you forgot to CC him.

Jan

> -Takahiro Akashi
> 
>>  	select EVENT_DYNAMIC
>>  	select LIB_UUID
>>  	imply PARTITION_UUIDS
>> -- 
>> 2.34.1

-- 
Siemens AG, Technology
Competence Center Embedded Linux

  reply	other threads:[~2022-04-28 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27  5:47 [PATCH] efi_loader: Select EVENT as well Jan Kiszka
2022-04-27  5:55 ` AKASHI Takahiro
2022-04-28 10:03   ` Jan Kiszka [this message]
2022-04-28 11:04     ` Heinrich Schuchardt
2022-05-03  5:00       ` Jan Kiszka
2022-05-07 20:34 ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf0e2cd9-87a6-9c2f-4351-9b9e1adb1140@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=sjg@chromium.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.