[PATCH V2 0/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[PATCH V2 0/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[Chen Qi]

Changes in V2:
* Fix to use hasTargetPackage instead of non-existent hasPrefixedTargetPackage

The following changes since commit 13cc30cd7de4841990b600e83e1249c81a5171dd:

  local.conf.sample.extended: Drop obsolete rpc and libnsl (2018-05-15 11:07:50 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib ChenQi/buildgalculator-gettext
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/buildgalculator-gettext

Chen Qi (1):
  oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

 meta/lib/oeqa/sdk/cases/buildgalculator.py | 2 ++
 1 file changed, 2 insertions(+)

-- 
1.9.1

[PATCH 1/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[Chen Qi]

We need to skip this testcase when gettext is not available. Otherwise,
we will have the following error at configure.

  error: possibly undefined macro: AM_NLS

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/lib/oeqa/sdk/cases/buildgalculator.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/lib/oeqa/sdk/cases/buildgalculator.py b/meta/lib/oeqa/sdk/cases/buildgalculator.py
index 780afcc..5a5bf99 100644
--- a/meta/lib/oeqa/sdk/cases/buildgalculator.py
+++ b/meta/lib/oeqa/sdk/cases/buildgalculator.py
@@ -11,6 +11,8 @@ class GalculatorTest(OESDKTestCase):
         if not (self.tc.hasTargetPackage("gtk\+3") or\
                 self.tc.hasTargetPackage("libgtk-3.0")):
             raise unittest.SkipTest("GalculatorTest class: SDK don't support gtk+3")
+        if not (self.tc.hasTargetPackage("gettext")):
+            raise unittest.SkipTest("GalculatorTest class: SDK doesn't contain gettext")
 
     def test_galculator(self):
         dl_dir = self.td.get('DL_DIR', None)
-- 
1.9.1

Re: [PATCH 1/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[ChenQi]

On 05/17/2018 06:00 PM, Burton, Ross wrote:
> On 16 May 2018 at 06:07, Chen Qi <Qi.Chen@windriver.com> wrote:
>> +        if not (self.tc.hasPrefixedTargetPackage("gettext")):
>> +            raise unittest.SkipTest("GalculatorTest class: SDK doesn't contain gettext")
>    File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-mips/build/meta/lib/oeqa/sdk/cases/buildgalculator.py",
> line 14, in setUpClass
>      if not (self.tc.hasPrefixedTargetPackage("gettext")):
> AttributeError: 'OESDKTestContext' object has no attribute
> 'hasPrefixedTargetPackage'
>
> Ross
>
Sorry for such an obvious mistake.

I've sent out V2.

Best Regards,

Chen Qi

Re: [PATCH 1/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[Burton, Ross]

On 16 May 2018 at 06:07, Chen Qi <Qi.Chen@windriver.com> wrote:
> +        if not (self.tc.hasPrefixedTargetPackage("gettext")):
> +            raise unittest.SkipTest("GalculatorTest class: SDK doesn't contain gettext")

  File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-mips/build/meta/lib/oeqa/sdk/cases/buildgalculator.py",
line 14, in setUpClass
    if not (self.tc.hasPrefixedTargetPackage("gettext")):
AttributeError: 'OESDKTestContext' object has no attribute
'hasPrefixedTargetPackage'

Ross

[PATCH 1/1] oeqa/sdk/cases/buildgalculator.py: skip if gettext not available

[Chen Qi]

We need to skip this testcase when gettext is not available. Otherwise,
we will have the following error at configure.

  error: possibly undefined macro: AM_NLS

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/lib/oeqa/sdk/cases/buildgalculator.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/lib/oeqa/sdk/cases/buildgalculator.py b/meta/lib/oeqa/sdk/cases/buildgalculator.py
index 780afcc..524451e 100644
--- a/meta/lib/oeqa/sdk/cases/buildgalculator.py
+++ b/meta/lib/oeqa/sdk/cases/buildgalculator.py
@@ -11,6 +11,8 @@ class GalculatorTest(OESDKTestCase):
         if not (self.tc.hasTargetPackage("gtk\+3") or\
                 self.tc.hasTargetPackage("libgtk-3.0")):
             raise unittest.SkipTest("GalculatorTest class: SDK don't support gtk+3")
+        if not (self.tc.hasPrefixedTargetPackage("gettext")):
+            raise unittest.SkipTest("GalculatorTest class: SDK doesn't contain gettext")
 
     def test_galculator(self):
         dl_dir = self.td.get('DL_DIR', None)
-- 
1.9.1