From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbeBTPbC (ORCPT ); Tue, 20 Feb 2018 10:31:02 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33935 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbeBTPbA (ORCPT ); Tue, 20 Feb 2018 10:31:00 -0500 X-Google-Smtp-Source: AH8x224HI8hcpLClktOPgzp7SfPJt8o9sXg8McpyTNjPWrRMAkZPBSOQUP/SOBYXwI2hg63ZcGvfXw== Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node To: Jacopo Mondi , geert@linux-m68k.org, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Tue, 20 Feb 2018 18:30:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/20/2018 06:12 PM, Jacopo Mondi wrote: > Populate the ethernet@e6800000 device node to enable Ethernet interface > for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > > --- > v1 -> v2: > - Replace ALWAYS_ON power area identifier with numeric constant > --- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index 55f05f7..c249895 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -520,7 +520,48 @@ > }; > > avb: ethernet@e6800000 { > - /* placeholder */ > + compatible = "renesas,etheravb-r8a77965", > + "renesas,etheravb-rcar-gen3"; > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "ch0", "ch1", "ch2", "ch3", > + "ch4", "ch5", "ch6", "ch7", > + "ch8", "ch9", "ch10", "ch11", > + "ch12", "ch13", "ch14", "ch15", > + "ch16", "ch17", "ch18", "ch19", > + "ch20", "ch21", "ch22", "ch23", > + "ch24"; > + clocks = <&cpg CPG_MOD 812>; > + power-domains = <&sysc 32>; > + resets = <&cpg 812>; > + phy-mode = "rgmii-txid"; Why not just "rgmii"? TX delay is a board specific detail, no? > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > }; > > csi20: csi2@fea80000 { > MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Date: Tue, 20 Feb 2018 18:30:56 +0300 Message-ID: References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jacopo Mondi , geert@linux-m68k.org, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 02/20/2018 06:12 PM, Jacopo Mondi wrote: > Populate the ethernet@e6800000 device node to enable Ethernet interface > for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > > --- > v1 -> v2: > - Replace ALWAYS_ON power area identifier with numeric constant > --- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index 55f05f7..c249895 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -520,7 +520,48 @@ > }; > > avb: ethernet@e6800000 { > - /* placeholder */ > + compatible = "renesas,etheravb-r8a77965", > + "renesas,etheravb-rcar-gen3"; > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "ch0", "ch1", "ch2", "ch3", > + "ch4", "ch5", "ch6", "ch7", > + "ch8", "ch9", "ch10", "ch11", > + "ch12", "ch13", "ch14", "ch15", > + "ch16", "ch17", "ch18", "ch19", > + "ch20", "ch21", "ch22", "ch23", > + "ch24"; > + clocks = <&cpg CPG_MOD 812>; > + power-domains = <&sysc 32>; > + resets = <&cpg 812>; > + phy-mode = "rgmii-txid"; Why not just "rgmii"? TX delay is a board specific detail, no? > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > }; > > csi20: csi2@fea80000 { > MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 20 Feb 2018 18:30:56 +0300 Subject: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node In-Reply-To: <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/20/2018 06:12 PM, Jacopo Mondi wrote: > Populate the ethernet at e6800000 device node to enable Ethernet interface > for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > > --- > v1 -> v2: > - Replace ALWAYS_ON power area identifier with numeric constant > --- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index 55f05f7..c249895 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -520,7 +520,48 @@ > }; > > avb: ethernet at e6800000 { > - /* placeholder */ > + compatible = "renesas,etheravb-r8a77965", > + "renesas,etheravb-rcar-gen3"; > + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "ch0", "ch1", "ch2", "ch3", > + "ch4", "ch5", "ch6", "ch7", > + "ch8", "ch9", "ch10", "ch11", > + "ch12", "ch13", "ch14", "ch15", > + "ch16", "ch17", "ch18", "ch19", > + "ch20", "ch21", "ch22", "ch23", > + "ch24"; > + clocks = <&cpg CPG_MOD 812>; > + power-domains = <&sysc 32>; > + resets = <&cpg 812>; > + phy-mode = "rgmii-txid"; Why not just "rgmii"? TX delay is a board specific detail, no? > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > }; > > csi20: csi2 at fea80000 { > MBR, Sergei