All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: lixiaokeng@huawei.com, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH v3 22/29] multipath: fix leaks in check_path_valid()
Date: Thu, 17 Dec 2020 10:54:05 +0100	[thread overview]
Message-ID: <cf163264941c5b56e5bb28b3e0878e7aa7dd8989.camel@suse.com> (raw)
In-Reply-To: <20201217033427.GV3103@octiron.msp.redhat.com>

On Wed, 2020-12-16 at 21:34 -0600, Benjamin Marzinski wrote:
> On Wed, Dec 16, 2020 at 07:17:01PM +0100, mwilck@suse.com wrote:
> > 
> >  
> >  	pp = alloc_path();
> >  	if (!pp)
> > @@ -665,13 +666,17 @@ check_path_valid(const char *name, struct
> > config *conf, bool is_uevent)
> >  	if (store_path(pathvec, pp) != 0) {
> 
> This will double-free the path, once here and again in cleanup.

argh, thanks - especially dumb with comment below :-/

> >  		free_path(pp);
> >  		goto fail;
> > +	} else {
> > +		/* make sure path isn't freed twice */
> > +		wwid = pp->wwid;
> > +		pp = NULL;
> >  	}
> > 
> ...
> > +
> > +cleanup:
> > +	if (pp != NULL)
> 
> shouldn't this be free_path(pp)

Absolutely. I'll resend this one. As everything else is reviewed now,
I'll just resubmit this one.

Martin


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2020-12-17  9:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:16 [dm-devel] [PATCH v3 00/29] libmultipath: improve cleanup on exit mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 01/29] multipathd: uxlsnr: avoid deadlock " mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 02/29] multipathd: Fix liburcu memory leak mwilck
2020-12-17  1:19   ` Benjamin Marzinski
2020-12-16 18:16 ` [dm-devel] [PATCH v3 03/29] multipathd: move handling of io_err_stat_attr into libmultipath mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 04/29] multipathd: move vecs desctruction into cleanup function mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 05/29] multipathd: make some globals static mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 06/29] multipathd: move threads destruction into separate function mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 07/29] multipathd: move conf " mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 08/29] multipathd: move pid " mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 09/29] multipathd: close pidfile on exit mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 11/29] multipathd: child(): call cleanups in failure case, too mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 12/29] multipathd: unwatch_all_dmevents: check if waiter is initialized mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 13/29] multipathd: print error message if config can't be loaded mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 14/29] libmultipath: add libmp_dm_exit() mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 15/29] multipathd: fixup libdm deinitialization mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 16/29] libmultipath: log_thread_stop(): check if logarea is initialized mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 17/29] multipathd: add cleanup_child() exit handler mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 18/29] libmultipath: fix log_thread startup and teardown mwilck
2020-12-17  2:23   ` Benjamin Marzinski
2020-12-16 18:16 ` [dm-devel] [PATCH v3 19/29] multipathd: move cleanup_{prio, checkers, foreign} to libmultipath_exit mwilck
2020-12-16 18:16 ` [dm-devel] [PATCH v3 20/29] multipath: use atexit() for cleanup handlers mwilck
2020-12-17  2:40   ` Benjamin Marzinski
2020-12-16 18:17 ` [dm-devel] [PATCH v3 21/29] mpathpersist: " mwilck
2020-12-16 18:17 ` [dm-devel] [PATCH v3 22/29] multipath: fix leaks in check_path_valid() mwilck
2020-12-17  3:34   ` Benjamin Marzinski
2020-12-17  9:54     ` Martin Wilck [this message]
2020-12-16 18:17 ` [dm-devel] [PATCH v3 23/29] multipath-tools: mpath-tools.supp: file with valgrind suppressions mwilck
2020-12-16 18:17 ` [dm-devel] [PATCH v3 24/29] libmultipath: use libmp_verbosity to track verbosity mwilck
2020-12-17  3:39   ` Benjamin Marzinski
2020-12-16 18:17 ` [dm-devel] [PATCH v3 25/29] libmultipath: introduce symbolic values for logsink mwilck
2020-12-17  3:42   ` Benjamin Marzinski
2020-12-16 18:17 ` [dm-devel] [PATCH v3 26/29] libmultipath: simplify dlog() mwilck
2020-12-16 18:17 ` [dm-devel] [PATCH v3 27/29] multipathd: common code for "-k" and command args mwilck
2020-12-16 18:17 ` [dm-devel] [PATCH v3 28/29] multipathd: sanitize uxsock_listen() mwilck
2020-12-16 18:17 ` [dm-devel] [PATCH v3 29/29] libmultipath: fix race between log_safe and log_thread_stop() mwilck
2020-12-17  5:56   ` Benjamin Marzinski
2020-12-16 18:24 ` [dm-devel] [PATCH v3 00/29] libmultipath: improve cleanup on exit Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf163264941c5b56e5bb28b3e0878e7aa7dd8989.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=lixiaokeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.