From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces Date: Tue, 6 Nov 2018 10:17:41 +0100 Message-ID: References: <20181105214117.11734-1-marek.vasut+renesas@gmail.com> <20181105214117.11734-2-marek.vasut+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yoshihiro Shimoda , "devicetree@vger.kernel.org" Cc: TAKESHI KIHARA , Geert Uytterhoeven , Wolfram Sang , "linux-renesas-soc@vger.kernel.org" , Simon Horman , "linux-arm-kernel@lists.infradead.org" , Marek Vasut List-Id: devicetree@vger.kernel.org On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Simon Horman >> Cc: Wolfram Sang >> Cc: Yoshihiro Shimoda >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:35228 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729241AbeKFT5O (ORCPT ); Tue, 6 Nov 2018 14:57:14 -0500 Subject: Re: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces To: Yoshihiro Shimoda , "devicetree@vger.kernel.org" Cc: TAKESHI KIHARA , Marek Vasut , Geert Uytterhoeven , Simon Horman , Wolfram Sang , "linux-renesas-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20181105214117.11734-1-marek.vasut+renesas@gmail.com> <20181105214117.11734-2-marek.vasut+renesas@gmail.com> From: Marek Vasut Message-ID: Date: Tue, 6 Nov 2018 10:17:41 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Simon Horman >> Cc: Wolfram Sang >> Cc: Yoshihiro Shimoda >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Tue, 6 Nov 2018 10:17:41 +0100 Subject: [PATCH 2/2] arm64: dts: r8a77990: ebisu: Enable SDHI interfaces In-Reply-To: References: <20181105214117.11734-1-marek.vasut+renesas@gmail.com> <20181105214117.11734-2-marek.vasut+renesas@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/06/2018 06:29 AM, Yoshihiro Shimoda wrote: > Hello Marek-san, Hello Shimoda-san, >> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:41 AM >> >> From: Takeshi Kihara >> >> This patch enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board using >> the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Simon Horman >> Cc: Wolfram Sang >> Cc: Yoshihiro Shimoda >> Cc: linux-renesas-soc at vger.kernel.org >> Cc: linux-arm-kernel at lists.infradead.org >> --- > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda > > I have a few nit comments below. > >> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 136 ++++++++++++++++++ >> 1 file changed, 136 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> index 611f0265fcc5..bda1765dcdbd 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > >> + sdhi3_pins: sd3 { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; >> + >> + sdhi3_pins_uhs: sd3_uhs { >> + groups = "sdhi3_data8", "sdhi3_ctrl"; >> + function = "sdhi3"; >> + power-source = <1800>; >> + }; > > I assumed that we will add "sdhi3_ds" into these groups when we add support for HS400 mode. That's a good point, I think we can add it right away, so added in V2. -- Best regards, Marek Vasut