From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] add thread and state info to XEN_SYSCTL_cputopoinfo
Date: Mon, 3 Sep 2018 15:54:08 +0200 [thread overview]
Message-ID: <cf21f8ee-6496-194b-3318-f8023554ceea@suse.com> (raw)
In-Reply-To: <5B8D3BCF02000078001E4A3B@suse.com>
On 03/09/18 15:49, Jan Beulich wrote:
>>>> On 31.08.18 at 18:22, <jgross@suse.com> wrote:
>> @@ -434,15 +434,19 @@ struct xen_sysctl_lockprof_op {
>> };
>>
>> /* XEN_SYSCTL_cputopoinfo */
>> +#define XEN_TOPO_STATE_OFFLINE 0
>> +#define XEN_TOPO_STATE_ONLINE 1
>> #define XEN_INVALID_THREAD_ID (~0U)
>> #define XEN_INVALID_CORE_ID (~0U)
>> #define XEN_INVALID_SOCKET_ID (~0U)
>> #define XEN_INVALID_NODE_ID (~0U)
>>
>> struct xen_sysctl_cputopo {
>> + uint32_t thread;
>> uint32_t core;
>> uint32_t socket;
>> uint32_t node;
>> + uint32_t state;
>> };
>
> Let's not burn an entire 32-bit field for this - a single bit suffices.
> I'd suggest you call it flags, and use bit 0 for the online/offline
> indicator. You then also don't need an "unknown" state in the
> tools.
Okay.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-03 13:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 16:22 [PATCH 0/2] add thread id and online state to cpu topology info Juergen Gross
2018-08-31 16:22 ` [PATCH 1/2] add cpu_thread_id to struct cpuinfo_x86 Juergen Gross
2018-09-03 13:46 ` Jan Beulich
[not found] ` <5B8D3B2702000078001E4A27@suse.com>
2018-09-03 13:53 ` Juergen Gross
2018-09-03 14:47 ` Jan Beulich
2018-08-31 16:22 ` [PATCH 2/2] add thread and state info to XEN_SYSCTL_cputopoinfo Juergen Gross
2018-09-03 13:49 ` Jan Beulich
[not found] ` <5B8D3BCF02000078001E4A3B@suse.com>
2018-09-03 13:54 ` Juergen Gross [this message]
[not found] <20180831162215.23318=ef=bf=bd1=ef=bf=bdjgross@suse.co?= =?UTF-8?Q?m>
[not found] ` <20180831162215.23318=ef=bf=bd2=ef=bf=bdjgross@suse.com>
[not found] ` <5B8D?= =?UTF-8?Q?3B2702000078001E4A27@suse.com>
[not found] ` <412351d9-d3c6-81c6-e754-83180345a?= =?UTF-8?Q?ea7@suse.com>
[not found] ` <5B8D499202000078001E4AE3@suse.com>
2018-09-03 14:52 ` [PATCH 1/2] add cpu_thread_id to struct cpuinfo_x86 Juergen Gross
[not found] ` <5B8D4E2202000078001E4B4D@suse.com>
2018-09-03 15:07 ` Jan Beulich
[not found] ` <?= =?UTF-8?Q?5B8D4E2202000078001E4B4D@suse.com>
2018-09-03 15:11 ` Juergen Gross
2018-09-03 15:14 ` Jan Beulich
[not found] ` <a43cb3dc-e3a2-?= =?UTF-8?Q?8ac5-a429-2b9be4fd324f@suse.com>
2018-09-03 15:07 ` Andrew Cooper
[not found] <412351d9=ef=bf=bdd3c6=ef=bf=bd81c6?= =?UTF-8?Q?=ef=bf=bde754=ef=bf=bd83180345aea7@suse.com>
[not found] <20180831162215.23318*1*jgross@suse.com>
[not found] <20180831162215.23318****1****jgross@suse.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf21f8ee-6496-194b-3318-f8023554ceea@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.