From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00608C433F5 for ; Tue, 17 May 2022 06:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236458AbiEQGhu (ORCPT ); Tue, 17 May 2022 02:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiEQGht (ORCPT ); Tue, 17 May 2022 02:37:49 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D77B92BB16; Mon, 16 May 2022 23:37:43 -0700 (PDT) X-UUID: 1be3c25555d747e0b02388ea4d6ebf8b-20220517 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:c863057f-9fd9-4192-988f-bb7b614463c7,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:4b5473e2-edbf-4bd4-8a34-dfc5f7bb086d,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 1be3c25555d747e0b02388ea4d6ebf8b-20220517 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 838221604; Tue, 17 May 2022 14:37:38 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 17 May 2022 14:37:37 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 17 May 2022 14:37:36 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] memory: mtk-smi: Add support for MT6795 Helio X10 From: Yong Wu To: AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Date: Tue, 17 May 2022 14:37:36 +0800 In-Reply-To: <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> References: <20220513150633.387200-1-angelogioacchino.delregno@collabora.com> <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On Fri, 2022-05-13 at 17:06 +0200, AngeloGioacchino Del Regno wrote: > The MediaTek Helio X10 (MT6795) SoC has 5 LARBs and one common SMI > instance without any sub-common and without GALS. > > While the smi-common configuration is specific to this SoC, on the > LARB side, this is similar to MT8173, in the sense that it doesn't > need the port in LARB, and the register layout is also compatible > with that one, which makes us able to fully reuse the smi-larb > platform data struct that was introduced for MT8173. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/memory/mtk-smi.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 86a3d34f418e..7e7c3ede19e4 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -21,11 +21,13 @@ > /* SMI COMMON */ > #define SMI_L1LEN 0x100 > > +#define SMI_L1_ARB 0x200 > #define SMI_BUS_SEL 0x220 > #define SMI_BUS_LARB_SHIFT(larbid) ((larbid) << 1) > /* All are MMU0 defaultly. Only specialize mmu1 here. */ > #define F_MMU1_LARB(larbid) (0x1 << > SMI_BUS_LARB_SHIFT(larbid)) > > +#define SMI_FIFO_TH0 0x230 Does the name come from the coda you got? It is called SMI_READ_FIFO_TH in my coda. > #define SMI_M4U_TH 0x234 > #define SMI_FIFO_TH1 0x238 > #define SMI_FIFO_TH2 0x23c > @@ -360,6 +362,7 @@ static const struct of_device_id > mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = > &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = > &mtk_smi_larb_mt2712}, > {.compatible = "mediatek,mt6779-smi-larb", .data = > &mtk_smi_larb_mt6779}, > + {.compatible = "mediatek,mt6795-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8167-smi-larb", .data = > &mtk_smi_larb_mt8167}, > {.compatible = "mediatek,mt8173-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = > &mtk_smi_larb_mt8183}, > @@ -541,6 +544,13 @@ static struct platform_driver > mtk_smi_larb_driver = { > } > }; > > +static const struct mtk_smi_reg_pair > mtk_smi_common_mt6795_init[SMI_COMMON_INIT_REGS_NR] = { > + {SMI_L1_ARB, 0x1b}, > + {SMI_M4U_TH, 0xce810c85}, > + {SMI_FIFO_TH1, 0x43214c8}, > + {SMI_FIFO_TH0, 0x191f}, > +}; > + > static const struct mtk_smi_reg_pair > mtk_smi_common_mt8195_init[SMI_COMMON_INIT_REGS_NR] = { > {SMI_L1LEN, 0xb}, > {SMI_M4U_TH, 0xe100e10}, > @@ -565,6 +575,12 @@ static const struct mtk_smi_common_plat > mtk_smi_common_mt6779 = { > F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt6795 = { > + .type = MTK_SMI_GEN2, > + .bus_sel = BIT(0), Like the other larbs, use F_MMU1_LARB(0) here? After the two changes, Reviewed-by: Yong Wu Thanks. > + .init = mtk_smi_common_mt6795_init, > +}; > + > static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = { > .type = MTK_SMI_GEN2, > .has_gals = true, > @@ -609,6 +625,7 @@ static const struct of_device_id > mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = > &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt6779-smi-common", .data = > &mtk_smi_common_mt6779}, > + {.compatible = "mediatek,mt6795-smi-common", .data = > &mtk_smi_common_mt6795}, > {.compatible = "mediatek,mt8167-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8173-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = > &mtk_smi_common_mt8183}, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88A8AC433F5 for ; Tue, 17 May 2022 06:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vinl5/bHdkJBxtljgSylMyvYiHZjOavynNLZzvI34qg=; b=ekmaR45falBPQD 3qrN0UaBtX/BQYntDBfinZfk8LAehr46St72CUJ5f91yfyf4MVIz5dfthPLNEWBE5sYNBAxD6qYZG ac1O3eH9juP3CKpaAbmozi1IPv6N9ROHSo6EjY9lVKciuZmGAMTF+lP+TFpNv1VeAjM+OwKVr8m1K GPeM5tDf9jkKlH0f/mMp+AfWl0yA/IturdW2ua8kn6lMY/V4jFid0MS6HLVq43P46o3gFrHWXcAZQ QjMHpJNI0o9kddKurvhXSG4aXIcephyKBvBjBixP4fXvRw3xFA4dxg8Owf31NvBMWSdB8oYcvsyew 9rzgDCUVBqB99u4zJfTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqqtL-00BqKS-UM; Tue, 17 May 2022 06:41:11 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqqtI-00BqIV-AY; Tue, 17 May 2022 06:41:10 +0000 X-UUID: 55070ea78dd7434fba5c50d6a7d2598d-20220516 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uZLywv0eLUIAaHbRIpVziZl9Lb2zsR9vV5zJezUXmIA=; b=IQCA9oDoHcVuM8hdPyYpr1Vw5qfB+vKdyeu1/MB+8TdOXUxxqfygUSbKBCdLy30Omjw+7ARtj/cFURXFgQZpxaH9N5AaFgvuobwyf5WkPFiOdXDj7C7xAt3e/JZcnZyj1p7qBqgbb9ruCQYcTRlliGEe+rx/liXMQw/F8dEXc68=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:ff048a3b-2605-4a3f-bc33-9c5f152350ef, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:2d7273e2-edbf-4bd4-8a34-dfc5f7bb086d, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 55070ea78dd7434fba5c50d6a7d2598d-20220516 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1548494640; Mon, 16 May 2022 23:41:02 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 May 2022 23:37:39 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 17 May 2022 14:37:37 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 17 May 2022 14:37:36 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] memory: mtk-smi: Add support for MT6795 Helio X10 From: Yong Wu To: AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Date: Tue, 17 May 2022 14:37:36 +0800 In-Reply-To: <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> References: <20220513150633.387200-1-angelogioacchino.delregno@collabora.com> <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_234109_219872_BB608DD9 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2022-05-13 at 17:06 +0200, AngeloGioacchino Del Regno wrote: > The MediaTek Helio X10 (MT6795) SoC has 5 LARBs and one common SMI > instance without any sub-common and without GALS. > > While the smi-common configuration is specific to this SoC, on the > LARB side, this is similar to MT8173, in the sense that it doesn't > need the port in LARB, and the register layout is also compatible > with that one, which makes us able to fully reuse the smi-larb > platform data struct that was introduced for MT8173. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/memory/mtk-smi.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 86a3d34f418e..7e7c3ede19e4 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -21,11 +21,13 @@ > /* SMI COMMON */ > #define SMI_L1LEN 0x100 > > +#define SMI_L1_ARB 0x200 > #define SMI_BUS_SEL 0x220 > #define SMI_BUS_LARB_SHIFT(larbid) ((larbid) << 1) > /* All are MMU0 defaultly. Only specialize mmu1 here. */ > #define F_MMU1_LARB(larbid) (0x1 << > SMI_BUS_LARB_SHIFT(larbid)) > > +#define SMI_FIFO_TH0 0x230 Does the name come from the coda you got? It is called SMI_READ_FIFO_TH in my coda. > #define SMI_M4U_TH 0x234 > #define SMI_FIFO_TH1 0x238 > #define SMI_FIFO_TH2 0x23c > @@ -360,6 +362,7 @@ static const struct of_device_id > mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = > &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = > &mtk_smi_larb_mt2712}, > {.compatible = "mediatek,mt6779-smi-larb", .data = > &mtk_smi_larb_mt6779}, > + {.compatible = "mediatek,mt6795-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8167-smi-larb", .data = > &mtk_smi_larb_mt8167}, > {.compatible = "mediatek,mt8173-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = > &mtk_smi_larb_mt8183}, > @@ -541,6 +544,13 @@ static struct platform_driver > mtk_smi_larb_driver = { > } > }; > > +static const struct mtk_smi_reg_pair > mtk_smi_common_mt6795_init[SMI_COMMON_INIT_REGS_NR] = { > + {SMI_L1_ARB, 0x1b}, > + {SMI_M4U_TH, 0xce810c85}, > + {SMI_FIFO_TH1, 0x43214c8}, > + {SMI_FIFO_TH0, 0x191f}, > +}; > + > static const struct mtk_smi_reg_pair > mtk_smi_common_mt8195_init[SMI_COMMON_INIT_REGS_NR] = { > {SMI_L1LEN, 0xb}, > {SMI_M4U_TH, 0xe100e10}, > @@ -565,6 +575,12 @@ static const struct mtk_smi_common_plat > mtk_smi_common_mt6779 = { > F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt6795 = { > + .type = MTK_SMI_GEN2, > + .bus_sel = BIT(0), Like the other larbs, use F_MMU1_LARB(0) here? After the two changes, Reviewed-by: Yong Wu Thanks. > + .init = mtk_smi_common_mt6795_init, > +}; > + > static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = { > .type = MTK_SMI_GEN2, > .has_gals = true, > @@ -609,6 +625,7 @@ static const struct of_device_id > mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = > &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt6779-smi-common", .data = > &mtk_smi_common_mt6779}, > + {.compatible = "mediatek,mt6795-smi-common", .data = > &mtk_smi_common_mt6795}, > {.compatible = "mediatek,mt8167-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8173-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = > &mtk_smi_common_mt8183}, _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52B52C433EF for ; Tue, 17 May 2022 06:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+HIrpr2jW6HMDgwlk0peakJFWxwOEMNJwAwTt65N+qA=; b=SmSjCJ/xVmnXjC Mhp4pm64b5DkbBzxNZHqbBhqUSCoojWI/LB/kVdeZ3gtqOBx6KaebxvV7wn6FNm2VSZ1spJwl8NkI uPi4nu78DXI8EDVovkG+p1kjomroSKuLhPkiAakvTL3Dbfc0W95j5NwXwPPTFheMR3Cc26l9bV1GJ 3gsCa611NhpmpgxceKpqrI9BeN+vMDypUq6Q++Lm3T0CtS1P5MzSRkFB9WAwjePHnmWd0thINp0bO Df9cAfcegJbDXs8olj/RVod/CRZANwngGwJmfpJ4gL0morJHCfXa0FCs3B/fJqeXpUTcO8+3xnhZo D42oTOlIaR0swdAWmMPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqqtN-00BqKZ-05; Tue, 17 May 2022 06:41:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqqtI-00BqIV-AY; Tue, 17 May 2022 06:41:10 +0000 X-UUID: 55070ea78dd7434fba5c50d6a7d2598d-20220516 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uZLywv0eLUIAaHbRIpVziZl9Lb2zsR9vV5zJezUXmIA=; b=IQCA9oDoHcVuM8hdPyYpr1Vw5qfB+vKdyeu1/MB+8TdOXUxxqfygUSbKBCdLy30Omjw+7ARtj/cFURXFgQZpxaH9N5AaFgvuobwyf5WkPFiOdXDj7C7xAt3e/JZcnZyj1p7qBqgbb9ruCQYcTRlliGEe+rx/liXMQw/F8dEXc68=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:ff048a3b-2605-4a3f-bc33-9c5f152350ef, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:2d7273e2-edbf-4bd4-8a34-dfc5f7bb086d, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 55070ea78dd7434fba5c50d6a7d2598d-20220516 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1548494640; Mon, 16 May 2022 23:41:02 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 May 2022 23:37:39 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 17 May 2022 14:37:37 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 17 May 2022 14:37:36 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] memory: mtk-smi: Add support for MT6795 Helio X10 From: Yong Wu To: AngeloGioacchino Del Regno , Krzysztof Kozlowski CC: , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Date: Tue, 17 May 2022 14:37:36 +0800 In-Reply-To: <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> References: <20220513150633.387200-1-angelogioacchino.delregno@collabora.com> <20220513150633.387200-3-angelogioacchino.delregno@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_234109_219872_BB608DD9 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-05-13 at 17:06 +0200, AngeloGioacchino Del Regno wrote: > The MediaTek Helio X10 (MT6795) SoC has 5 LARBs and one common SMI > instance without any sub-common and without GALS. > > While the smi-common configuration is specific to this SoC, on the > LARB side, this is similar to MT8173, in the sense that it doesn't > need the port in LARB, and the register layout is also compatible > with that one, which makes us able to fully reuse the smi-larb > platform data struct that was introduced for MT8173. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/memory/mtk-smi.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 86a3d34f418e..7e7c3ede19e4 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -21,11 +21,13 @@ > /* SMI COMMON */ > #define SMI_L1LEN 0x100 > > +#define SMI_L1_ARB 0x200 > #define SMI_BUS_SEL 0x220 > #define SMI_BUS_LARB_SHIFT(larbid) ((larbid) << 1) > /* All are MMU0 defaultly. Only specialize mmu1 here. */ > #define F_MMU1_LARB(larbid) (0x1 << > SMI_BUS_LARB_SHIFT(larbid)) > > +#define SMI_FIFO_TH0 0x230 Does the name come from the coda you got? It is called SMI_READ_FIFO_TH in my coda. > #define SMI_M4U_TH 0x234 > #define SMI_FIFO_TH1 0x238 > #define SMI_FIFO_TH2 0x23c > @@ -360,6 +362,7 @@ static const struct of_device_id > mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = > &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = > &mtk_smi_larb_mt2712}, > {.compatible = "mediatek,mt6779-smi-larb", .data = > &mtk_smi_larb_mt6779}, > + {.compatible = "mediatek,mt6795-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8167-smi-larb", .data = > &mtk_smi_larb_mt8167}, > {.compatible = "mediatek,mt8173-smi-larb", .data = > &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = > &mtk_smi_larb_mt8183}, > @@ -541,6 +544,13 @@ static struct platform_driver > mtk_smi_larb_driver = { > } > }; > > +static const struct mtk_smi_reg_pair > mtk_smi_common_mt6795_init[SMI_COMMON_INIT_REGS_NR] = { > + {SMI_L1_ARB, 0x1b}, > + {SMI_M4U_TH, 0xce810c85}, > + {SMI_FIFO_TH1, 0x43214c8}, > + {SMI_FIFO_TH0, 0x191f}, > +}; > + > static const struct mtk_smi_reg_pair > mtk_smi_common_mt8195_init[SMI_COMMON_INIT_REGS_NR] = { > {SMI_L1LEN, 0xb}, > {SMI_M4U_TH, 0xe100e10}, > @@ -565,6 +575,12 @@ static const struct mtk_smi_common_plat > mtk_smi_common_mt6779 = { > F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt6795 = { > + .type = MTK_SMI_GEN2, > + .bus_sel = BIT(0), Like the other larbs, use F_MMU1_LARB(0) here? After the two changes, Reviewed-by: Yong Wu Thanks. > + .init = mtk_smi_common_mt6795_init, > +}; > + > static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = { > .type = MTK_SMI_GEN2, > .has_gals = true, > @@ -609,6 +625,7 @@ static const struct of_device_id > mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = > &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt6779-smi-common", .data = > &mtk_smi_common_mt6779}, > + {.compatible = "mediatek,mt6795-smi-common", .data = > &mtk_smi_common_mt6795}, > {.compatible = "mediatek,mt8167-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8173-smi-common", .data = > &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = > &mtk_smi_common_mt8183}, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel