From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C777C4320A for ; Wed, 25 Aug 2021 12:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AAF3610CD for ; Wed, 25 Aug 2021 12:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241011AbhHYM6H (ORCPT ); Wed, 25 Aug 2021 08:58:07 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:36358 "EHLO mail-wm1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240078AbhHYM6G (ORCPT ); Wed, 25 Aug 2021 08:58:06 -0400 Received: by mail-wm1-f50.google.com with SMTP id 79-20020a1c0452000000b002e6cf79e572so4254309wme.1; Wed, 25 Aug 2021 05:57:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IG8qKdffC7gdvGfE8uAq0sKcTN9fnBfsEwkWoC4/ddk=; b=C6ZjJ4aBPE8EQ92uTG+NflfUFhxxSFW973calEllJL8UbczEqk2Fifv5aDdNpDoN0V ouvRzZTEFP544d3Fcv1Q0rfRcZ/yo2hbL1DebHBBRxZHYlqwA1PTpGZw8E9VbUKK2UT9 JaEQPiasqj5e28QKZK+t6p1ZY2JDmgqq8cYdj+yIa3rdAalfMs8Ncpv2T+8etnszzf3v le2/ZoUsFFHKL7lkMyJFW75pH64pbUlAIx7M5QsMzR47bkwPLl0uplh2498Qkiq/hWh1 20H8duLDG933CSei0RPA3XRyW+3GyBuJMKcx9Vrw58m1IrvlSsnHn0mvQOx0sFnnj3WX YijA== X-Gm-Message-State: AOAM5307okU0l0Nalusx/2WeAqHGZFu1CPbUciFqZ2NAZ9XWLs+YIhvh UO9g2fkoP0+OMyvjDJWhNFr6b5TPQD8= X-Google-Smtp-Source: ABdhPJydt2KoXOb8cPtUG5GcXDzc+2AOh9dS7oyCgSRxmxv2oZRFP4uz0TchHSZa3V2LqedKady1TA== X-Received: by 2002:a7b:c048:: with SMTP id u8mr9239781wmc.113.1629896239498; Wed, 25 Aug 2021 05:57:19 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id h6sm6086473wmq.5.2021.08.25.05.57.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 05:57:18 -0700 (PDT) Subject: Re: [PATCH] mxser: use semi-colons instead of commas To: Dan Carpenter Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20210825072435.GB13013@kili> From: Jiri Slaby Message-ID: Date: Wed, 25 Aug 2021 14:57:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210825072435.GB13013@kili> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25. 08. 21, 9:24, Dan Carpenter wrote: > This code works, but it's cleaner to use semi-colons at the end of > a statement instead of a comma. > > Signed-off-by: Dan Carpenter Acked-by: Jiri Slaby > --- > drivers/tty/mxser.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c > index 335e4e50d679..1216f3985e18 100644 > --- a/drivers/tty/mxser.c > +++ b/drivers/tty/mxser.c > @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty, > if (closing_wait != ASYNC_CLOSING_WAIT_NONE) > closing_wait = jiffies_to_msecs(closing_wait) / 10; > > - ss->type = info->type, > - ss->line = tty->index, > - ss->port = info->ioaddr, > - ss->irq = info->board->irq, > - ss->flags = info->port.flags, > - ss->baud_base = MXSER_BAUD_BASE, > + ss->type = info->type; > + ss->line = tty->index; > + ss->port = info->ioaddr; > + ss->irq = info->board->irq; > + ss->flags = info->port.flags; > + ss->baud_base = MXSER_BAUD_BASE; > ss->close_delay = close_delay; > ss->closing_wait = closing_wait; > ss->custom_divisor = MXSER_CUSTOM_DIVISOR, > -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DFBC4338F for ; Wed, 25 Aug 2021 12:59:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B833861052 for ; Wed, 25 Aug 2021 12:59:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B833861052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZdKl1gn1/uUbFo6HW5mVb6jbMqfVYyR5P1D7zbT73Qc=; b=J27dWVEU79ZT1tht9GqoYmW9ef GXEke5zXYYrJapu9K474C8b6zQqP5RNGAiqiqCzlzM8J6w97LYhqGxX/x0qxvjdb7EQB5EawD/SvC AF9dFR/pBaUuWEJ8LzGKfDjIGyu6hY8BMkGmBs2TgMI56jyIPSZhkpev8jkzJTkURENoE4e3EMWpT 1TOXdVzZZ3dFWrHAQ9y6UWT+ngT64zakG2jdrgWlvmTkhDxF4Wylx1FTbTTLRhDPKycqTEGo9TMoU sb2GWJ50u20MpblkdH7r2T3zzHcEco5i6kal0wdX9gFfrP+osSF+zwIiVEY7PljeJm8yM1kMiHmeg flCXoRPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIsT8-006z0W-DZ; Wed, 25 Aug 2021 12:57:26 +0000 Received: from mail-wm1-f45.google.com ([209.85.128.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIsT4-006yy3-6G for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 12:57:23 +0000 Received: by mail-wm1-f45.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso4506826wmi.5 for ; Wed, 25 Aug 2021 05:57:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IG8qKdffC7gdvGfE8uAq0sKcTN9fnBfsEwkWoC4/ddk=; b=rAbnyF1kB46CIiUswmaqeBQoD8KKPWPXzAWEB818HFsP4oWei2zPpcpa72+1qg1qrb fph+G5JwrHdBIX/+VqMPhSHESSKwCsP7JTRaH/cbQlHUAIRKVLO6b3AZFR6KvAK9HYbz ZtW5nvGQ7c8+cb09C2Ofnx86wXNwkNpOlf5OKmKwP0qLYvk9khr49LUUpHEuuS9zkZKC sejKgdfml5Xq2SJlTqthy0ZdiYTJ3NMaWbOXRdZsBEZbVCo/EeKFWp8/iUtS2KjZ2N3+ LtKG/6SwCQ4PMqqpWKogHTYWrsYIrZ+EGpM/LnSAc6l5DMofHWji6u60W5a3cOpopN7S bveA== X-Gm-Message-State: AOAM533AombvH87LtA8pSR0IrSHCXdNioSXBVweqdmKtqSL315eZfktx KwDgmchmZ6OveD6E+Mpatcs= X-Google-Smtp-Source: ABdhPJydt2KoXOb8cPtUG5GcXDzc+2AOh9dS7oyCgSRxmxv2oZRFP4uz0TchHSZa3V2LqedKady1TA== X-Received: by 2002:a7b:c048:: with SMTP id u8mr9239781wmc.113.1629896239498; Wed, 25 Aug 2021 05:57:19 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id h6sm6086473wmq.5.2021.08.25.05.57.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 05:57:18 -0700 (PDT) Subject: Re: [PATCH] mxser: use semi-colons instead of commas To: Dan Carpenter Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20210825072435.GB13013@kili> From: Jiri Slaby Message-ID: Date: Wed, 25 Aug 2021 14:57:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210825072435.GB13013@kili> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_055722_267272_75AE0511 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25. 08. 21, 9:24, Dan Carpenter wrote: > This code works, but it's cleaner to use semi-colons at the end of > a statement instead of a comma. > > Signed-off-by: Dan Carpenter Acked-by: Jiri Slaby > --- > drivers/tty/mxser.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c > index 335e4e50d679..1216f3985e18 100644 > --- a/drivers/tty/mxser.c > +++ b/drivers/tty/mxser.c > @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty, > if (closing_wait != ASYNC_CLOSING_WAIT_NONE) > closing_wait = jiffies_to_msecs(closing_wait) / 10; > > - ss->type = info->type, > - ss->line = tty->index, > - ss->port = info->ioaddr, > - ss->irq = info->board->irq, > - ss->flags = info->port.flags, > - ss->baud_base = MXSER_BAUD_BASE, > + ss->type = info->type; > + ss->line = tty->index; > + ss->port = info->ioaddr; > + ss->irq = info->board->irq; > + ss->flags = info->port.flags; > + ss->baud_base = MXSER_BAUD_BASE; > ss->close_delay = close_delay; > ss->closing_wait = closing_wait; > ss->custom_divisor = MXSER_CUSTOM_DIVISOR, > -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel