From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A109CC433F5 for ; Mon, 3 Sep 2018 17:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5546C20779 for ; Mon, 3 Sep 2018 17:02:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5546C20779 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daenzer.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728832AbeICVXB (ORCPT ); Mon, 3 Sep 2018 17:23:01 -0400 Received: from mail.netline.ch ([148.251.143.178]:58117 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727836AbeICVW7 (ORCPT ); Mon, 3 Sep 2018 17:22:59 -0400 Received: from localhost (localhost [127.0.0.1]) by netline-mail3.netline.ch (Postfix) with ESMTP id 6A3DF2A604A; Mon, 3 Sep 2018 19:01:58 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at netline-mail3.netline.ch Received: from netline-mail3.netline.ch ([127.0.0.1]) by localhost (netline-mail3.netline.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8IuFyTELLTiM; Mon, 3 Sep 2018 19:01:57 +0200 (CEST) Received: from thor (67.124.127.176.dynamic.wline.res.cust.swisscom.ch [176.127.124.67]) by netline-mail3.netline.ch (Postfix) with ESMTPSA id A22D22A6049; Mon, 3 Sep 2018 19:01:56 +0200 (CEST) Received: from localhost ([::1]) by thor with esmtp (Exim 4.91) (envelope-from ) id 1fwsEe-0001xz-36; Mon, 03 Sep 2018 19:01:56 +0200 Subject: Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines. To: Gerd Hoffmann , David Airlie , Sean Paul References: <20180903105756.24912-1-kraxel@redhat.com> <20180903105756.24912-4-kraxel@redhat.com> <20180903164558.GL21634@phenom.ffwll.local> Cc: dri-devel@lists.freedesktop.org, open list From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Openpgp: preference=signencrypt Autocrypt: addr=michel@daenzer.net; prefer-encrypt=mutual; keydata= mQGiBDsehS8RBACbsIQEX31aYSIuEKxEnEX82ezMR8z3LG8ktv1KjyNErUX9Pt7AUC7W3W0b LUhu8Le8S2va6hi7GfSAifl0ih3k6Bv1Itzgnd+7ZmSrvCN8yGJaHNQfAevAuEboIb+MaVHo 9EMJj4ikOcRZCmQWw7evu/D9uQdtkCnRY9iJiAGxbwCguBHtpoGMxDOINCr5UU6qt+m4O+UD /355ohBBzzyh49lTj0kTFKr0Ozd20G2FbcqHgfFL1dc1MPyigej2gLga2osu2QY0ObvAGkOu WBi3LTY8Zs8uqFGDC4ZAwMPoFy3yzu3ne6T7d/68rJil0QcdQjzzHi6ekqHuhst4a+/+D23h Za8MJBEcdOhRhsaDVGAJSFEQB1qLBACOs0xN+XblejO35gsDSVVk8s+FUUw3TSWJBfZa3Imp V2U2tBO4qck+wqbHNfdnU/crrsHahjzBjvk8Up7VoY8oT+z03sal2vXEonS279xN2B92Tttr AgwosujguFO/7tvzymWC76rDEwue8TsADE11ErjwaBTs8ZXfnN/uAANgPLQjTWljaGVsIERh ZW56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD6IXgQTEQIAHgUCQFXxJgIbAwYLCQgHAwIDFQID AxYCAQIeAQIXgAAKCRBaga+OatuyAIrPAJ9ykonXI3oQcX83N2qzCEStLNW47gCeLWm/QiPY jqtGUnnSbyuTQfIySkK5AQ0EOx6FRRAEAJZkcvklPwJCgNiw37p0GShKmFGGqf/a3xZZEpjI qNxzshFRFneZze4f5LhzbX1/vIm5+ZXsEWympJfZzyCmYPw86QcFxyZflkAxHx9LeD+89Elx bw6wT0CcLvSv8ROfU1m8YhGbV6g2zWyLD0/naQGVb8e4FhVKGNY2EEbHgFBrAAMGA/0VktFO CxFBdzLQ17RCTwCJ3xpyP4qsLJH0yCoA26rH2zE2RzByhrTFTYZzbFEid3ddGiHOBEL+bO+2 GNtfiYKmbTkj1tMZJ8L6huKONaVrASFzLvZa2dlc2zja9ZSksKmge5BOTKWgbyepEc5qxSju YsYrX5xfLgTZC5abhhztpYhGBBgRAgAGBQI7HoVFAAoJEFqBr45q27IAlscAn2Ufk2d6/3p4 Cuyz/NX7KpL2dQ8WAJ9UD5JEakhfofed8PSqOM7jOO3LCA== Message-ID: Date: Mon, 3 Sep 2018 19:01:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180903164558.GL21634@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-09-03 6:45 p.m., Daniel Vetter wrote: > On Mon, Sep 03, 2018 at 12:57:54PM +0200, Gerd Hoffmann wrote: >> Userspace on big endian machhines typically expects the ADDFB ioctl >> returns a big endian framebuffer. drm_mode_addfb() will call >> drm_mode_addfb2() unconditionally with little endian DRM_FORMAT_* >> values though, which is wrong. This patch fixes that. >> >> Drivers (both kernel and xorg) have quirks in place to deal with the >> broken drm_mode_addfb() behavior. Because of this we can't just change >> drm_mode_addfb() behavior for everybody without breaking things. So add >> a new driver feature flag DRIVER_PREFER_HOST_BYTE_ORDER, so drivers can >> opt-in. Since the changes are opt-in now, they shouldn't affect drivers which don't opt in; they should work as well (or as badly :) after these changes as they did before. So no concerns from my side anymore. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines. Date: Mon, 3 Sep 2018 19:01:55 +0200 Message-ID: References: <20180903105756.24912-1-kraxel@redhat.com> <20180903105756.24912-4-kraxel@redhat.com> <20180903164558.GL21634@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from netline-mail3.netline.ch (mail.netline.ch [148.251.143.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 492DE6E2A1 for ; Mon, 3 Sep 2018 17:01:59 +0000 (UTC) In-Reply-To: <20180903164558.GL21634@phenom.ffwll.local> Content-Language: en-CA List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann , David Airlie , Sean Paul Cc: open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjAxOC0wOS0wMyA2OjQ1IHAubS4sIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gTW9uLCBT ZXAgMDMsIDIwMTggYXQgMTI6NTc6NTRQTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3cm90ZToKPj4g VXNlcnNwYWNlIG9uIGJpZyBlbmRpYW4gbWFjaGhpbmVzIHR5cGljYWxseSBleHBlY3RzIHRoZSBB RERGQiBpb2N0bAo+PiByZXR1cm5zIGEgYmlnIGVuZGlhbiBmcmFtZWJ1ZmZlci4gIGRybV9tb2Rl X2FkZGZiKCkgd2lsbCBjYWxsCj4+IGRybV9tb2RlX2FkZGZiMigpIHVuY29uZGl0aW9uYWxseSB3 aXRoIGxpdHRsZSBlbmRpYW4gRFJNX0ZPUk1BVF8qCj4+IHZhbHVlcyB0aG91Z2gsIHdoaWNoIGlz IHdyb25nLiAgVGhpcyBwYXRjaCBmaXhlcyB0aGF0Lgo+Pgo+PiBEcml2ZXJzIChib3RoIGtlcm5l bCBhbmQgeG9yZykgaGF2ZSBxdWlya3MgaW4gcGxhY2UgdG8gZGVhbCB3aXRoIHRoZQo+PiBicm9r ZW4gZHJtX21vZGVfYWRkZmIoKSBiZWhhdmlvci4gIEJlY2F1c2Ugb2YgdGhpcyB3ZSBjYW4ndCBq dXN0IGNoYW5nZQo+PiBkcm1fbW9kZV9hZGRmYigpIGJlaGF2aW9yIGZvciBldmVyeWJvZHkgd2l0 aG91dCBicmVha2luZyB0aGluZ3MuICBTbyBhZGQKPj4gYSBuZXcgZHJpdmVyIGZlYXR1cmUgZmxh ZyBEUklWRVJfUFJFRkVSX0hPU1RfQllURV9PUkRFUiwgc28gZHJpdmVycyBjYW4KPj4gb3B0LWlu LgoKU2luY2UgdGhlIGNoYW5nZXMgYXJlIG9wdC1pbiBub3csIHRoZXkgc2hvdWxkbid0IGFmZmVj dCBkcml2ZXJzIHdoaWNoCmRvbid0IG9wdCBpbjsgdGhleSBzaG91bGQgd29yayBhcyB3ZWxsIChv ciBhcyBiYWRseSA6KSBhZnRlciB0aGVzZQpjaGFuZ2VzIGFzIHRoZXkgZGlkIGJlZm9yZS4gU28g bm8gY29uY2VybnMgZnJvbSBteSBzaWRlIGFueW1vcmUuCgoKLS0gCkVhcnRobGluZyBNaWNoZWwg RMOkbnplciAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICBodHRwOi8vd3d3LmFtZC5jb20K TGlicmUgc29mdHdhcmUgZW50aHVzaWFzdCAgICAgICAgICAgICB8ICAgICAgICAgICAgIE1lc2Eg YW5kIFggZGV2ZWxvcGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=