From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH v5 2/2] net/mlx5: fix instruction hotspot on
 replenishing Rx buffer
Date: Wed, 6 Feb 2019 15:54:04 +0000
Message-ID: <cf42c729-1127-7153-835d-cef7ef9ce5d4@redhat.com>
References: <20190109085426.39965-1-yskoh@mellanox.com>
 <20190114211622.6900-1-yskoh@mellanox.com>
 <20190114211622.6900-2-yskoh@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, arybchenko@solarflare.com, roszenrami@gmail.com,
 david.marchand@redhat.com, stable@dpdk.org
To: Yongseok Koh <yskoh@mellanox.com>, olivier.matz@6wind.com,
 shahafs@mellanox.com
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190114211622.6900-2-yskoh@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 01/14/2019 09:16 PM, Yongseok Koh wrote:
> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed
> to be accessed as it is static and easily calculated from the mbuf address.
> Accessing the mbuf content causes unnecessary load stall and it is worsened
> on ARM.
> 
> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx")
> Cc: stable@dpdk.org
> 

This is using the API introduced in 1/2, so it's not really suitable for
backport. Maybe you want to send an alternative for stable?

> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---