From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24AFC4332E for ; Mon, 23 Mar 2020 08:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0C9420736 for ; Mon, 23 Mar 2020 08:11:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727538AbgCWILT (ORCPT ); Mon, 23 Mar 2020 04:11:19 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:35004 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727422AbgCWILT (ORCPT ); Mon, 23 Mar 2020 04:11:19 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CDDB242FB3B17C38F76B; Mon, 23 Mar 2020 16:11:09 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Mon, 23 Mar 2020 16:11:02 +0800 Subject: Re: [PATCH v5 20/23] KVM: arm64: GICv4.1: Plumb SGI implementation selection in the distributor To: Marc Zyngier CC: , , , , Lorenzo Pieralisi , Jason Cooper , "Robert Richter" , Thomas Gleixner , "Eric Auger" , James Morse , "Julien Thierry" , Suzuki K Poulose References: <20200304203330.4967-1-maz@kernel.org> <20200304203330.4967-21-maz@kernel.org> <72832f51-bbde-8502-3e03-189ac20a0143@huawei.com> <4a06fae9c93e10351276d173747d17f4@kernel.org> <1c9fdfc8-bdb2-88b6-4bdc-2b9254dfa55c@huawei.com> <256b58a9679412c96600217f316f424f@kernel.org> From: Zenghui Yu Message-ID: Date: Mon, 23 Mar 2020 16:11:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <256b58a9679412c96600217f316f424f@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 2020/3/20 17:01, Marc Zyngier wrote: > Hi Zenghui, > > On 2020-03-20 03:53, Zenghui Yu wrote: >> Hi Marc, >> >> On 2020/3/19 20:10, Marc Zyngier wrote: >>>> But I wonder that should we use nassgireq to *only* keep track what >>>> the guest had written into the GICD_CTLR.nASSGIreq.  If not, we may >>>> lose the guest-request bit after migration among hosts with different >>>> has_gicv4_1 settings. >>> >>> I'm unsure of what you're suggesting here. If userspace tries to set >>> GICD_CTLR.nASSGIreq on a non-4.1 host, this bit will not latch. >> >> This is exactly what I *was* concerning about. >> >>> Userspace can check that at restore time. Or we could fail the >>> userspace write, which is a bit odd (the bit is otherwise RES0). >>> >>> Could you clarify your proposal? >> >> Let's assume two hosts below. 'has_gicv4_1' is true on host-A while >> it is false on host-B because of lack of HW support or the kernel >> parameter "kvm-arm.vgic_v4_enable=0". >> >> If we migrate guest through A->B->A, we may end-up lose the initial >> guest-request "nASSGIreq=1" and don't use direct vSGI delivery for >> this guest when it's migrated back to host-A. > > My point above is that we shouldn't allow the A->B migration the first > place, and fail it as quickly as possible. We don't know what the guest > has observed in terms of GIC capability, and it may not have enabled the > new flavour of SGIs just yet. Indeed. I didn't realize it. > >> This can be "fixed" by keep track of what guest had written into >> nASSGIreq. And we need to evaluate the need for using direct vSGI >> for a specified guest by 'has_gicv4_1 && nassgireq'. > > It feels odd. It means we have more state than the HW normally has. > I have an alternative proposal, see below. > >> But if it's expected that "if userspace tries to set nASSGIreq on >> a non-4.1 host, this bit will not latch", then this shouldn't be >> a problem at all. > > Well, that is the semantics of the RES0 bit. It applies from both > guest and userspace. > > And actually, maybe we can handle that pretty cheaply. If userspace > tries to restore GICD_TYPER2 to a value that isn't what KVM can > offer, we just return an error. Exactly like we do for GICD_IIDR. > Hence the following patch: > > diff --git a/virt/kvm/arm/vgic/vgic-mmio-v3.c > b/virt/kvm/arm/vgic/vgic-mmio-v3.c > index 28b639fd1abc..e72dcc454247 100644 > --- a/virt/kvm/arm/vgic/vgic-mmio-v3.c > +++ b/virt/kvm/arm/vgic/vgic-mmio-v3.c > @@ -156,6 +156,7 @@ static int vgic_mmio_uaccess_write_v3_misc(struct > kvm_vcpu *vcpu, >      struct vgic_dist *dist = &vcpu->kvm->arch.vgic; > >      switch (addr & 0x0c) { > +    case GICD_TYPER2: >      case GICD_IIDR: >          if (val != vgic_mmio_read_v3_misc(vcpu, addr, len)) >              return -EINVAL; > > Being a RO register, writing something that isn't compatible with the > possible behaviour of the hypervisor will just return an error. This is really a nice point to address my concern! I'm happy to see this in v6 now. > > What do you think? I agreed with you, with a bit nervous though. Some old guests (which have no knowledge about GICv4.1 vSGIs and don't care about nASSGIcap at all) will also fail to migrate from A to B, just because now we present two different (unused) GICD_TYPER2 registers to them. Is it a little unfair to them :-) ? Thanks, Zenghui From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D387BC4332E for ; Mon, 23 Mar 2020 08:11:24 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5C58420736 for ; Mon, 23 Mar 2020 08:11:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C58420736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B445F4B085; Mon, 23 Mar 2020 04:11:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W1w7P6d6eaN6; Mon, 23 Mar 2020 04:11:22 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 80B624B09A; Mon, 23 Mar 2020 04:11:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 228834B09A for ; Mon, 23 Mar 2020 04:11:21 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elTLb5cRNnZI for ; Mon, 23 Mar 2020 04:11:19 -0400 (EDT) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id F14AA4A534 for ; Mon, 23 Mar 2020 04:11:18 -0400 (EDT) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CDDB242FB3B17C38F76B; Mon, 23 Mar 2020 16:11:09 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Mon, 23 Mar 2020 16:11:02 +0800 Subject: Re: [PATCH v5 20/23] KVM: arm64: GICv4.1: Plumb SGI implementation selection in the distributor To: Marc Zyngier References: <20200304203330.4967-1-maz@kernel.org> <20200304203330.4967-21-maz@kernel.org> <72832f51-bbde-8502-3e03-189ac20a0143@huawei.com> <4a06fae9c93e10351276d173747d17f4@kernel.org> <1c9fdfc8-bdb2-88b6-4bdc-2b9254dfa55c@huawei.com> <256b58a9679412c96600217f316f424f@kernel.org> From: Zenghui Yu Message-ID: Date: Mon, 23 Mar 2020 16:11:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <256b58a9679412c96600217f316f424f@kernel.org> Content-Language: en-US X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgTWFyYywKCk9uIDIwMjAvMy8yMCAxNzowMSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFpl bmdodWksCj4gCj4gT24gMjAyMC0wMy0yMCAwMzo1MywgWmVuZ2h1aSBZdSB3cm90ZToKPj4gSGkg TWFyYywKPj4KPj4gT24gMjAyMC8zLzE5IDIwOjEwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4g QnV0IEkgd29uZGVyIHRoYXQgc2hvdWxkIHdlIHVzZSBuYXNzZ2lyZXEgdG8gKm9ubHkqIGtlZXAg dHJhY2sgd2hhdAo+Pj4+IHRoZSBndWVzdCBoYWQgd3JpdHRlbiBpbnRvIHRoZSBHSUNEX0NUTFIu bkFTU0dJcmVxLsKgIElmIG5vdCwgd2UgbWF5Cj4+Pj4gbG9zZSB0aGUgZ3Vlc3QtcmVxdWVzdCBi aXQgYWZ0ZXIgbWlncmF0aW9uIGFtb25nIGhvc3RzIHdpdGggZGlmZmVyZW50Cj4+Pj4gaGFzX2dp Y3Y0XzEgc2V0dGluZ3MuCj4+Pgo+Pj4gSSdtIHVuc3VyZSBvZiB3aGF0IHlvdSdyZSBzdWdnZXN0 aW5nIGhlcmUuIElmIHVzZXJzcGFjZSB0cmllcyB0byBzZXQKPj4+IEdJQ0RfQ1RMUi5uQVNTR0ly ZXEgb24gYSBub24tNC4xIGhvc3QsIHRoaXMgYml0IHdpbGwgbm90IGxhdGNoLgo+Pgo+PiBUaGlz IGlzIGV4YWN0bHkgd2hhdCBJICp3YXMqIGNvbmNlcm5pbmcgYWJvdXQuCj4+Cj4+PiBVc2Vyc3Bh Y2UgY2FuIGNoZWNrIHRoYXQgYXQgcmVzdG9yZSB0aW1lLiBPciB3ZSBjb3VsZCBmYWlsIHRoZQo+ Pj4gdXNlcnNwYWNlIHdyaXRlLCB3aGljaCBpcyBhIGJpdCBvZGQgKHRoZSBiaXQgaXMgb3RoZXJ3 aXNlIFJFUzApLgo+Pj4KPj4+IENvdWxkIHlvdSBjbGFyaWZ5IHlvdXIgcHJvcG9zYWw/Cj4+Cj4+ IExldCdzIGFzc3VtZSB0d28gaG9zdHMgYmVsb3cuICdoYXNfZ2ljdjRfMScgaXMgdHJ1ZSBvbiBo b3N0LUEgd2hpbGUKPj4gaXQgaXMgZmFsc2Ugb24gaG9zdC1CIGJlY2F1c2Ugb2YgbGFjayBvZiBI VyBzdXBwb3J0IG9yIHRoZSBrZXJuZWwKPj4gcGFyYW1ldGVyICJrdm0tYXJtLnZnaWNfdjRfZW5h YmxlPTAiLgo+Pgo+PiBJZiB3ZSBtaWdyYXRlIGd1ZXN0IHRocm91Z2ggQS0+Qi0+QSwgd2UgbWF5 IGVuZC11cCBsb3NlIHRoZSBpbml0aWFsCj4+IGd1ZXN0LXJlcXVlc3QgIm5BU1NHSXJlcT0xIiBh bmQgZG9uJ3QgdXNlIGRpcmVjdCB2U0dJIGRlbGl2ZXJ5IGZvcgo+PiB0aGlzIGd1ZXN0IHdoZW4g aXQncyBtaWdyYXRlZCBiYWNrIHRvIGhvc3QtQS4KPiAKPiBNeSBwb2ludCBhYm92ZSBpcyB0aGF0 IHdlIHNob3VsZG4ndCBhbGxvdyB0aGUgQS0+QiBtaWdyYXRpb24gdGhlIGZpcnN0Cj4gcGxhY2Us IGFuZCBmYWlsIGl0IGFzIHF1aWNrbHkgYXMgcG9zc2libGUuIFdlIGRvbid0IGtub3cgd2hhdCB0 aGUgZ3Vlc3QKPiBoYXMgb2JzZXJ2ZWQgaW4gdGVybXMgb2YgR0lDIGNhcGFiaWxpdHksIGFuZCBp dCBtYXkgbm90IGhhdmUgZW5hYmxlZCB0aGUKPiBuZXcgZmxhdm91ciBvZiBTR0lzIGp1c3QgeWV0 LgoKSW5kZWVkLiBJIGRpZG4ndCByZWFsaXplIGl0LgoKPiAKPj4gVGhpcyBjYW4gYmUgImZpeGVk IiBieSBrZWVwIHRyYWNrIG9mIHdoYXQgZ3Vlc3QgaGFkIHdyaXR0ZW4gaW50bwo+PiBuQVNTR0ly ZXEuIEFuZCB3ZSBuZWVkIHRvIGV2YWx1YXRlIHRoZSBuZWVkIGZvciB1c2luZyBkaXJlY3QgdlNH SQo+PiBmb3IgYSBzcGVjaWZpZWQgZ3Vlc3QgYnkgJ2hhc19naWN2NF8xICYmIG5hc3NnaXJlcScu Cj4gCj4gSXQgZmVlbHMgb2RkLiBJdCBtZWFucyB3ZSBoYXZlIG1vcmUgc3RhdGUgdGhhbiB0aGUg SFcgbm9ybWFsbHkgaGFzLgo+IEkgaGF2ZSBhbiBhbHRlcm5hdGl2ZSBwcm9wb3NhbCwgc2VlIGJl bG93Lgo+IAo+PiBCdXQgaWYgaXQncyBleHBlY3RlZCB0aGF0ICJpZiB1c2Vyc3BhY2UgdHJpZXMg dG8gc2V0IG5BU1NHSXJlcSBvbgo+PiBhIG5vbi00LjEgaG9zdCwgdGhpcyBiaXQgd2lsbCBub3Qg bGF0Y2giLCB0aGVuIHRoaXMgc2hvdWxkbid0IGJlCj4+IGEgcHJvYmxlbSBhdCBhbGwuCj4gCj4g V2VsbCwgdGhhdCBpcyB0aGUgc2VtYW50aWNzIG9mIHRoZSBSRVMwIGJpdC4gSXQgYXBwbGllcyBm cm9tIGJvdGgKPiBndWVzdCBhbmQgdXNlcnNwYWNlLgo+IAo+IEFuZCBhY3R1YWxseSwgbWF5YmUg d2UgY2FuIGhhbmRsZSB0aGF0IHByZXR0eSBjaGVhcGx5LiBJZiB1c2Vyc3BhY2UKPiB0cmllcyB0 byByZXN0b3JlIEdJQ0RfVFlQRVIyIHRvIGEgdmFsdWUgdGhhdCBpc24ndCB3aGF0IEtWTSBjYW4K PiBvZmZlciwgd2UganVzdCByZXR1cm4gYW4gZXJyb3IuIEV4YWN0bHkgbGlrZSB3ZSBkbyBmb3Ig R0lDRF9JSURSLgo+IEhlbmNlIHRoZSBmb2xsb3dpbmcgcGF0Y2g6Cj4gCj4gZGlmZiAtLWdpdCBh L3ZpcnQva3ZtL2FybS92Z2ljL3ZnaWMtbW1pby12My5jIAo+IGIvdmlydC9rdm0vYXJtL3ZnaWMv dmdpYy1tbWlvLXYzLmMKPiBpbmRleCAyOGI2MzlmZDFhYmMuLmU3MmRjYzQ1NDI0NyAxMDA2NDQK PiAtLS0gYS92aXJ0L2t2bS9hcm0vdmdpYy92Z2ljLW1taW8tdjMuYwo+ICsrKyBiL3ZpcnQva3Zt L2FybS92Z2ljL3ZnaWMtbW1pby12My5jCj4gQEAgLTE1Niw2ICsxNTYsNyBAQCBzdGF0aWMgaW50 IHZnaWNfbW1pb191YWNjZXNzX3dyaXRlX3YzX21pc2Moc3RydWN0IAo+IGt2bV92Y3B1ICp2Y3B1 LAo+ICDCoMKgwqDCoCBzdHJ1Y3QgdmdpY19kaXN0ICpkaXN0ID0gJnZjcHUtPmt2bS0+YXJjaC52 Z2ljOwo+IAo+ICDCoMKgwqDCoCBzd2l0Y2ggKGFkZHIgJiAweDBjKSB7Cj4gK8KgwqDCoCBjYXNl IEdJQ0RfVFlQRVIyOgo+ICDCoMKgwqDCoCBjYXNlIEdJQ0RfSUlEUjoKPiAgwqDCoMKgwqDCoMKg wqDCoCBpZiAodmFsICE9IHZnaWNfbW1pb19yZWFkX3YzX21pc2ModmNwdSwgYWRkciwgbGVuKSkK PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+IAo+IEJlaW5nIGEg Uk8gcmVnaXN0ZXIsIHdyaXRpbmcgc29tZXRoaW5nIHRoYXQgaXNuJ3QgY29tcGF0aWJsZSB3aXRo IHRoZQo+IHBvc3NpYmxlIGJlaGF2aW91ciBvZiB0aGUgaHlwZXJ2aXNvciB3aWxsIGp1c3QgcmV0 dXJuIGFuIGVycm9yLgoKVGhpcyBpcyByZWFsbHkgYSBuaWNlIHBvaW50IHRvIGFkZHJlc3MgbXkg Y29uY2VybiEgSSdtIGhhcHB5IHRvIHNlZQp0aGlzIGluIHY2IG5vdy4KCj4gCj4gV2hhdCBkbyB5 b3UgdGhpbms/CgpJIGFncmVlZCB3aXRoIHlvdSwgd2l0aCBhIGJpdCBuZXJ2b3VzIHRob3VnaC4g U29tZSBvbGQgZ3Vlc3RzICh3aGljaApoYXZlIG5vIGtub3dsZWRnZSBhYm91dCBHSUN2NC4xIHZT R0lzIGFuZCBkb24ndCBjYXJlIGFib3V0IG5BU1NHSWNhcAphdCBhbGwpIHdpbGwgYWxzbyBmYWls IHRvIG1pZ3JhdGUgZnJvbSBBIHRvIEIsIGp1c3QgYmVjYXVzZSBub3cgd2UKcHJlc2VudCB0d28g ZGlmZmVyZW50ICh1bnVzZWQpIEdJQ0RfVFlQRVIyIHJlZ2lzdGVycyB0byB0aGVtLgoKSXMgaXQg YSBsaXR0bGUgdW5mYWlyIHRvIHRoZW0gOi0pID8KCgpUaGFua3MsClplbmdodWkKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxp c3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlh LmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E47BC54FCF for ; Mon, 23 Mar 2020 08:11:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8A4520736 for ; Mon, 23 Mar 2020 08:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ra0xl55L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8A4520736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jkjaUianZsdVgZz7nDDfXiiGBuRpz/p5qw850yMpsCc=; b=ra0xl55L06aAopIf2700I5fk1 9Msqfb0qD4FLZCv4LIuDGTohlKCS+0ehPi1/9VvsR66L541cphlosH7Ngy0dOogXMmpYDxq9Q6+xn 9j8tirPffs7wuM7MkO0Gep8ANWe5neCgAGAgWSk69kvRK3H1+JBtPPhNetRw7ldCwWH6c04OVTQSR 1QCFMpd0P/FZkz6X8pVAPxfmQ9J1JUuDxu4s0tcSLI6KHAQpwVC/f7IR5NJtFsRQRjHoBKDpW+V0a sU2PxiYAwdRwdkStdLTpNvXGQQkAh2rCvC5kjUOkakx99e2DsICiQLkrFIzIoDwj0owMr/+W0mpiS dL7bYlsXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGIBA-0007YA-Pm; Mon, 23 Mar 2020 08:11:24 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGIB6-0007XH-VZ for linux-arm-kernel@lists.infradead.org; Mon, 23 Mar 2020 08:11:23 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CDDB242FB3B17C38F76B; Mon, 23 Mar 2020 16:11:09 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Mon, 23 Mar 2020 16:11:02 +0800 Subject: Re: [PATCH v5 20/23] KVM: arm64: GICv4.1: Plumb SGI implementation selection in the distributor To: Marc Zyngier References: <20200304203330.4967-1-maz@kernel.org> <20200304203330.4967-21-maz@kernel.org> <72832f51-bbde-8502-3e03-189ac20a0143@huawei.com> <4a06fae9c93e10351276d173747d17f4@kernel.org> <1c9fdfc8-bdb2-88b6-4bdc-2b9254dfa55c@huawei.com> <256b58a9679412c96600217f316f424f@kernel.org> From: Zenghui Yu Message-ID: Date: Mon, 23 Mar 2020 16:11:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <256b58a9679412c96600217f316f424f@kernel.org> Content-Language: en-US X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200323_011121_601767_EF70A8B2 X-CRM114-Status: GOOD ( 26.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, Suzuki K Poulose , linux-kernel@vger.kernel.org, Eric Auger , Robert Richter , James Morse , Julien Thierry , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIDIwMjAvMy8yMCAxNzowMSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFpl bmdodWksCj4gCj4gT24gMjAyMC0wMy0yMCAwMzo1MywgWmVuZ2h1aSBZdSB3cm90ZToKPj4gSGkg TWFyYywKPj4KPj4gT24gMjAyMC8zLzE5IDIwOjEwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4g QnV0IEkgd29uZGVyIHRoYXQgc2hvdWxkIHdlIHVzZSBuYXNzZ2lyZXEgdG8gKm9ubHkqIGtlZXAg dHJhY2sgd2hhdAo+Pj4+IHRoZSBndWVzdCBoYWQgd3JpdHRlbiBpbnRvIHRoZSBHSUNEX0NUTFIu bkFTU0dJcmVxLsKgIElmIG5vdCwgd2UgbWF5Cj4+Pj4gbG9zZSB0aGUgZ3Vlc3QtcmVxdWVzdCBi aXQgYWZ0ZXIgbWlncmF0aW9uIGFtb25nIGhvc3RzIHdpdGggZGlmZmVyZW50Cj4+Pj4gaGFzX2dp Y3Y0XzEgc2V0dGluZ3MuCj4+Pgo+Pj4gSSdtIHVuc3VyZSBvZiB3aGF0IHlvdSdyZSBzdWdnZXN0 aW5nIGhlcmUuIElmIHVzZXJzcGFjZSB0cmllcyB0byBzZXQKPj4+IEdJQ0RfQ1RMUi5uQVNTR0ly ZXEgb24gYSBub24tNC4xIGhvc3QsIHRoaXMgYml0IHdpbGwgbm90IGxhdGNoLgo+Pgo+PiBUaGlz IGlzIGV4YWN0bHkgd2hhdCBJICp3YXMqIGNvbmNlcm5pbmcgYWJvdXQuCj4+Cj4+PiBVc2Vyc3Bh Y2UgY2FuIGNoZWNrIHRoYXQgYXQgcmVzdG9yZSB0aW1lLiBPciB3ZSBjb3VsZCBmYWlsIHRoZQo+ Pj4gdXNlcnNwYWNlIHdyaXRlLCB3aGljaCBpcyBhIGJpdCBvZGQgKHRoZSBiaXQgaXMgb3RoZXJ3 aXNlIFJFUzApLgo+Pj4KPj4+IENvdWxkIHlvdSBjbGFyaWZ5IHlvdXIgcHJvcG9zYWw/Cj4+Cj4+ IExldCdzIGFzc3VtZSB0d28gaG9zdHMgYmVsb3cuICdoYXNfZ2ljdjRfMScgaXMgdHJ1ZSBvbiBo b3N0LUEgd2hpbGUKPj4gaXQgaXMgZmFsc2Ugb24gaG9zdC1CIGJlY2F1c2Ugb2YgbGFjayBvZiBI VyBzdXBwb3J0IG9yIHRoZSBrZXJuZWwKPj4gcGFyYW1ldGVyICJrdm0tYXJtLnZnaWNfdjRfZW5h YmxlPTAiLgo+Pgo+PiBJZiB3ZSBtaWdyYXRlIGd1ZXN0IHRocm91Z2ggQS0+Qi0+QSwgd2UgbWF5 IGVuZC11cCBsb3NlIHRoZSBpbml0aWFsCj4+IGd1ZXN0LXJlcXVlc3QgIm5BU1NHSXJlcT0xIiBh bmQgZG9uJ3QgdXNlIGRpcmVjdCB2U0dJIGRlbGl2ZXJ5IGZvcgo+PiB0aGlzIGd1ZXN0IHdoZW4g aXQncyBtaWdyYXRlZCBiYWNrIHRvIGhvc3QtQS4KPiAKPiBNeSBwb2ludCBhYm92ZSBpcyB0aGF0 IHdlIHNob3VsZG4ndCBhbGxvdyB0aGUgQS0+QiBtaWdyYXRpb24gdGhlIGZpcnN0Cj4gcGxhY2Us IGFuZCBmYWlsIGl0IGFzIHF1aWNrbHkgYXMgcG9zc2libGUuIFdlIGRvbid0IGtub3cgd2hhdCB0 aGUgZ3Vlc3QKPiBoYXMgb2JzZXJ2ZWQgaW4gdGVybXMgb2YgR0lDIGNhcGFiaWxpdHksIGFuZCBp dCBtYXkgbm90IGhhdmUgZW5hYmxlZCB0aGUKPiBuZXcgZmxhdm91ciBvZiBTR0lzIGp1c3QgeWV0 LgoKSW5kZWVkLiBJIGRpZG4ndCByZWFsaXplIGl0LgoKPiAKPj4gVGhpcyBjYW4gYmUgImZpeGVk IiBieSBrZWVwIHRyYWNrIG9mIHdoYXQgZ3Vlc3QgaGFkIHdyaXR0ZW4gaW50bwo+PiBuQVNTR0ly ZXEuIEFuZCB3ZSBuZWVkIHRvIGV2YWx1YXRlIHRoZSBuZWVkIGZvciB1c2luZyBkaXJlY3QgdlNH SQo+PiBmb3IgYSBzcGVjaWZpZWQgZ3Vlc3QgYnkgJ2hhc19naWN2NF8xICYmIG5hc3NnaXJlcScu Cj4gCj4gSXQgZmVlbHMgb2RkLiBJdCBtZWFucyB3ZSBoYXZlIG1vcmUgc3RhdGUgdGhhbiB0aGUg SFcgbm9ybWFsbHkgaGFzLgo+IEkgaGF2ZSBhbiBhbHRlcm5hdGl2ZSBwcm9wb3NhbCwgc2VlIGJl bG93Lgo+IAo+PiBCdXQgaWYgaXQncyBleHBlY3RlZCB0aGF0ICJpZiB1c2Vyc3BhY2UgdHJpZXMg dG8gc2V0IG5BU1NHSXJlcSBvbgo+PiBhIG5vbi00LjEgaG9zdCwgdGhpcyBiaXQgd2lsbCBub3Qg bGF0Y2giLCB0aGVuIHRoaXMgc2hvdWxkbid0IGJlCj4+IGEgcHJvYmxlbSBhdCBhbGwuCj4gCj4g V2VsbCwgdGhhdCBpcyB0aGUgc2VtYW50aWNzIG9mIHRoZSBSRVMwIGJpdC4gSXQgYXBwbGllcyBm cm9tIGJvdGgKPiBndWVzdCBhbmQgdXNlcnNwYWNlLgo+IAo+IEFuZCBhY3R1YWxseSwgbWF5YmUg d2UgY2FuIGhhbmRsZSB0aGF0IHByZXR0eSBjaGVhcGx5LiBJZiB1c2Vyc3BhY2UKPiB0cmllcyB0 byByZXN0b3JlIEdJQ0RfVFlQRVIyIHRvIGEgdmFsdWUgdGhhdCBpc24ndCB3aGF0IEtWTSBjYW4K PiBvZmZlciwgd2UganVzdCByZXR1cm4gYW4gZXJyb3IuIEV4YWN0bHkgbGlrZSB3ZSBkbyBmb3Ig R0lDRF9JSURSLgo+IEhlbmNlIHRoZSBmb2xsb3dpbmcgcGF0Y2g6Cj4gCj4gZGlmZiAtLWdpdCBh L3ZpcnQva3ZtL2FybS92Z2ljL3ZnaWMtbW1pby12My5jIAo+IGIvdmlydC9rdm0vYXJtL3ZnaWMv dmdpYy1tbWlvLXYzLmMKPiBpbmRleCAyOGI2MzlmZDFhYmMuLmU3MmRjYzQ1NDI0NyAxMDA2NDQK PiAtLS0gYS92aXJ0L2t2bS9hcm0vdmdpYy92Z2ljLW1taW8tdjMuYwo+ICsrKyBiL3ZpcnQva3Zt L2FybS92Z2ljL3ZnaWMtbW1pby12My5jCj4gQEAgLTE1Niw2ICsxNTYsNyBAQCBzdGF0aWMgaW50 IHZnaWNfbW1pb191YWNjZXNzX3dyaXRlX3YzX21pc2Moc3RydWN0IAo+IGt2bV92Y3B1ICp2Y3B1 LAo+ICDCoMKgwqDCoCBzdHJ1Y3QgdmdpY19kaXN0ICpkaXN0ID0gJnZjcHUtPmt2bS0+YXJjaC52 Z2ljOwo+IAo+ICDCoMKgwqDCoCBzd2l0Y2ggKGFkZHIgJiAweDBjKSB7Cj4gK8KgwqDCoCBjYXNl IEdJQ0RfVFlQRVIyOgo+ICDCoMKgwqDCoCBjYXNlIEdJQ0RfSUlEUjoKPiAgwqDCoMKgwqDCoMKg wqDCoCBpZiAodmFsICE9IHZnaWNfbW1pb19yZWFkX3YzX21pc2ModmNwdSwgYWRkciwgbGVuKSkK PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+IAo+IEJlaW5nIGEg Uk8gcmVnaXN0ZXIsIHdyaXRpbmcgc29tZXRoaW5nIHRoYXQgaXNuJ3QgY29tcGF0aWJsZSB3aXRo IHRoZQo+IHBvc3NpYmxlIGJlaGF2aW91ciBvZiB0aGUgaHlwZXJ2aXNvciB3aWxsIGp1c3QgcmV0 dXJuIGFuIGVycm9yLgoKVGhpcyBpcyByZWFsbHkgYSBuaWNlIHBvaW50IHRvIGFkZHJlc3MgbXkg Y29uY2VybiEgSSdtIGhhcHB5IHRvIHNlZQp0aGlzIGluIHY2IG5vdy4KCj4gCj4gV2hhdCBkbyB5 b3UgdGhpbms/CgpJIGFncmVlZCB3aXRoIHlvdSwgd2l0aCBhIGJpdCBuZXJ2b3VzIHRob3VnaC4g U29tZSBvbGQgZ3Vlc3RzICh3aGljaApoYXZlIG5vIGtub3dsZWRnZSBhYm91dCBHSUN2NC4xIHZT R0lzIGFuZCBkb24ndCBjYXJlIGFib3V0IG5BU1NHSWNhcAphdCBhbGwpIHdpbGwgYWxzbyBmYWls IHRvIG1pZ3JhdGUgZnJvbSBBIHRvIEIsIGp1c3QgYmVjYXVzZSBub3cgd2UKcHJlc2VudCB0d28g ZGlmZmVyZW50ICh1bnVzZWQpIEdJQ0RfVFlQRVIyIHJlZ2lzdGVycyB0byB0aGVtLgoKSXMgaXQg YSBsaXR0bGUgdW5mYWlyIHRvIHRoZW0gOi0pID8KCgpUaGFua3MsClplbmdodWkKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==