From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BB2C07E95 for ; Sat, 3 Jul 2021 00:16:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 904EB61429 for ; Sat, 3 Jul 2021 00:16:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 904EB61429 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EFBB4803B2; Sat, 3 Jul 2021 02:16:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 74219829F0; Sat, 3 Jul 2021 00:19:12 +0200 (CEST) Received: from server242-5.web-hosting.com (server242-5.web-hosting.com [199.188.200.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 490CF829B9 for ; Sat, 3 Jul 2021 00:19:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=runtimeterror.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=badsector@runtimeterror.com Received: from ppp089044094226.access.hol.gr ([89.44.94.226]:60596 helo=[192.168.2.2]) by server242.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lzRUy-004HaX-Nr; Fri, 02 Jul 2021 18:19:06 -0400 Subject: Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup To: Sean Anderson , Rasmus Villemoes , u-boot@lists.denx.de, Tom Rini Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Wolfgang Denk , Simon Glass , Roland Gaudig , Heinrich Schuchardt References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-4-seanga2@gmail.com> From: Kostas Michalopoulos Message-ID: Date: Sat, 3 Jul 2021 01:18:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server242.web-hosting.com X-AntiAbuse: Original Domain - lists.denx.de X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - runtimeterror.com X-Get-Message-Sender-Via: server242.web-hosting.com: authenticated_id: badsector@runtimeterror.com X-Authenticated-Sender: server242.web-hosting.com: badsector@runtimeterror.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-Mailman-Approved-At: Sat, 03 Jul 2021 02:16:18 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/2/2021 4:38 PM, Sean Anderson wrote: > I have not. I'm not sure what changes I've made are compatible with the > vision he has for LIL. He's CC'd on this series, so perhaps he can > comment. Yeah, sadly several of the changes i've seen in the code are not backwards compatible and backwards compatibility is very important for me (this is also why the callback setup is done through a lil_callback function instead of exposing a struct: adding new callbacks in the future wont break any existing code or application that links to the library dynamically). I might break it before a properly versioned release is made at some point in the (not close) future, but that is usually unavoidable changes to fix big issues (all cases where that happened are mentioned in the site). In terms of future changes, i do not plan making any *big* changes - and certainly anything i'll make it'll be backwards compatible (especially after a versioned release) but one thing that i need to do is to improve the interpreter's performance, which will affect its internals - two areas i might need to change are how values are represented (everything is a string -and things must always behave like that- but i may need to cache already parsed non-string values) and how the code itself -e.g. in functions- is represented. Also i'll most likely add more functions to the library to expose and alter internal state (the Free Pascal version of LIL already has some of that), but that shouldn't affect much internally. Beyond that it will be mainly bugfixes - like a use-after-free case with "reflect this" i just fixed and uploaded :-P Kostas