From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pankaj.dubey" Subject: Re: [PATCH v9 02/12] ARM: EXYNOS: remove usage of soc_is_exynosMMMM from pm.c Date: Fri, 7 Apr 2017 19:43:23 +0530 Message-ID: References: <1490879826-16754-1-git-send-email-pankaj.dubey@samsung.com> <1490879826-16754-3-git-send-email-pankaj.dubey@samsung.com> <6cf529ca-a28a-6757-39aa-5ef2e5391e16@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:38184 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755430AbdDGOKJ (ORCPT ); Fri, 7 Apr 2017 10:10:09 -0400 Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by epoutp01.samsung.com (KnoxPortal) with ESMTP id 20170407141007epoutp01a8e26f520c9e2aa0b0590105f402d5e4~zItbBmNFF0434404344epoutp01v for ; Fri, 7 Apr 2017 14:10:07 +0000 (GMT) In-Reply-To: Content-Language: en-US Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, Marek Szyprowski , kgene@kernel.org, m.reichl@fivetechno.de, a.hajda@samsung.com, cwchoi00@gmail.com, Javier Martinez Canillas On Friday 07 April 2017 05:54 PM, Krzysztof Kozlowski wrote: > On Fri, Apr 7, 2017 at 2:12 PM, pankaj.dubey wrote: >> >> >> On Friday 07 April 2017 01:54 PM, Krzysztof Kozlowski wrote: >>> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey wrote: >>>> soc_is_exynosMMMM is staged for removal after adopting to exynos-chipid >>>> driver, so let's remove/minimize usage of any such helper function usage >>>> from pm.c. >>>> >>>> Signed-off-by: Pankaj Dubey >>>> --- >>>> arch/arm/mach-exynos/pm.c | 22 ++++++++++++---------- >>>> include/linux/soc/samsung/exynos-regs-pmu.h | 3 +++ >>>> 2 files changed, 15 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c >>>> index 1a7e5b5..4a73b02 100644 >>>> --- a/arch/arm/mach-exynos/pm.c >>>> +++ b/arch/arm/mach-exynos/pm.c >>>> @@ -123,11 +123,13 @@ int exynos_pm_central_resume(void) >>>> } >>>> >>>> /* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */ >>>> -static void exynos_set_wakeupmask(long mask) >>>> +static void exynos_set_wakeupmask(void) >>>> { >>>> - pmu_raw_writel(mask, S5P_WAKEUP_MASK); >>>> - if (soc_is_exynos3250()) >>>> + if (of_machine_is_compatible("samsung,exynos3250")) { >>>> + pmu_raw_writel(EXYNOS3_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK); >>>> pmu_raw_writel(0x0, S5P_WAKEUP_MASK2); >>>> + } else >>>> + pmu_raw_writel(EXYNOS_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK); >>> >>> You need {} around this too. Checkpatch should complain about it as >>> well so be sure to run it. >>> >> >> I ran checkpatch before posting, but it didn't complain about this. Here >> is the result when I ran it again today on the same patch. >> >> ./scripts/checkpatch.pl >> exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch >> >> total: 0 errors, 0 warnings, 81 lines checked >> >> exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch >> has no obvious style problems and is ready for submission. > > Ahh, okay, my bad. :) > But anyway please fix it. OK will take care in next patchset. Thanks, Pankaj Dubey > > Best regards, > Krzysztof > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: pankaj.dubey@samsung.com (pankaj.dubey) Date: Fri, 7 Apr 2017 19:43:23 +0530 Subject: [PATCH v9 02/12] ARM: EXYNOS: remove usage of soc_is_exynosMMMM from pm.c In-Reply-To: References: <1490879826-16754-1-git-send-email-pankaj.dubey@samsung.com> <1490879826-16754-3-git-send-email-pankaj.dubey@samsung.com> <6cf529ca-a28a-6757-39aa-5ef2e5391e16@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 07 April 2017 05:54 PM, Krzysztof Kozlowski wrote: > On Fri, Apr 7, 2017 at 2:12 PM, pankaj.dubey wrote: >> >> >> On Friday 07 April 2017 01:54 PM, Krzysztof Kozlowski wrote: >>> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey wrote: >>>> soc_is_exynosMMMM is staged for removal after adopting to exynos-chipid >>>> driver, so let's remove/minimize usage of any such helper function usage >>>> from pm.c. >>>> >>>> Signed-off-by: Pankaj Dubey >>>> --- >>>> arch/arm/mach-exynos/pm.c | 22 ++++++++++++---------- >>>> include/linux/soc/samsung/exynos-regs-pmu.h | 3 +++ >>>> 2 files changed, 15 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c >>>> index 1a7e5b5..4a73b02 100644 >>>> --- a/arch/arm/mach-exynos/pm.c >>>> +++ b/arch/arm/mach-exynos/pm.c >>>> @@ -123,11 +123,13 @@ int exynos_pm_central_resume(void) >>>> } >>>> >>>> /* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */ >>>> -static void exynos_set_wakeupmask(long mask) >>>> +static void exynos_set_wakeupmask(void) >>>> { >>>> - pmu_raw_writel(mask, S5P_WAKEUP_MASK); >>>> - if (soc_is_exynos3250()) >>>> + if (of_machine_is_compatible("samsung,exynos3250")) { >>>> + pmu_raw_writel(EXYNOS3_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK); >>>> pmu_raw_writel(0x0, S5P_WAKEUP_MASK2); >>>> + } else >>>> + pmu_raw_writel(EXYNOS_WAKEUP_MASK_VAL, S5P_WAKEUP_MASK); >>> >>> You need {} around this too. Checkpatch should complain about it as >>> well so be sure to run it. >>> >> >> I ran checkpatch before posting, but it didn't complain about this. Here >> is the result when I ran it again today on the same patch. >> >> ./scripts/checkpatch.pl >> exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch >> >> total: 0 errors, 0 warnings, 81 lines checked >> >> exynos-chipid-v9/0002-ARM-EXYNOS-remove-usage-of-soc_is_exynosMMMM-from-pm.patch >> has no obvious style problems and is ready for submission. > > Ahh, okay, my bad. :) > But anyway please fix it. OK will take care in next patchset. Thanks, Pankaj Dubey > > Best regards, > Krzysztof > > >