All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, robh+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 7/7] tsnep: Rework RX buffer allocation
Date: Fri, 23 Sep 2022 21:33:40 +0200	[thread overview]
Message-ID: <cf75ebb5-c8ab-ed41-9256-57a55b2d18da@engleder-embedded.com> (raw)
In-Reply-To: <20220921180152.002dea73@kernel.org>

On 22.09.22 03:01, Jakub Kicinski wrote:
> On Thu, 15 Sep 2022 22:36:37 +0200 Gerhard Engleder wrote:
>> Try to refill RX queue continously instead of dropping frames if
>> allocation fails. This seems to be the more common pattern for network
>> drivers and makes future XDP support simpler.
> 
> Is there anything preventing the queue from becoming completely empty
> and potentially never getting refilled?
> 
> The lazy refill usually comes with some form of a watchdog / periodic
> depletion check.

You are right, I need to improve that. I will remove that commit for
now and rework it.

      reply	other threads:[~2022-09-23 19:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 20:36 [PATCH net-next 0/7] tsnep: multi queue support and some other improvements Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 1/7] dt-bindings: net: tsnep: Allow dma-coherent Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 2/7] dt-bindings: net: tsnep: Allow additional interrupts Gerhard Engleder
2022-09-22  0:42   ` Jakub Kicinski
2022-09-23 11:32   ` Krzysztof Kozlowski
2022-09-23 19:22     ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 3/7] tsnep: Move interrupt from device to queue Gerhard Engleder
2022-09-22  0:57   ` Jakub Kicinski
2022-09-23 19:23     ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 4/7] tsnep: Support multiple TX/RX queue pairs Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 5/7] tsnep: Add EtherType RX flow classification support Gerhard Engleder
2022-09-22  0:59   ` Jakub Kicinski
2022-09-23 19:29     ` Gerhard Engleder
2022-09-22  1:00   ` Jakub Kicinski
2022-09-23 19:24     ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 6/7] tsnep: Use page pool for RX Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 7/7] tsnep: Rework RX buffer allocation Gerhard Engleder
2022-09-22  1:01   ` Jakub Kicinski
2022-09-23 19:33     ` Gerhard Engleder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf75ebb5-c8ab-ed41-9256-57a55b2d18da@engleder-embedded.com \
    --to=gerhard@engleder-embedded.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.