From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195B9C61DA4 for ; Wed, 22 Feb 2023 23:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjBVXtM (ORCPT ); Wed, 22 Feb 2023 18:49:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbjBVXtK (ORCPT ); Wed, 22 Feb 2023 18:49:10 -0500 Received: from mail.thelounge.net (mail.thelounge.net [91.118.73.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7586303D7 for ; Wed, 22 Feb 2023 15:49:09 -0800 (PST) Received: from [10.10.10.2] (rh.vpn.thelounge.net [10.10.10.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256)) (No client certificate requested) (Authenticated sender: h.reindl@thelounge.net) by mail.thelounge.net (THELOUNGE MTA) with ESMTPSA id 4PMXtL28X1zXKn; Thu, 23 Feb 2023 00:48:58 +0100 (CET) Message-ID: Date: Thu, 23 Feb 2023 00:48:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 3/3] md: Use optimal I/O size for last bitmap page Content-Language: en-US To: Christoph Hellwig , Jonathan Derrick Cc: Song Liu , linux-raid@vger.kernel.org, Xiao Ni , Paul Menzel , Sushma Kalakota References: <20230222215828.225-1-jonathan.derrick@linux.dev> <20230222215828.225-4-jonathan.derrick@linux.dev> From: Reindl Harald Organization: the lounge interactive design In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org Am 23.02.23 um 00:42 schrieb Christoph Hellwig: > On Wed, Feb 22, 2023 at 02:58:28PM -0700, Jonathan Derrick wrote: >> + if (io_size != opt_size && >> + start + opt_size / SECTOR_SIZE <= boundary) >> + return opt_size; >> + else if (start + io_size / SECTOR_SIZE <= boundary) > > No need for an else after a return. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig the "return" is within the if-condition and has nothing to do with the else - with {} it would be clearly visible