From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F08C2BA1A for ; Fri, 24 Apr 2020 08:58:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FB5320736 for ; Fri, 24 Apr 2020 08:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="n2Toi1du" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FB5320736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRu9u-00071Y-SV; Fri, 24 Apr 2020 08:58:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRu9t-00071T-DM for xen-devel@lists.xenproject.org; Fri, 24 Apr 2020 08:58:05 +0000 X-Inumbo-ID: b56ef6be-8609-11ea-b58d-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b56ef6be-8609-11ea-b58d-bc764e2007e4; Fri, 24 Apr 2020 08:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/2MdC1L2ctLyBgf8w95S/LG9XnIkM4mVUCRkMzC5qwk=; b=n2Toi1du1DrCn+60YE5XMS71Kh i/Hz3kAK1HDzwEHscetMFyF7SGZ2bwqVcHloQZXRkH7I9h6N8bgmHj7HsdPg5jS13vDj4ghwaeUkY 9o5uBipzKoSEYMw1QkyHKHzS7NEDTf25FIq2SWQ/KqfYUbgu/DEOTfdSGdkxDrmibQYo=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jRu9r-0003Lw-1a; Fri, 24 Apr 2020 08:58:03 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jRu9q-0003Xq-PV; Fri, 24 Apr 2020 08:58:02 +0000 Subject: Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table To: Hongyan Xia , xen-devel@lists.xenproject.org References: <12c4fe0c0c05b9f76377c085d8a6558beae64003.1587116799.git.hongyxia@amazon.com> From: Julien Grall Message-ID: Date: Fri, 24 Apr 2020 09:58:00 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <12c4fe0c0c05b9f76377c085d8a6558beae64003.1587116799.git.hongyxia@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, On 17/04/2020 10:52, Hongyan Xia wrote:> diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c> index e85ef449f3..18210405f4 100644> --- a/xen/arch/x86/x86_64/mm.c> +++ b/xen/arch/x86/x86_64/mm.c> @@ -737,8 +737,8 @@ static void cleanup_frame_table(struct mem_hotadd_info *info)> > while (sva < eva)> {> - l3e = l4e_to_l3e(idle_pg_table[l4_table_offset(sva)])[> - l3_table_offset(sva)];> + l3e = l3e_from_l4e(idle_pg_table[l4_table_offset(sva)],> + l3_table_offset(sva)); This macro doesn't exist yet in the tree. It would be good to spell out the dependencies in the cover letter so this doesn't get merged before the dependency is merged. Reviewed-by: Julien Grall Cheers, -- Julien Grall