All of lore.kernel.org
 help / color / mirror / Atom feed
From: wangyunjian <wangyunjian@huawei.com>
To: <dev@dpdk.org>
Cc: <matan@nvidia.com>, <shahafs@nvidia.com>,
	<viacheslavo@nvidia.com>, <dingxiaoxiong@huawei.com>,
	Yunjian Wang <wangyunjian@huawei.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device configured repeatedly
Date: Thu, 13 May 2021 11:39:54 +0800	[thread overview]
Message-ID: <cf94d2836a3c29222a3a1cafa48996c8cebc1a0d.1620876356.git.wangyunjian@huawei.com> (raw)
In-Reply-To: <cover.1620876356.git.wangyunjian@huawei.com>

From: Yunjian Wang <wangyunjian@huawei.com>

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
    rte_eth_dev_configure
    rte_eth_rx_queue_setup
    rte_eth_tx_queue_setup
    rte_eth_dev_start
    rte_eth_dev_stop
done

Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/mlx5/mlx5.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 35f91e965e..cf1815cb74 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1455,6 +1455,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
 	struct mlx5_proc_priv *ppriv;
 	size_t ppriv_size;
 
+	mlx5_proc_priv_uninit(dev);
 	/*
 	 * UAR register table follows the process private structure. BlueFlame
 	 * registers for Tx queues are stored in the table.
-- 
2.23.0


  parent reply	other threads:[~2021-05-13  3:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 13:18 [dpdk-dev] [PATCH 0/2] fixes for mlx4/mlx5 wangyunjian
2021-05-13  3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
2021-05-13  3:38   ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
2021-05-13  6:46     ` Slava Ovsiienko
2021-05-13  3:39   ` wangyunjian [this message]
2021-05-13  6:47     ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: " Slava Ovsiienko
2021-05-13 12:37   ` [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5 Thomas Monjalon
2021-05-13 12:51   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf94d2836a3c29222a3a1cafa48996c8cebc1a0d.1620876356.git.wangyunjian@huawei.com \
    --to=wangyunjian@huawei.com \
    --cc=dev@dpdk.org \
    --cc=dingxiaoxiong@huawei.com \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.