From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH v5] net/failsafe: fix probe cleanup Date: Wed, 9 May 2018 23:55:37 +0100 Message-ID: References: <1525881459-3643-1-git-send-email-rasland@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, matan@mellanox.com, thomas@monjalon.net, ophirmu@mellanox.com, stable@dpdk.org To: Raslan Darawsheh , gaetan.rivet@6wind.com Return-path: In-Reply-To: <1525881459-3643-1-git-send-email-rasland@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/9/2018 4:57 PM, Raslan Darawsheh wrote: > The hot-plug alarm mechanism is responsible to practically execute both > plug in and out operations. It periodically tries to detect missed > sub-devices to be reconfigured and clean the resources of the removed > sub-devices. > > The hot-plug alarm is started by the failsafe probe function, and it's > wrongly not stopped if failsafe instance got an error. for example > when starting failsafe with a MAC option, and giving it an invalid MAC > address this will lead to a NULL pointer for the dev private field. Then > when the hotplug alarm is called it will try to access this pointer, > which will lead to a segmentation fault. > > Uninstall the hot-plug alarm in case of error in probe function. > > Fixes: ebea83f8 ("net/failsafe: add plug-in support") > Cc: stable@dpdk.org > > Signed-off-by: Raslan Darawsheh > Acked-by: Matan Azrad > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.