From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "fam@euphon.net" <fam@euphon.net>,
Denis Lunev <den@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/3] Fix overflow bug in qcow2 discard
Date: Mon, 3 Jun 2019 13:52:17 +0000 [thread overview]
Message-ID: <cf96dd79-14a2-7dcd-62b8-c735c4e055cf@virtuozzo.com> (raw)
In-Reply-To: <20190603134054.GF6523@linux.fritz.box>
03.06.2019 16:40, Kevin Wolf wrote:
> Am 23.04.2019 um 14:57 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> v5: by Kevin's comments
>> 02: add check for invalid @bytes parameter, drop r-b
>> 03: move from qemu-img info to qemu-img map -f raw, drop r-b and t-b
>
> The patches look good to me, but the test case fails (this is on XFS; it
> does work on tmpfs):
>
> --- /home/kwolf/source/qemu/tests/qemu-iotests/250.out 2019-06-03 15:22:51.212961123 +0200
> +++ /home/kwolf/source/qemu/tests/qemu-iotests/250.out.bad 2019-06-03 15:37:37.202959101 +0200
> @@ -12,12 +12,10 @@
> 0 0xa00000 0x82f00000 TEST_DIR/t.qcow2
> 0x82a00000 0xa00000 0x500000 TEST_DIR/t.qcow2
> Offset Length Mapped to File
> -0 0x301000 0 TEST_DIR/t.qcow2
> -0x400000 0xb00000 0x400000 TEST_DIR/t.qcow2
> +0 0xf00000 0 TEST_DIR/t.qcow2
> 0x82f00000 0xa00000 0x82f00000 TEST_DIR/t.qcow2
> Image resized.
> Offset Length Mapped to File
> -0 0x301000 0 TEST_DIR/t.qcow2
> -0x400000 0x100000 0x400000 TEST_DIR/t.qcow2
> +0 0x500000 0 TEST_DIR/t.qcow2
> 0x82f00000 0x500000 0x82f00000 TEST_DIR/t.qcow2
> *** done
>
> I'll apply the first two patches without the test for now, but please
> try if you can tweak the test case to work on all common filesystems.
>
> Kevin
>
Thank you! OK, I'll try
--
Best regards,
Vladimir
prev parent reply other threads:[~2019-06-03 14:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 12:57 [Qemu-devel] [PATCH v5 0/3] Fix overflow bug in qcow2 discard Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` [Qemu-devel] [PATCH v5 1/3] block/qcow2-refcount: add trace-point to qcow2_process_discards Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` [Qemu-devel] [PATCH v5 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` Vladimir Sementsov-Ogievskiy
2019-04-30 9:24 ` Stefano Garzarella
2019-04-30 9:24 ` Stefano Garzarella
2019-04-30 10:03 ` Vladimir Sementsov-Ogievskiy
2019-04-30 10:03 ` Vladimir Sementsov-Ogievskiy
2019-04-30 11:09 ` Kevin Wolf
2019-04-30 11:09 ` Kevin Wolf
2019-04-30 15:41 ` Eric Blake
2019-05-02 9:11 ` Stefano Garzarella
2019-05-02 9:11 ` Stefano Garzarella
2019-05-06 11:47 ` Vladimir Sementsov-Ogievskiy
2019-04-30 14:25 ` Stefano Garzarella
2019-04-30 14:25 ` Stefano Garzarella
2019-04-23 12:57 ` [Qemu-devel] [PATCH v5 3/3] iotests: test big qcow2 shrink Vladimir Sementsov-Ogievskiy
2019-04-23 12:57 ` Vladimir Sementsov-Ogievskiy
2019-05-21 9:38 ` [Qemu-devel] [PATCH v5 0/3] Fix overflow bug in qcow2 discard Vladimir Sementsov-Ogievskiy
2019-06-03 12:30 ` [Qemu-devel] ping " Vladimir Sementsov-Ogievskiy
2019-06-03 13:40 ` [Qemu-devel] " Kevin Wolf
2019-06-03 13:52 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf96dd79-14a2-7dcd-62b8-c735c4e055cf@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.