From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF19DC433FE for ; Sun, 13 Dec 2020 17:53:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1722322B51 for ; Sun, 13 Dec 2020 17:53:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1722322B51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koVYJ-00036A-Ts for qemu-devel@archiver.kernel.org; Sun, 13 Dec 2020 12:52:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koVWZ-0001jZ-LN; Sun, 13 Dec 2020 12:51:11 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:33557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koVWX-0004kN-Qy; Sun, 13 Dec 2020 12:51:11 -0500 Received: from [192.168.100.1] ([82.252.135.218]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.103]) with ESMTPSA (Nemesis) id 1Mzz6s-1jri82473W-00x2Sp; Sun, 13 Dec 2020 18:50:53 +0100 Subject: Re: [PATCH RESEND v2 6/7] blockdev: Fix a memleak in drive_backup_prepare() To: Chen Qun , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: <20201023061218.2080844-1-kuhn.chenqun@huawei.com> <20201023061218.2080844-7-kuhn.chenqun@huawei.com> From: Laurent Vivier Message-ID: Date: Sun, 13 Dec 2020 18:50:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201023061218.2080844-7-kuhn.chenqun@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:YnIZk7i0lm0le/12WpUq277Mzx7pIXIYdHt3bdAtkZheSbWsWKx Xt81xANMFj4Dh3bCY6aRX2OBQis13Wcrv/ecjfYn8TfZtiimm7u1BVVrDlgVWdlDDzggRg2 Es/l0cbboiMmXJLcNcr58T5sBhKUKrOm+gu2x7pKfiGB1DkZG89uwk+iWCMFzYtqeCF5Z83 9JBX/cUs9KTtewQT+9/Wg== X-UI-Out-Filterresults: notjunk:1;V03:K0:+MaX2wNA/kc=:B80c6Mb/VEFQ/OrXN9jkn1 juCiZLcVlxL8zwU772QW2HG/GOqFel3AD562BksNDjWQVOLdSboX/6d0UQ3WqNqgRR7dfAa4C zM3BLKchGEKnknd4tJiPmA/2JyPMEGk0geKG66bwcbrytbJWbJ0IlmK4NYMEvzimz+AF9gO7p sUMxrakx8JblYHVyPzZgxxA28ubTePCrO+VI48bjGSPYmznFSmBx280OjCCi+gHuFWRrt00/y sKxnZ9XZtZbiy/lcgkIeXjTmO7netbmCEp/cuH0MU2mLPJbuHmlhRIuqt3W+VBKWkF6+bnvNO Vd1XGvdy2AYmNLOMhZ/xtYXnfhoFm8vYuym4jKSCfCJoIQxdjAVK7X2i30v8/VKN5lbWatnVA sdP9plhrEJG847iNu7LDdN4L6Qqkf6pF5VOZ0+OzFftJ9jYfS88HnG8aJlqukLRcAusRDms0s MTvLdGv7Vw== Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Kevin Wolf , zhang.zhanghailiang@huawei.com, pannengyuan@huawei.com, Li Qiang , ganqixin@huawei.com, Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan > > 'local_err' seems forgot to propagate in error path, it'll cause > a memleak. Fix it. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > Reviewed-by: Kevin Wolf > Reviewed-by: Li Qiang > Signed-off-by: Chen Qun > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blockdev.c b/blockdev.c > index fe6fb5dc1d..6fd68f74f3 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1827,6 +1827,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp) > if (set_backing_hd) { > bdrv_set_backing_hd(target_bs, source, &local_err); > if (local_err) { > + error_propagate(errp, local_err); > goto unref; > } > } > Applied to my trivial-patches branch. Thanks, Laurent