From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
Mina Almasry <almasrymina@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Miaohe Lin <linmiaohe@huawei.com>,
Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>, Jue Wang <juew@google.com>,
Yang Yao <ygyao@google.com>, Joanna Li <joannali@google.com>,
Cannon Matthews <cannonmatthews@google.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file
Date: Fri, 12 Nov 2021 15:36:12 -0800 [thread overview]
Message-ID: <cfa5a07d-1a2a-abee-ef8c-63c5480af23d@oracle.com> (raw)
In-Reply-To: <CAMZfGtWj5LU0ygDpH9B58R48kM8w3tnowQDD53VNMifSs5uvig@mail.gmail.com>
Subject: Re: [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file
To: Muchun Song <songmuchun@bytedance.com>, Mina Almasry <almasrymina@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>, Miaohe Lin <linmiaohe@huawei.com>, Oscar Salvador <osalvador@suse.de>, Michal Hocko <mhocko@suse.com>, David Rientjes <rientjes@google.com>, Shakeel Butt <shakeelb@google.com>, Jue Wang <juew@google.com>, Yang Yao <ygyao@google.com>, Joanna Li <joannali@google.com>, Cannon Matthews <cannonmatthews@google.com>, Linux Memory Management List <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Bcc:
-=-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-
On 11/10/21 6:36 PM, Muchun Song wrote:
> On Thu, Nov 11, 2021 at 9:50 AM Mina Almasry <almasrymina@google.com> wrote:
>>
>> +struct hugetlb_cgroup_per_node {
>> + /* hugetlb usage in pages over all hstates. */
>> + atomic_long_t usage[HUGE_MAX_HSTATE];
>
> Why do you use atomic? IIUC, 'usage' is always
> increased/decreased under hugetlb_lock except
> hugetlb_cgroup_read_numa_stat() which is always
> reading it. So I think WRITE_ONCE/READ_ONCE
> is enough.
Thanks for continuing to work this, I was traveling and unable to
comment.
Unless I am missing something, I do not see a reason for WRITE_ONCE/READ_ONCE
and would suggest going back to the way this code was in v5.
--
Mike Kravetz
next prev parent reply other threads:[~2021-11-12 23:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 1:50 [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file Mina Almasry
2021-11-11 1:50 ` Mina Almasry
2021-11-11 2:04 ` Shakeel Butt
2021-11-11 2:36 ` Muchun Song
2021-11-11 2:59 ` Shakeel Butt
2021-11-12 23:36 ` Mike Kravetz [this message]
2021-11-13 2:44 ` Muchun Song
2021-11-13 14:48 ` Mina Almasry
2021-11-13 19:15 ` Shakeel Butt
2021-11-14 13:43 ` Muchun Song
2021-11-15 18:22 ` Mike Kravetz
2021-11-15 18:55 ` Mina Almasry
2021-11-15 19:59 ` Shakeel Butt
2021-11-16 12:04 ` Marco Elver
2021-11-16 20:48 ` Mina Almasry
2021-11-16 20:59 ` Shakeel Butt
2021-11-16 21:47 ` Marco Elver
2021-11-16 21:53 ` Mina Almasry
2021-11-17 5:54 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa5a07d-1a2a-abee-ef8c-63c5480af23d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=cannonmatthews@google.com \
--cc=joannali@google.com \
--cc=juew@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=ygyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.