From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158C0C433EF for ; Tue, 1 Mar 2022 08:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233462AbiCAIqI (ORCPT ); Tue, 1 Mar 2022 03:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiCAIqG (ORCPT ); Tue, 1 Mar 2022 03:46:06 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14ED7CDE5; Tue, 1 Mar 2022 00:45:23 -0800 (PST) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K79ks30wnzBrNC; Tue, 1 Mar 2022 16:43:33 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 16:45:21 +0800 Subject: Re: [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE To: Yang Shi CC: , , , , , , , , , , , , , , References: <20220228235741.102941-1-shy828301@gmail.com> <20220228235741.102941-2-shy828301@gmail.com> From: Miaohe Lin Message-ID: Date: Tue, 1 Mar 2022 16:45:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220228235741.102941-2-shy828301@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/1 7:57, Yang Shi wrote: > MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by > khugepaged_enter(), not only when VM_HUGEPAGE is set on vma. Correct > the comment to avoid confusion. > > Signed-off-by: Yang Shi > --- > include/linux/sched/coredump.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > index 4d9e3a656875..4d0a5be28b70 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm) > #endif > /* leave room for more dump flags */ > #define MMF_VM_MERGEABLE 16 /* KSM may merge identical pages */ > -#define MMF_VM_HUGEPAGE 17 /* set when VM_HUGEPAGE is set on vma */ > +#define MMF_VM_HUGEPAGE 17 /* set when mm is available for > + khugepaged */ I think this comment could be written in one line. Anyway, this patch looks good to me. Thanks. Reviewed-by: Miaohe Lin > /* > * This one-shot flag is dropped due to necessity of changing exe once again > * on NFS restore >