From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7EAC433ED for ; Mon, 10 May 2021 01:12:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41B43613D6 for ; Mon, 10 May 2021 01:12:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbhEJBNb (ORCPT ); Sun, 9 May 2021 21:13:31 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:2606 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbhEJBNb (ORCPT ); Sun, 9 May 2021 21:13:31 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Fdjdz0tPBzlcpf; Mon, 10 May 2021 09:10:15 +0800 (CST) Received: from [10.67.77.175] (10.67.77.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 09:12:22 +0800 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan CC: , , , , , , , References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Shaokun Zhang Message-ID: Date: Mon, 10 May 2021 09:12:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.77.175] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Marc, On 2021/5/8 17:29, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Thanks for the tag, it works with this patch, So: Tested-by: Shaokun Zhang I shall invite you to have a drink for the quick debug. Anyway, thank you again. Shaokun > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED9DC433ED for ; Mon, 10 May 2021 01:12:36 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 8D17A613DB for ; Mon, 10 May 2021 01:12:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D17A613DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0A9734B580; Sun, 9 May 2021 21:12:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hG66nPDqLABI; Sun, 9 May 2021 21:12:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EFB9E4B4EB; Sun, 9 May 2021 21:12:33 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D87CF4B4EB for ; Sun, 9 May 2021 21:12:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7DWA3aBG7bNH for ; Sun, 9 May 2021 21:12:30 -0400 (EDT) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A109F4B4CB for ; Sun, 9 May 2021 21:12:30 -0400 (EDT) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Fdjdz0tPBzlcpf; Mon, 10 May 2021 09:10:15 +0800 (CST) Received: from [10.67.77.175] (10.67.77.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 09:12:22 +0800 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Shaokun Zhang Message-ID: Date: Mon, 10 May 2021 09:12:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.67.77.175] X-CFilter-Loop: Reflected Cc: kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, cohuck@redhat.com, stable@vger.kernel.org, alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, On 2021/5/8 17:29, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Thanks for the tag, it works with this patch, So: Tested-by: Shaokun Zhang I shall invite you to have a drink for the quick debug. Anyway, thank you again. Shaokun > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB19C433B4 for ; Mon, 10 May 2021 01:14:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CCDC6112F for ; Mon, 10 May 2021 01:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CCDC6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6dw7Ga7PpXkhtapzW51lIC87XsJ5RHMViNDnIeo884U=; b=mFyWXESfqpp0mkSCsuE1T/YHB dMLVX7ShE6L3VdYuebEDrHB9CpKd7x12fn/ASrmuxOuV893X0CtOtQoCnEZmWqaWAMwjFF2v3E+ao OhN4LbXfWC+TOOXcdozslyVPeR4U3Tia6YM0SfLB+jVka9/JfiZkY7EUyWHvznupl8/DYo6iGMlac bsWCqbqFSq6ntu2z/rPSBbYwM8FQZ7yU+TEb2I0o6DZpSsG+7QoahfVYi+e2GI5GtKfle9R+/bIb0 L93hXE6N4Zz/xWPTQ7VZVK6Xn2EACEJK/jARXtz3dTeMIPRHvYPKZJk1BQABlkZy7tjxk5i9CJI49 QDn0z/uog==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfuTV-00Cg4M-HZ; Mon, 10 May 2021 01:12:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfuTP-00Cg3I-CW for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 01:12:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=/li9giAO2PWJKLeFX+pKYrqHOr8PJKPya5kALqG57Ok=; b=VArkwhXVzMHak5Sq/CMFelfpbd FLBS3Mr4EE0204RJj3X6KRtFjoyZ12HjSgrnAxBln6c26ncRe31UqEo2R7OMeFMSd9memY99EeWen NJ0aPmIuo5pjC0ULCk/Oqlbp+atDLaq8Zg/JAunNzAgMcH+eSCUa38veG0DpZxRe/yO33Ij1OOkBG GmrQ5VPSlz3a1tp6G3U4Z3AOSYZbzsnrqPvl1eu1Tw5YWC+Tm9q0waa/aEynTFSLojXAQvmlpG6/g jc3kkBfx++OaEnMpsifyZaR791Tgp8cEez+9L8k4yb+SeeC8M+8xvOHYjTLdnz178+r41KdzKt0Ae jSohupRA==; Received: from szxga06-in.huawei.com ([45.249.212.32]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfuTM-008Bfc-6U for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 01:12:38 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Fdjdz0tPBzlcpf; Mon, 10 May 2021 09:10:15 +0800 (CST) Received: from [10.67.77.175] (10.67.77.175) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 09:12:22 +0800 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: Marc Zyngier , Zhu Lingshan CC: , , , , , , , References: <20210508071152.722425-1-lingshan.zhu@intel.com> <8735uxvajh.wl-maz@kernel.org> From: Shaokun Zhang Message-ID: Date: Mon, 10 May 2021 09:12:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8735uxvajh.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.67.77.175] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210509_181236_427452_04156468 X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 2021/5/8 17:29, Marc Zyngier wrote: > On Sat, 08 May 2021 08:11:52 +0100, > Zhu Lingshan wrote: >> >> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >> >> The reverted commit may cause VM freeze on arm64 platform. >> Because on arm64 platform, stop a consumer will suspend the VM, >> the VM will freeze without a start consumer > > It also unconditionally calls del_consumer on the producer, which > isn't exactly expected. > >> >> Signed-off-by: Zhu Lingshan > > Reported-by: Shaokun Zhang Thanks for the tag, it works with this patch, So: Tested-by: Shaokun Zhang I shall invite you to have a drink for the quick debug. Anyway, thank you again. Shaokun > Suggested-by: Marc Zyngier > Acked-by: Marc Zyngier > Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect") > Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com > Cc: stable@vger.kernel.org > > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel