Re: [PATCH] tune-ppce500v1: Add a tune file for PowerPC e500v1 cores

From: Khem Raj <raj.khem@gmail.com>
To: chunrong.guo@nxp.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] tune-ppce500v1: Add a tune file for PowerPC e500v1 cores
Date: Thu, 14 Jun 2018 09:36:16 -0700	[thread overview]
Message-ID: <cfb8f094-4f7a-5816-113d-1014d4180649@gmail.com> (raw)
In-Reply-To: <1528968301-3209-1-git-send-email-chunrong.guo@nxp.com>

[-- Attachment #1.1: Type: text/plain, Size: 1896 bytes --]

Hi Chunrong

On 6/14/18 2:25 AM, chunrong.guo@nxp.com wrote:
> From: Chunrong Guo <chunrong.guo@nxp.com>
> 
> Signed-off-by: Chunrong Guo <chunrong.guo@nxp.com>
> ---
>  meta/conf/machine/include/tune-ppce500v1.inc | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-ppce500v1.inc
> 
> diff --git a/meta/conf/machine/include/tune-ppce500v1.inc b/meta/conf/machine/include/tune-ppce500v1.inc
> new file mode 100644
> index 0000000..509c81b
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-ppce500v1.inc
> @@ -0,0 +1,20 @@
> +DEFAULTTUNE ?= "ppce500v1"
> +
> +require conf/machine/include/powerpc/arch-powerpc.inc
> +
> +TUNEVALID[ppce500v1] = "Enable ppce500v1 specific processor optimizations"
> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'ppce500v1', ' -mcpu=8540', '', d)}"
> +
> +TUNEVALID[spe] = "Enable SPE ABI extensions"
> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', [ 'ppce500v1', 'spe' ], ' -mabi=spe -mspe -mfloat-gprs=double', '', d)}"
> +TARGET_FPU .= "${@bb.utils.contains('TUNE_FEATURES', [ 'ppce500v1' , 'spe' ], 'ppc-efd', '', d)}"
> +
> +# spe is defined potentially in two places, so we want to be sure it will
> +# only write spe once to the ABIEXTENSIONS field.
> +SPEABIEXTENSION = "${@bb.utils.filter('TUNE_FEATURES', 'spe', d)}"
> +ABIEXTENSION .= "${SPEABIEXTENSION}"
> +
> +AVAILTUNES += "ppce500v1"
> +TUNE_FEATURES_tune-ppce500v1 = "m32 spe ppce500v1"
> +TUNE_PKGARCH_tune-ppce500v1 = "ppce500v1"
> +PACKAGE_EXTRA_ARCHS_tune-ppce500v1 = "ppce500v1"
> 

I must inform that spe backend is moved into obsoleted backends in gcc
and is slated to be gone in gcc9 unless someone shows up to maintain it.
With that in mind, I think we should wait and not add this to oe-core
since this will also become obsolete as we move to new compiler.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]