From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C9CC43461 for ; Thu, 17 Sep 2020 10:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BB6520770 for ; Thu, 17 Sep 2020 10:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbgIQKAU (ORCPT ); Thu, 17 Sep 2020 06:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgIQKAS (ORCPT ); Thu, 17 Sep 2020 06:00:18 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF14DC06174A; Thu, 17 Sep 2020 03:00:17 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kIqi5-005Vc1-O3; Thu, 17 Sep 2020 12:00:13 +0200 Message-ID: Subject: Re: [PATCH] lib: kunit: add bitfield test conversion to KUnit From: Johannes Berg To: Brendan Higgins , Vitor Massaru Iha Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, Andy Shevchenko , kvalo@codeaurora.org Date: Thu, 17 Sep 2020 12:00:12 +0200 In-Reply-To: (sfid-20200819_231025_419730_3D8DCC68) References: <20200729175849.148332-1-vitor@massaru.org> (sfid-20200819_231025_419730_3D8DCC68) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-08-19 at 14:10 -0700, Brendan Higgins wrote: > On Wed, Jul 29, 2020 at 10:58 AM Vitor Massaru Iha wrote: > > This adds the conversion of the runtime tests of test_bitfield, > > from `lib/test_bitfield.c` to KUnit tests. > > > > Please apply this commit first (linux-kselftest/kunit-fixes): > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space > > > > Code Style Documentation: [0] > > > > Signed-off-by: Vitor Massaru Iha > > Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/T/#u > > Reviewed-by: Brendan Higgins > > Probably still want a review from Johannes though. Huh, sorry, this slipped through the cracks. Yeah, don't really care, looks fine to me? I'm not familiar with the kunit infrastructure much yet. Not sure I see much value in converting TEST_BITFIELD_COMPILE to a KUNIT_CASE though, because anyway it will not compile if you enable that? IOW, just leaving the function there without any KUNIT_CASE() reference to it should be fine and saves you an ifdef ... johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C7EC433E2 for ; Thu, 17 Sep 2020 10:00:24 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13CA522205 for ; Thu, 17 Sep 2020 10:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13CA522205 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A2DED87870; Thu, 17 Sep 2020 10:00:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id feuRibS6N0RL; Thu, 17 Sep 2020 10:00:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id ADC8E87669; Thu, 17 Sep 2020 10:00:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91369C0859; Thu, 17 Sep 2020 10:00:21 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E42A3C0051 for ; Thu, 17 Sep 2020 10:00:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D5647875CE for ; Thu, 17 Sep 2020 10:00:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hFQwt72Xsz5m for ; Thu, 17 Sep 2020 10:00:18 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sipsolutions.net (s3.sipsolutions.net [144.76.43.62]) by hemlock.osuosl.org (Postfix) with ESMTPS id D8C73875C6 for ; Thu, 17 Sep 2020 10:00:17 +0000 (UTC) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kIqi5-005Vc1-O3; Thu, 17 Sep 2020 12:00:13 +0200 Message-ID: From: Johannes Berg To: Brendan Higgins , Vitor Massaru Iha Date: Thu, 17 Sep 2020 12:00:12 +0200 In-Reply-To: (sfid-20200819_231025_419730_3D8DCC68) References: <20200729175849.148332-1-vitor@massaru.org> (sfid-20200819_231025_419730_3D8DCC68) User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Cc: Linux Kernel Mailing List , Andy Shevchenko , "open list:KERNEL SELFTEST FRAMEWORK" , linux-kernel-mentees@lists.linuxfoundation.org, kvalo@codeaurora.org, KUnit Development Subject: Re: [Linux-kernel-mentees] [PATCH] lib: kunit: add bitfield test conversion to KUnit X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Wed, 2020-08-19 at 14:10 -0700, Brendan Higgins wrote: > On Wed, Jul 29, 2020 at 10:58 AM Vitor Massaru Iha wrote: > > This adds the conversion of the runtime tests of test_bitfield, > > from `lib/test_bitfield.c` to KUnit tests. > > > > Please apply this commit first (linux-kselftest/kunit-fixes): > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space > > > > Code Style Documentation: [0] > > > > Signed-off-by: Vitor Massaru Iha > > Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/T/#u > > Reviewed-by: Brendan Higgins > > Probably still want a review from Johannes though. Huh, sorry, this slipped through the cracks. Yeah, don't really care, looks fine to me? I'm not familiar with the kunit infrastructure much yet. Not sure I see much value in converting TEST_BITFIELD_COMPILE to a KUNIT_CASE though, because anyway it will not compile if you enable that? IOW, just leaving the function there without any KUNIT_CASE() reference to it should be fine and saves you an ifdef ... johannes _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees