From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kubecek <mkubecek@suse.cz>, netdev@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH RFC 4/4] netfilter: nf_tables: add netlink description
Date: Fri, 26 Apr 2019 22:51:25 +0200 [thread overview]
Message-ID: <cfcf08c7e29ce3dfc3209245c60beb021e7f421e.camel@sipsolutions.net> (raw)
In-Reply-To: <20190426204758.GK26549@unicorn.suse.cz>
On Fri, 2019-04-26 at 22:47 +0200, Michal Kubecek wrote:
> On Fri, Apr 26, 2019 at 09:14:43PM +0200, Johannes Berg wrote:
> > Yeah, ok. Each object you had is basically its own policy. I just
> > *removed* having a separate policy for each command in generic netlink,
> > as ;-)
>
> But that only affects genetlink users who let genetlink validate and
> parse messages for them. Those validating/parsing the messages
> themselves can still have different policy (and completely different set
> of attributes) for each command.
Sure. I already argued elsewhere though that you should only have one
policy for each set of attributes, but if you do in fact have different
attributes then that's perfectly valid.
Not sure whether I think it all that reasonable, since you then burden
userspace with having to know even more intricate detail and not being
able to share code well between commands, but hey :-)
johannes
prev parent reply other threads:[~2019-04-26 20:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 1:37 [PATCH RFC 0/4] Netlink bus descriptions Pablo Neira Ayuso
2018-02-07 1:37 ` [PATCH RFC 1/4] netlink: add NLA_PAD definition Pablo Neira Ayuso
2019-03-29 10:44 ` Johannes Berg
2018-02-07 1:37 ` [PATCH RFC 2/4] netlink: add generic object description infrastructure Pablo Neira Ayuso
2018-02-08 1:28 ` Randy Dunlap
2018-02-08 16:21 ` Pablo Neira Ayuso
2019-03-29 10:48 ` Johannes Berg
2018-02-07 1:37 ` [PATCH RFC 3/4] netfilter: nfnetlink: add support for netlink descriptions Pablo Neira Ayuso
2018-02-07 1:37 ` [PATCH RFC 4/4] netfilter: nf_tables: add netlink description Pablo Neira Ayuso
2019-03-29 10:59 ` Johannes Berg
2019-04-11 19:26 ` Pablo Neira Ayuso
2019-04-12 11:56 ` Johannes Berg
2019-04-26 16:42 ` Pablo Neira Ayuso
2019-04-26 17:17 ` Johannes Berg
2019-04-26 17:28 ` Johannes Berg
2019-04-26 18:04 ` Pablo Neira Ayuso
2019-04-26 19:14 ` Johannes Berg
2019-04-26 19:20 ` Pablo Neira Ayuso
2019-04-26 19:37 ` Johannes Berg
2019-04-26 19:46 ` Johannes Berg
2019-04-27 10:57 ` Pablo Neira Ayuso
2019-04-28 19:53 ` Johannes Berg
2019-04-27 10:52 ` Pablo Neira Ayuso
2019-04-28 19:51 ` Johannes Berg
2019-04-26 20:47 ` Michal Kubecek
2019-04-26 20:51 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfcf08c7e29ce3dfc3209245c60beb021e7f421e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.