From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCHv7 03/47] common/dpaa2: adding qbman driver
Date: Thu, 16 Feb 2017 11:27:55 +0530
Message-ID: <cfd37cad-2460-6eb2-c86b-6eff2f44096f@nxp.com>
References: <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com>
 <1487205586-6785-1-git-send-email-hemant.agrawal@nxp.com>
 <1487205586-6785-4-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, <dev@dpdk.org>,
 <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <john.mcnamara@intel.com>, <jerin.jacob@caviumnetworks.com>
To: <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0060.outbound.protection.outlook.com [104.47.33.60])
 by dpdk.org (Postfix) with ESMTP id B2D68378E
 for <dev@dpdk.org>; Thu, 16 Feb 2017 06:53:12 +0100 (CET)
In-Reply-To: <1487205586-6785-4-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

On Thursday 16 February 2017 06:09 AM, Hemant Agrawal wrote:
> QBMAN, is a hardware block which interfaces with the other
> accelerating hardware blocks (For e.g., WRIOP) on NXP's DPAA2
> SoC for queue, buffer and packet scheduling.
>
> This patch introduces a userspace driver for interfacing with
> the QBMAN hw block.
>
> The qbman-portal component provides APIs to do the low level
> hardware bit twiddling for operations such as:
>       -initializing Qman software portals
>       -building and sending portal commands
>       -portal interrupt configuration and processing
>
> This same/similar code is used in kernel and compat file is used
> to make it working in user space.
>
> Signed-off-by: Geoff Thorpe <Geoff.Thorpe@nxp.com>
> Signed-off-by: Roy Pledge <Roy.Pledge@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---

[snip]

> diff --git a/drivers/common/dpaa2/qbman/rte_common_dpaa2_qbman_version.map b/drivers/common/dpaa2/qbman/rte_common_dpaa2_qbman_version.map
> new file mode 100644
> index 0000000..f653421
> --- /dev/null
> +++ b/drivers/common/dpaa2/qbman/rte_common_dpaa2_qbman_version.map
> @@ -0,0 +1,27 @@
> +DPDK_17.02 {
> +	global:
> +
> +	qbman_check_command_complete;
> +	qbman_eq_desc_clear;
> +	qbman_eq_desc_set_fq;
> +	qbman_eq_desc_set_no_orp;
> +	qbman_eq_desc_set_qd;
> +	qbman_eq_desc_set_response;
> +	qbman_get_version;
> +	qbman_pull_desc_clear;
> +	qbman_pull_desc_set_fq;
> +	qbman_pull_desc_set_numframes;
> +	qbman_pull_desc_set_storage;
> +	qbman_release_desc_clear;
> +	qbman_release_desc_set_bpid;
> +	qbman_result_DQ_fd;
> +	qbman_result_DQ_flags;
> +	qbman_result_has_new_result;
> +	qbman_swp_acquire;
> +	qbman_swp_init;
> +	qbman_swp_pull;
> +	qbman_swp_release;
> +	qbman_swp_send_multiple;
> +
> +	local: *;
> +};
>

Just wanted to highlight that we have not yet changed the exported
variable in the v7 post. I have a draft patch (based on yours and
Neil's suggestions) which I will share soon.

That involves changing source between our internal repo to dpdk -
feasibility of this is where are discussions internally stand.