All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Alonso <joalonsof@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>,
	David Laight <David.Laight@ACULAB.COM>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] net: usb: ax88179_178a: ax88179_rx_fixup corrections
Date: Wed, 22 Jun 2022 00:56:48 -0300	[thread overview]
Message-ID: <cfe8c71d0291b5612afc3765da470c21a9fad87b.camel@gmail.com> (raw)
In-Reply-To: <8cd9e84dabcf2efbf80f3bc43326bbea8bd21a98.camel@redhat.com>


On Tue, 2022-06-21 at 11:03 +0200, Paolo Abeni wrote:
> 
> Possibly a slightly more accurate adjustment would be:
> 
>         /* for last skb */
>         skb->truesize = SKB_TRUESIZE(pkt_len_buf);
> 
>         /* for other skbs */
>         skb->truesize = pkt_len_buf + SKB_DATA_ALIGN(sizeof(struct sk_buff);

For now I will use your suggestion and resend the patch.
I will think about David suggestions.

Thanks

Jose Alonso




      reply	other threads:[~2022-06-22  3:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19  0:53 [PATCH v2] net: usb: ax88179_178a: ax88179_rx_fixup corrections Jose Alonso
2022-06-20  3:45 ` David Laight
2022-06-21  1:18   ` Jose Alonso
2022-06-21  8:29     ` David Laight
2022-06-21  9:03     ` Paolo Abeni
2022-06-22  3:56       ` Jose Alonso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfe8c71d0291b5612afc3765da470c21a9fad87b.camel@gmail.com \
    --to=joalonsof@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.